refactor: Tweak thresholds

BREAKING CHANGE

Author: sdn4z

src/twyn/base/constants.py

@@ -31,7 +31,7 @@
 }
 
 
-DEFAULT_SELECTOR_METHOD = "all"
+DEFAULT_SELECTOR_METHOD = "first-letter"
 DEFAULT_PROJECT_TOML_FILE = "pyproject.toml"
 DEFAULT_TWYN_TOML_FILE = "twyn.toml"
 DEFAULT_USE_CACHE = True

src/twyn/similarity/algorithm.py

@@ -11,7 +11,7 @@
 
 
 class SimilarityThreshold:
-    LENGTH_CUTOFF = 5
+    LENGTH_CUTOFF = 10
     MIN_VALUE = 1.0
     MAX_FOR_SHORT_WORDS = 1.0
     MAX_FOR_LONG_WORDS = 2.0

tests/config/test_config_handler.py

@@ -33,7 +33,7 @@ def test_no_enforce_file_on_non_existent_file(self, mock_is_file: Mock) -> None:
 
         assert config == TwynConfiguration(
             dependency_files=set(),
-            selector_method="all",
+            selector_method="first-letter",
             allowlist=set(),
             source=None,
             use_cache=True,

tests/main/test_main.py

@@ -35,7 +35,7 @@ class TestCheckDependencies:
         [
             (
                 {
-                    "selector_method": "first-letter",
+                    "selector_method": "all",
                     "dependency_file": {"requirements.txt"},
                     "use_cache": True,
                     "pypi_reference": "https://myurl.com",
@@ -51,7 +51,7 @@ class TestCheckDependencies:
                 },
                 TwynConfiguration(
                     dependency_files={"requirements.txt"},
-                    selector_method="first-letter",
+                    selector_method="all",
                     allowlist={"boto4", "boto2"},
                     source=TopPyPiReference.DEFAULT_SOURCE,
                     use_cache=True,
@@ -84,7 +84,7 @@ class TestCheckDependencies:
                 {},
                 TwynConfiguration(
                     dependency_files=set(),
-                    selector_method="all",
+                    selector_method="first-letter",
                     allowlist=set(),
                     source=TopPyPiReference.DEFAULT_SOURCE,
                     use_cache=True,

tests/trusted_packages/test_trusted_packages.py

@@ -71,10 +71,10 @@ def test_tree_representation(self):
                 [],
             ),  # distance is 1, inside threshold, but start with different letter
             (
-                "abcdef",
-                {"abcdefgh"},
+                "abcdefghijklm",
+                {"abcdefghijklmn"},
                 FirstLetterExact(),
-                ["abcdefgh"],
+                ["abcdefghijklmn"],
             ),  # distance is 2, inside threshold (because it's a longer word)
             # Nearby letters
             (
@@ -96,10 +96,10 @@ def test_tree_representation(self):
                 ["numpy"],
             ),  # distance is 1, inside threshold. First letter is changed and nearby
             (
-                "mumpyy",
-                {"numpy"},
+                "abcdefghijklm",
+                {"sbcdefghijklm"},
                 FirstLetterNearbyInKeyboard(),
-                ["numpy"],
+                ["sbcdefghijklm"],
             ),  # distance is 2, inside threshold. First letter is changed and nearby
             (
                 "rest_framework",