-
Notifications
You must be signed in to change notification settings - Fork 5
feat: replace poetry with uv #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d7f099 to
e517cbb
Compare
| # Test that the CLI is available and --version works | ||
| uv run twyn --version | ||
|
|
||
| should-test-docker-build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always testing if the docker image can be built would result in very slow builds. Instead, we only try to build it if there were any changes in the Dockerfile or .dockerignore files (the latter does not exist yet, but it's more future proof this way).
| platforms: linux/amd64,linux/arm64 | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| cache-from: type=registry,ref=ghcr.io/elementsinteractive/twyn:buildcache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll try to use cache in case it exists. This cache is ONLY created when publishing the package. We should never override this cache from a PR.
| @@ -0,0 +1,97 @@ | |||
|
|
|||
| [tool.commitizen] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved commitizen logic to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cz.toml require a [tool.commitizen] section? isn't that a pyproject.toml thing? I would expect options here to be flat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd make sense yeah. Based on the docs it is expected this way though.
|
Once it is merged, I'll run the |
scastlara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question
| @@ -0,0 +1,97 @@ | |||
|
|
|||
| [tool.commitizen] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cz.toml require a [tool.commitizen] section? isn't that a pyproject.toml thing? I would expect options here to be flat.
This PR includes all the necessary changes to migrate our project from poetry to uv.
It is a big PR, but the changes had to be made all at once, and it is based on the structure in https://github.com/elementsinteractive/lightman-ai.
The changes include:
uv. Also, added some caching mechanisms when runninglintjob and while building the Docker image.Closes #242
Closes #246