feat: allow to set ecosystem sources via the cli #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdn4z
force-pushed
the
cli-multiple-sources
branch
from
6591922 to
e29079c
Compare
Collaborator
Author
|
/lgtm review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🦉 lgtm Review
Score: Nitpicks 🤓
🔍 Summary
Overall, this is a solid PR. The new feature to allow setting ecosystem sources via the CLI is well-implemented, and the new options are clearly documented. The accompanying tests are thorough, covering various scenarios for the new CLI flags.
I also appreciate the bug fix for the recursive config loading.
I have one minor suggestion to improve code quality by reducing some duplication in the config handler. Other than that, the changes look good.
More information
- Id:
4e5c824737184faea97852f67b434420 - Model:
gemini-2.5-pro - Created at:
2025-09-18T14:18:33.608842+00:00
Usage summary
- Request count:
2 - Request tokens:
45,746 - Response tokens:
9,993 - Total tokens:
55,739
See the 📚 lgtm-ai repository for more information about lgtm.
sdn4z
force-pushed
the
cli-multiple-sources
branch
from
e29079c to
4e274c5
Compare
sdn4z
force-pushed
the
cli-multiple-sources
branch
from
4e274c5 to
f5e79bb
Compare
scastlara
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--npm-sourceand--pypi-sourcecli options.closes #344