PR for CallExecutor does not know the type of a result #72

Add a test for AsyncCallExecutor to test listeners
Use assertions for a test of CallExecutor

Author: dev3loperb

src/test/java/com/evanlennick/retry4j/AsyncCallExecutorTest_ListenersTest.java

@@ -0,0 +1,113 @@
+package com.evanlennick.retry4j;
+
+import com.evanlennick.retry4j.config.RetryConfig;
+import com.evanlennick.retry4j.config.RetryConfigBuilder;
+import org.assertj.core.api.Assertions;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import java.time.temporal.ChronoUnit;
+import java.util.concurrent.Callable;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.Executors;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.timeout;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class AsyncCallExecutorTest_ListenersTest {
+
+    @Mock
+    private DummyMock dummyMock;
+
+    private AsyncCallExecutor<String> executor;
+
+    private Callable<String> callable;
+
+    @BeforeMethod
+    public void setup() {
+        MockitoAnnotations.initMocks(this);
+
+        callable = () -> dummyMock.callableCallThis();
+
+        RetryConfig config = new RetryConfigBuilder()
+                .retryOnAnyException()
+                .withMaxNumberOfTries(5)
+                .withDelayBetweenTries(0, ChronoUnit.SECONDS)
+                .withFixedBackoff()
+                .build();
+
+        executor = new AsyncCallExecutor<>(config, Executors.newFixedThreadPool(5));
+    }
+
+    @Test
+    public void verifyAfterFailedListener() throws Exception {
+        when(dummyMock.callableCallThis())
+                .thenThrow(new RuntimeException())
+                .thenThrow(new IllegalStateException())
+                .thenReturn("success!");
+
+        executor.afterFailedTry(status -> dummyMock.listenersCallThis());
+        CompletableFuture<Status<String>> future = executor.execute(callable);
+
+        Status<String> status = future.get();
+        assertThat(future).isDone();
+        assertThat(status.getLastExceptionThatCausedRetry()).isInstanceOf(IllegalStateException.class);
+        assertThat(status.wasSuccessful()).isTrue();
+        assertThat(status.getTotalTries()).isEqualTo(3);
+        assertThat(status.getResult()).isEqualTo("success!");
+        verify(dummyMock, timeout(1000).times(2)).listenersCallThis();
+    }
+
+    @Test
+    public void verifyOnListener_resultHasTypeOfCallExecutor() throws Exception {
+        when(dummyMock.callableCallThis())
+                .thenThrow(new RuntimeException())
+                .thenThrow(new RuntimeException())
+                .thenThrow(new IllegalStateException())
+                .thenReturn("success!");
+
+        executor
+                .onSuccess(status -> {
+                    dummyMock.listenersCallThis();
+                    Assertions.assertThat(status.getResult()).isInstanceOf(String.class);
+                })
+                .onFailure(status -> dummyMock.listenersCallThis())
+                .onCompletion(status -> {
+                    dummyMock.listenersCallThis();
+                    Assertions.assertThat(status.getResult()).isInstanceOf(String.class);
+                })
+                .afterFailedTry(status -> dummyMock.listenersCallThis())
+                .beforeNextTry(status -> dummyMock.listenersCallThis());
+
+        CompletableFuture<Status<String>> future = executor.execute(callable);
+
+        Status<String> status = future.get();
+        assertThat(future).isDone();
+        assertThat(status.getLastExceptionThatCausedRetry()).isInstanceOf(IllegalStateException.class);
+        assertThat(status.wasSuccessful()).isTrue();
+        assertThat(status.getTotalTries()).isEqualTo(4);
+        assertThat(status.getResult()).isEqualTo("success!");
+
+        //only calls success once, completion once and the retry listeners 3 times each
+        verify(dummyMock, timeout(1000).times(8)).listenersCallThis();
+    }
+
+    private class DummyMock {
+
+        public String listenersCallThis() {
+            return "this is to use to verify listeners call the mock";
+        }
+
+        public String listenersCallThis(Exception e) {
+            return "this is to verify exceptions in the after failed call listener";
+        }
+
+        public String callableCallThis() {
+            return "this is to use for mocking the executed callable";
+        }
+    }
+}

src/test/java/com/evanlennick/retry4j/CallExecutorTest_ListenersTest.java

@@ -2,6 +2,7 @@
 
 import com.evanlennick.retry4j.config.RetryConfig;
 import com.evanlennick.retry4j.config.RetryConfigBuilder;
+import org.assertj.core.api.Assertions;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 import org.testng.annotations.BeforeMethod;
@@ -194,10 +195,29 @@ public void verifyOnFailureListener_populatesException() {
     }
 
     @Test
-    public void verifyOnSuccessListener_resultHasTypeOfCallExecutor() {
-        executor.onSuccess(status -> {
-                    String result = status.getResult(); //compile time check
-                }).execute(callable);
+    public void verifyOnListener_resultHasTypeOfCallExecutor() {
+        when(dummyMock.callableCallThis())
+                .thenThrow(new RuntimeException())
+                .thenThrow(new RuntimeException())
+                .thenThrow(new RuntimeException())
+                .thenReturn("success!");
+
+        executor
+                .onSuccess(status -> {
+                    dummyMock.listenersCallThis();
+                    Assertions.assertThat(status.getResult()).isInstanceOf(String.class);
+                })
+                .onFailure(status -> dummyMock.listenersCallThis())
+                .onCompletion(status -> {
+                    dummyMock.listenersCallThis();
+                    Assertions.assertThat(status.getResult()).isInstanceOf(String.class);
+                })
+                .afterFailedTry(status -> dummyMock.listenersCallThis())
+                .beforeNextTry(status -> dummyMock.listenersCallThis())
+                .execute(callable);
+
+        //only calls success once, completion once and the retry listeners 3 times each
+        verify(dummyMock, timeout(1000).times(8)).listenersCallThis();
     }
 
     private class DummyMock {