Add deferred cleanup option for autoscaling tests (infrawatch#314)

* Add deferred cleanup option for autoscaling tests

Introduces a new  variable (default: true)
that controls when autoscaling stack cleanup runs. When set to false,
cleanup is deferred to an always block in the playbook, ensuring resources
are properly torn down even if tests fail.

Changes:
- Add telemetry_autoscaling_cleanup variable to role defaults
- Make cleanup task conditional on telemetry_autoscaling_cleanup flag
- Move cleanup to always block in run_autoscaling_tests.yml playbook
- Document new variable in role README

Assisted-by: claude

* [ci] Delete instance created by make edpm_deploy_instance

Author: elfiesmelfie

ci/run_autoscaling_tests.yml

@@ -62,9 +62,22 @@
         - name: "Run Telemetry Autoscaling tests"
           ansible.builtin.import_role:
             name: telemetry_autoscaling
+          vars:
+            telemetry_autoscaling_cleanup: false
           ignore_errors: true
 
         - name: "Run Telemetry Verify Metrics tests"
           ansible.builtin.import_role:
             name: telemetry_verify_metrics
           ignore_errors: true
+
+      always:
+        - name: "Run Telemetry Autoscaling cleanup"
+          ansible.builtin.include_role:
+            name: telemetry_autoscaling
+            tasks_from: post_teardown
+
+        - name: Delete test_0 VM
+          ansible.builtin.shell:
+            cmd: |
+              {{ openstack_cmd }} server delete test_0

roles/telemetry_autoscaling/README.md

@@ -12,6 +12,13 @@ The following resources are required in the OpenStack cloud
 * a flavor called m1.small
 * an image called cirros
 
+Role Variables
+--------------
+* `telemetry_autoscaling_cleanup` (default: `true`) - Controls whether the autoscaling stack
+  cleanup task runs at the end of the role. Set to `false` to skip cleanup during the main role
+  execution, allowing cleanup to be deferred to a later task (e.g., in a block's `always`
+  section to ensure cleanup runs even on failure).
+
 Tests:
 ------
 * Verify overcloud deployment for autoscaling

roles/telemetry_autoscaling/defaults/main.yml

@@ -3,3 +3,4 @@
 openstack_cmd: "openstack"
 stack_name: vnf
 metrics_backend: gnocchi
+telemetry_autoscaling_cleanup: true

roles/telemetry_autoscaling/tasks/main.yml

@@ -30,6 +30,7 @@
   tags: test
 
 - name: Run the cleanup task
-  ansible.builtin.include_tasks: 
+  ansible.builtin.include_tasks:
     file: post_teardown.yml
+  when: telemetry_autoscaling_cleanup | bool
   tags: cleanup