Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit 25e579d

Browse files
committed
Remove geckodriver as is not being used yet
1 parent 8ef60d6 commit 25e579d

File tree

8 files changed

+56
-25
lines changed

8 files changed

+56
-25
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ matrix:
4848
services:
4949
- docker
5050
env:
51-
- DOCKER_VERSION="1.12.0"
51+
- DOCKER_VERSION="1.12.2-rc1"
5252
DOCKER_COMPOSE_VERSION="1.8.0"
5353
# Linux with docker:stable compose:beta/older
5454
- os: linux
@@ -66,7 +66,7 @@ matrix:
6666
services:
6767
- docker
6868
env:
69-
- DOCKER_VERSION="1.12.0"
69+
- DOCKER_VERSION="1.12.2-rc1"
7070
DOCKER_COMPOSE_VERSION="1.8.1"
7171
# Mac OSX: only test native docker version
7272
- os: osx

CHANGELOG.md

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,36 @@ Note image ids also change after scm-source.json has being updated which trigger
77
###### To get container versions
88
docker exec grid versions
99

10+
## TBD_DOCKER_TAG
11+
+ Date: TBD_DATE
12+
+ Remove geckodriver as is not being used yet
13+
+ Image tag details:
14+
+ Selenium: vTBD_SELENIUM_VERSION (TBD_SELENIUM_REVISION)
15+
+ Chrome stable: TBD_CHROME_STABLE
16+
+ Firefox stable: TBD_FIREFOX_STABLE
17+
+ Chromedriver: TBD_CHROME_DRIVER (TBD_CHROMEDRIVER_COMMIT)
18+
+ Java: TBD_JAVA_VENDOR Java TBD_JAVA_BUILD
19+
+ Timezone: TBD_TIME_ZONE
20+
+ FROM ubuntu:UBUNTU_FLAVOR-UBUNTU_DATE
21+
+ Python: TBD_PYTHON_VERSION
22+
+ Sauce Connect TBD_SAUCE_CONNECT_VERS, build TBD_SAUCE_CONNECT_BUILD TBD_SAUCE_CONNECT_REVISION
23+
+ BrowserStack Local version TBD_BROWSER_STACK_VERSION
24+
+ Tested on kernel dev host: 4.4.0-38-generic x86_64
25+
+ Tested on kernel CI host: TBD_HOST_UNAME
26+
+ Built at dev host with: Docker version 1.12.1, build 23cf638
27+
+ Built at CI host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD
28+
+ Built at dev host with: Docker Compose version 1.8.1, build 878cff1
29+
+ Built at CI host with: Docker Compose version TBD_DOCKER_COMPOSE_VERS, build TBD_DOCKER_COMPOSE_BUILD
30+
+ Image size: TBD_IMAGE_SIZE
31+
+ Digest: TBD_DIGEST
32+
+ Image ID: TBD_IMAGE_ID
33+
1034
## 2.53.1y
1135
+ Date: 2016-09-27
1236
+ Set chromedriver --log-path='/var/log/cont/chromedriver.log'
1337
+ Add geckodriver for Firefox >= 48 (future releases)
1438
+ Upgrade Ubuntu xenial to 20160923
15-
+ Perhaps fixed DBUS mistery with at entry.sh
39+
+ Perhaps fixed DBUS mistery. See `entry.sh`
1640
+ Client side: docker-compose from 1.8.0 to 1.8.1
1741
+ Image tag details:
1842
+ Selenium: v2.53.1 (a36b8b1)

CONTRIBUTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,18 @@ For pull requests or local commits:
66
time (./test/bef && ./test/install && ./test/script_start && ./test/script_end) ; beep
77
docker exec grid versions && ./test/after_script && travis lint
88
open ./images/grid_console.png && open ./videos/chrome/*.mkv
9-
git checkout -b tmp-2.53.1y && git checkout ./images/grid_console.png
9+
git checkout -b tmp-2.53.1z && git checkout ./images/grid_console.png
1010
#git add ... git commit ... git push ... open pull request
1111

1212
For repository owners only:
1313

14-
git commit -m "geckodriver, Ubuntu 20160923, chromedriver.log, DBUS magic"
15-
git tag -d latest && git tag 2.53.1y && git push origin tmp-2.53.1y && git push --tags
14+
git commit -m "Remove geckodriver as is not being used yet"
15+
git tag -d latest && git tag 2.53.1z && git push origin tmp-2.53.1z && git push --tags
1616

1717
-- Wait for Travis to pass OK
1818
-- Make sure changes got merged into master by elgalubot
1919

20-
git checkout master && git pull && git branch -d tmp-2.53.1y && git push origin --delete tmp-2.53.1y
20+
git checkout master && git pull && git branch -d tmp-2.53.1z && git push origin --delete tmp-2.53.1z
2121

2222
-- Re-add TBD_* section in CHANGELOG.md starting with TBD_DOCKER_TAG
2323
-- If Chrome version changed upload:
@@ -35,9 +35,9 @@ Keep certain bins if chrome version changed for example:
3535
## Retry
3636
Failed in Travis? retry
3737

38-
git tag -d 2.53.1y && git push origin :2.53.1y
38+
git tag -d 2.53.1z && git push origin :2.53.1z
3939
#git add ...
40-
git commit --amend && git tag 2.53.1y && git push --force origin tmp-2.53.1y && git push --tags
40+
git commit --amend && git tag 2.53.1z && git push --force origin tmp-2.53.1z && git push --tags
4141

4242
## Docker push from Travis CI
4343
Travis [steps](https://docs.travis-ci.com/user/docker/#Pushing-a-Docker-Image-to-a-Registry) involve `docker login` and docker credentials encryptions.

Dockerfile

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ RUN echo "Setting time zone to '${TZ}'" \
123123
# https://github.com/SeleniumHQ/docker-selenium/issues/14#issuecomment-67414070
124124
# RUN apt-get -qqy update \
125125
# && apt-get -qqy install \
126+
# software-properties-common \
127+
# && add-apt-repository ppa:openjdk-r/ppa \
128+
# && apt-get -qqy update \
129+
# && apt-get -qqy install \
126130
# openjdk-7-jre-headless \
127131
# && sed -i 's/securerandom.source=file:\/dev\/urandom/securerandom.source=file:\/dev\/.\/urandom/g' \
128132
# /usr/lib/jvm/java-7-openjdk-amd64/jre/lib/security/java.security \
@@ -725,19 +729,19 @@ RUN mkdir -p ${SEL_HOME} && cd ${SEL_HOME} \
725729
#============
726730
# GeckoDriver
727731
#============
728-
ENV GECKOD_VER="0.10.0" \
729-
GECKOD_URL="https://github.com/mozilla/geckodriver/releases/download"
730-
RUN wget --no-verbose -O /tmp/geckodriver.tar.gz \
731-
"${GECKOD_URL}/v${GECKOD_VER}/geckodriver-v${GECKOD_VER}-linux64.tar.gz" \
732-
&& rm -rf /opt/geckodriver* \
733-
&& tar -C /opt -xvzf /tmp/geckodriver.tar.gz \
734-
&& mv /opt/geckodriver /usr/bin/geckodriver \
735-
&& chmod +x /usr/bin/geckodriver \
736-
&& ln -fs /usr/bin/geckodriver /opt/geckodriver \
737-
&& ln -fs /usr/bin/geckodriver ${FF_DEST}/geckodriver \
738-
&& ln -fs /usr/bin/geckodriver /usr/bin/wires \
739-
&& ln -fs /usr/bin/geckodriver ${FF_DEST}/wires \
740-
&& rm /tmp/geckodriver.tar.gz
732+
# ENV GECKOD_VER="0.10.0" \
733+
# GECKOD_URL="https://github.com/mozilla/geckodriver/releases/download"
734+
# RUN wget --no-verbose -O /tmp/geckodriver.tar.gz \
735+
# "${GECKOD_URL}/v${GECKOD_VER}/geckodriver-v${GECKOD_VER}-linux64.tar.gz" \
736+
# && rm -rf /opt/geckodriver* \
737+
# && tar -C /opt -xvzf /tmp/geckodriver.tar.gz \
738+
# && mv /opt/geckodriver /usr/bin/geckodriver \
739+
# && chmod +x /usr/bin/geckodriver \
740+
# && ln -fs /usr/bin/geckodriver /opt/geckodriver \
741+
# && ln -fs /usr/bin/geckodriver /usr/bin/wires \
742+
# && ln -fs /usr/bin/geckodriver ${FF_DEST}/geckodriver \
743+
# && ln -fs /usr/bin/geckodriver ${FF_DEST}/wires \
744+
# && rm /tmp/geckodriver.tar.gz
741745

742746
# && rm -rf ${NORMAL_USER_HOME}/firefox-src
743747
# RUN mkdir -p ${NORMAL_USER_HOME}/firefox-src \

bin/entry.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ service dbus status
1717
export $(dbus-launch)
1818
export NSS_USE_SHARED_DB=ENABLED
1919
echo "-- INFO: DBUS_SESSION_BUS_ADDRESS=${DBUS_SESSION_BUS_ADDRESS}"
20+
#=> e.g. DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-APZO4BE4TJ,guid=6e9c098d053d3038cb0756ae57ecc885
2021
echo "-- INFO: DBUS_SESSION_BUS_PID=${DBUS_SESSION_BUS_PID}"
21-
22+
#=> e.g. DBUS_SESSION_BUS_PID=44
23+
#
2224
#-----------------------------------------------
2325
# Perform cleanup to support `docker restart`
2426
stop 2>&1 >/dev/null || true

test/before_install_docker_linux

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ set -xe
77
# cleanup
88
service docker stop || true
99
rm -f /etc/apt/sources.list.d/docker.list
10+
rm -f /usr/lib/systemd/system/docker.service
1011
apt-get -qqy purge lxc-docker || true
1112
apt-get -qqy purge docker-engine || true
1213
/etc/init.d/apparmor stop || true

test/script_push

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ docker_login_tag_push() {
3030
docker tag selenium:latest elgalu/selenium:latest
3131
docker push elgalu/selenium:${TRAVIS_TAG} | tee docker_push.log
3232
if [ "${DOCKER_PUSH_LATEST}" != "true" ]; then
33-
echo "DOCKER_PUSH_LATEST is false so don't update tag :latest"
33+
echo "DOCKER_PUSH_LATEST is false (probably a beta release) so don't update tag ':latest'"
3434
else
3535
docker push elgalu/selenium:latest
3636
fi

test/script_scenario_compose_1_1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export COMPOSE_FILE="docker-compose-host.yml" \
2929
echo "#===================================================================="
3030
echo "# Scenario 5b [compose_1_1]: Docker Compose 1 hub, 1 chrome, 1 firefox"
3131
echo "#===================================================================="
32-
export VNC_FROM_PORT="32900" VNC_TO_PORT="32950"
32+
export VNC_FROM_PORT="54900" VNC_TO_PORT="54950"
3333
export COMPOSE_FILE="docker-compose.yml" \
3434
DO_COMPOSE_UP="true"
3535
./test/compose-test.sh

0 commit comments

Comments
 (0)