This repository was archived by the owner on Jun 30, 2021. It is now read-only.
File tree Expand file tree Collapse file tree 3 files changed +5
-3
lines changed Expand file tree Collapse file tree 3 files changed +5
-3
lines changed Original file line number Diff line number Diff line change @@ -4,7 +4,7 @@ Simply put your changes in a new branch and open a pull request.
44## Local Testing
55To test your local changes:
66
7- ./test/run_tests_locally .sh
7+ ./test/run_locally .sh
88
99Optionally, manually check if the png and videos were generated:
1010
File renamed without changes.
Original file line number Diff line number Diff line change @@ -29,8 +29,9 @@ docker rm -vf grid_mock || true
2929
3030export MOCK_SERVER_PORT=8280
3131
32+ # Let's bind to all host interfaces in case the host has ufw enabled
3233docker run -d -t --name=grid_mock -e MOCK_SERVER_PORT \
33- -p $MOCK_SERVER_PORT :$MOCK_SERVER_PORT \
34+ -p 0.0.0.0: $MOCK_SERVER_PORT :$MOCK_SERVER_PORT \
3435 elgalu/google_adwords_mock
3536
3637docker attach grid_mock &
@@ -113,8 +114,9 @@ BASIC_WEB_SERVER_PORT=8710
113114docker stop basic_webserver || true
114115docker rm basic_webserver || true
115116
117+ # Let's bind to all host interfaces in case the host has ufw enabled
116118docker run -d -t --name=basic_webserver \
117- -p ${BASIC_WEB_SERVER_PORT} :80 \
119+ -p 0.0.0.0: ${BASIC_WEB_SERVER_PORT} :80 \
118120 nginx
119121
120122docker attach basic_webserver &
You can’t perform that action at this time.
0 commit comments