Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit 2e5c59b

Browse files
committed
Fix bind on tests for some host environments
1 parent be7be59 commit 2e5c59b

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Simply put your changes in a new branch and open a pull request.
44
## Local Testing
55
To test your local changes:
66

7-
./test/run_tests_locally.sh
7+
./test/run_locally.sh
88

99
Optionally, manually check if the png and videos were generated:
1010

File renamed without changes.

test/script_scenario_basic

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ docker rm -vf grid_mock || true
2929

3030
export MOCK_SERVER_PORT=8280
3131

32+
# Let's bind to all host interfaces in case the host has ufw enabled
3233
docker run -d -t --name=grid_mock -e MOCK_SERVER_PORT \
33-
-p $MOCK_SERVER_PORT:$MOCK_SERVER_PORT \
34+
-p 0.0.0.0:$MOCK_SERVER_PORT:$MOCK_SERVER_PORT \
3435
elgalu/google_adwords_mock
3536

3637
docker attach grid_mock &
@@ -113,8 +114,9 @@ BASIC_WEB_SERVER_PORT=8710
113114
docker stop basic_webserver || true
114115
docker rm basic_webserver || true
115116

117+
# Let's bind to all host interfaces in case the host has ufw enabled
116118
docker run -d -t --name=basic_webserver \
117-
-p ${BASIC_WEB_SERVER_PORT}:80 \
119+
-p 0.0.0.0:${BASIC_WEB_SERVER_PORT}:80 \
118120
nginx
119121

120122
docker attach basic_webserver &

0 commit comments

Comments
 (0)