Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit 3119908

Browse files
committed
Continue deprecating Selenium 2
1 parent 28ae014 commit 3119908

File tree

9 files changed

+14
-124
lines changed

9 files changed

+14
-124
lines changed

Dockerfile

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -942,23 +942,16 @@ COPY Analytics.md /home/seluser/
942942
#===================================
943943
# The .X11-unix stuff is useful when using Xephyr
944944
RUN mkdir -p /home/seluser/.vnc \
945-
&& sudo touch /capabilities2.json \
946-
&& sudo chown seluser:seluser /capabilities2.json \
947-
&& generate_capabilities2_json > /capabilities2.json \
948-
&& cp /capabilities2.json /home/seluser/capabilities2.json \
949-
&& cp /capabilities2.json /home/seluser/capabilities2 \
950-
&& cp /capabilities2.json /home/seluser/caps2.json \
951-
&& cp /capabilities2.json /home/seluser/caps2 \
952945
&& sudo touch /capabilities3.json \
953946
&& sudo chown seluser:seluser /capabilities3.json \
954947
&& generate_capabilities3_json > /capabilities3.json \
955948
&& cp /capabilities3.json /home/seluser/capabilities3.json \
956949
&& cp /capabilities3.json /home/seluser/capabilities3 \
957950
&& cp /capabilities3.json /home/seluser/caps3.json \
958951
&& cp /capabilities3.json /home/seluser/caps3 \
959-
&& sudo cp /capabilities2.json /capabilities.json \
960-
&& sudo cp /capabilities2.json /home/seluser/capabilities.json \
961-
&& sudo cp /capabilities2.json /home/seluser/caps.json \
952+
&& sudo cp /capabilities3.json /capabilities.json \
953+
&& sudo cp /capabilities3.json /home/seluser/capabilities.json \
954+
&& sudo cp /capabilities3.json /home/seluser/caps.json \
962955
&& mkdir -p ${VIDEOS_DIR} \
963956
&& sudo ln -s ${VIDEOS_DIR} /videos \
964957
&& sudo chown seluser:seluser /videos \

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717
* firefox stable [last 18 versions can be found here][2.47.1m]
1818
* fluxbox (openbox window manager can still be found [here](https://github.com/elgalu/docker-selenium/releases/tag/3.0.1c))
1919

20-
Selenium 3 `docker run ... -e USE_SELENIUM=3 elgalu/selenium:latest`
20+
Selenium 3 `docker run ... elgalu/selenium:latest`
2121
![docker-selenium-grid](./images/grid3_console.png)
2222

23-
Selenium 2 `docker run ... -e USE_SELENIUM=2 elgalu/selenium:2` *no longer maintained*
23+
Selenium 2 `docker run ... elgalu/selenium:2` *no longer maintained*
2424
![docker-selenium-grid](./images/grid2_console.png)
2525

2626
### Purpose

bin/entry.sh

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -27,26 +27,17 @@ stop >/dev/null 2>&1 || true
2727
rm -f ${LOGS_DIR}/*
2828
rm -f ${RUN_DIR}/*
2929

30-
# Selenium IDE RC (legacy) doesn't seem to keep working on Selenium 3
31-
if [ "${USE_SELENIUM}" == "3" ]; then
32-
export RC_CHROME="false"
33-
export RC_FIREFOX="false"
34-
# Support restart docker container for selenium 3 @aituganov
35-
if [ ! -f /usr/bin/geckodriver ]; then
36-
sudo mv /opt/geckodriver /usr/bin/geckodriver
37-
sudo ln -fs /usr/bin/geckodriver /opt/geckodriver
38-
fi
30+
export RC_CHROME="false"
31+
export RC_FIREFOX="false"
32+
# Support restart docker container for selenium 3 @aituganov
33+
if [ ! -f /usr/bin/geckodriver ]; then
34+
sudo mv /opt/geckodriver /usr/bin/geckodriver
35+
sudo ln -fs /usr/bin/geckodriver /opt/geckodriver
3936
fi
4037

41-
if [ "${USE_SELENIUM}" == "3" ]; then
42-
sudo cp /capabilities3.json /capabilities.json
43-
sudo cp /capabilities3.json /home/seluser/capabilities.json
44-
sudo cp /capabilities3.json /home/seluser/caps.json
45-
else
46-
sudo cp /capabilities2.json /capabilities.json
47-
sudo cp /capabilities2.json /home/seluser/capabilities.json
48-
sudo cp /capabilities2.json /home/seluser/caps.json
49-
fi
38+
sudo cp /capabilities3.json /capabilities.json
39+
sudo cp /capabilities3.json /home/seluser/capabilities.json
40+
sudo cp /capabilities3.json /home/seluser/caps.json
5041

5142
# We need larger screens for Selenium IDE RC tests
5243
# if [ "${RC_CHROME}" = "true" ] || [ "${RC_FIREFOX}" = "true" ]; then

bin/firefox-for-sel-2_version

Lines changed: 0 additions & 18 deletions
This file was deleted.

bin/selenium_2_revision_version

Lines changed: 0 additions & 19 deletions
This file was deleted.

bin/selenium_2_version

Lines changed: 0 additions & 19 deletions
This file was deleted.

bin/versions

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
#!/usr/bin/env bash
22

33
echo "selenium 3 version=$(selenium_version) revision=$(selenium_revision_version)"
4-
echo "selenium 2 version=$(selenium_2_version) revision=$(selenium_2_revision_version)"
54

65
echo "chrome_stable_version=$(chrome_stable_version)"
76
google-chrome-stable --version
87

98
echo "firefox_version=$(firefox_version)"
109
firefox --version
11-
echo "firefox-for-sel-2_version=$(firefox-for-sel-2_version)"
1210
echo "firefox-for-sel-3_version=$(firefox-for-sel-3_version)"
1311

1412
echo "chromedriver_version=$(chromedriver_version)"

test/script_push

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,8 @@ update_changelog() {
131131
|| die "while trying to get TBD_GECKO_DRIVER"
132132
TBD_CHROMEDRIVER_COMMIT=$(docker exec grid chromedriver_commit_version) \
133133
|| die "while trying to get TBD_CHROMEDRIVER_COMMIT"
134-
TBD_FIREFOX_FOR_SEL2=$(docker exec grid firefox-for-sel-2_version) \
135-
|| die "while trying to get TBD_FIREFOX_FOR_SEL2"
136134
TBD_FIREFOX_FOR_SEL3=$(docker exec grid firefox-for-sel-3_version) \
137135
|| die "while trying to get TBD_FIREFOX_FOR_SEL3"
138-
TBD_SELENIUM_2_VERSION=$(docker exec grid selenium_2_version) \
139-
|| die "while trying to get TBD_SELENIUM_2_VERSION"
140-
TBD_SELENIUM_2_REVISION=$(docker exec grid selenium_2_revision_version) \
141-
|| die "while trying to get TBD_SELENIUM_2_REVISION"
142136
TBD_SELENIUM_3_VERSION=$(docker exec grid selenium_version) \
143137
|| die "while trying to get TBD_SELENIUM_3_VERSION"
144138
TBD_SELENIUM_3_REVISION=$(docker exec grid selenium_revision_version) \
@@ -169,10 +163,7 @@ update_changelog() {
169163
sed -i -- "s/TBD_CHROME_DRIVER/${TBD_CHROME_DRIVER}/g" CHANGELOG.md || true
170164
sed -i -- "s/TBD_GECKO_DRIVER/${TBD_GECKO_DRIVER}/g" CHANGELOG.md || true
171165
sed -i -- "s/TBD_CHROMEDRIVER_COMMIT/${TBD_CHROMEDRIVER_COMMIT}/g" CHANGELOG.md || true
172-
sed -i -- "s/TBD_FIREFOX_FOR_SEL2/${TBD_FIREFOX_FOR_SEL2}/g" CHANGELOG.md || true
173166
sed -i -- "s/TBD_FIREFOX_FOR_SEL3/${TBD_FIREFOX_FOR_SEL3}/g" CHANGELOG.md || true
174-
sed -i -- "s/TBD_SELENIUM_2_VERSION/${TBD_SELENIUM_2_VERSION}/g" CHANGELOG.md || true
175-
sed -i -- "s/TBD_SELENIUM_2_REVISION/${TBD_SELENIUM_2_REVISION}/g" CHANGELOG.md || true
176167
sed -i -- "s/TBD_SELENIUM_3_VERSION/${TBD_SELENIUM_3_VERSION}/g" CHANGELOG.md || true
177168
sed -i -- "s/TBD_SELENIUM_3_REVISION/${TBD_SELENIUM_3_REVISION}/g" CHANGELOG.md || true
178169
sed -i -- "s/TBD_PYTHON_VERSION/${TBD_PYTHON_VERSION}/g" CHANGELOG.md || true

utils/bin/generate_capabilities2_json

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)