Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit 3cdf42d

Browse files
committed
Upgrade Ubuntu xenial date to 20160629
1 parent 3b255e2 commit 3cdf42d

File tree

8 files changed

+34
-16
lines changed

8 files changed

+34
-16
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Note image ids also change after scm-source.json has being updated which trigger
1212
+ Upgrade Selenium to 2.53.1
1313
+ Upgrade Firefox patch to 47.0.1
1414
+ Add docker-compose support
15+
+ Upgrade Ubuntu xenial date to 20160629
1516
+ Fix signaling issue by replacing `CMD "entry.sh"` with `CMD ["entry.sh"]`
1617
+ Image tag details:
1718
+ Selenium: vTBD_SELENIUM_VERSION (TBD_SELENIUM_REVISION)
@@ -24,7 +25,7 @@ Note image ids also change after scm-source.json has being updated which trigger
2425
+ Python: TBD_PYTHON_VERSION
2526
+ Sauce Connect TBD_SAUCE_CONNECT_VERS, build TBD_SAUCE_CONNECT_BUILD TBD_SAUCE_CONNECT_REVISION
2627
+ BrowserStack Local version TBD_BROWSER_STACK_VERSION
27-
+ Tested on kernel dev host: 4.4.0-28-generic x86_64
28+
+ Tested on kernel dev host: 4.4.0-29-generic x86_64
2829
+ Tested on kernel CI host: TBD_HOST_UNAME
2930
+ Built at dev host with: Docker version 1.11.2, build b9f10c9
3031
+ Built at CI host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ For pull requests or local commits:
1313

1414
For repository owners only:
1515

16-
git commit -m "Selenium 2.53.1 & Firefox 47.0.1 #102 & docker-compose #108"
16+
git commit -m "Selenium 2.53.1 & Firefox 47.0.1 #102 & docker-compose #108 & Upgrade ubuntu 20160629"
1717
git tag -d latest #tag latest will be updated from TravisCI
1818
git tag 2.53.1a && git push origin tmp-2.53.1a && git push --tags
1919

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
###################################################
44
#== Ubuntu xenial is 16.04, i.e. FROM ubuntu:16.04
55
# search for more at https://registry.hub.docker.com/_/ubuntu/tags/manage/
6-
FROM ubuntu:xenial-20160525
6+
FROM ubuntu:xenial-20160629
77
ENV UBUNTU_FLAVOR="xenial" \
8-
UBUNTU_DATE="20160525"
8+
UBUNTU_DATE="20160629"
99

1010
#== Ubuntu wily is 15.10, i.e. FROM ubuntu:15.10
1111
# FROM ubuntu:wily-20151208

TBD_DOCKER_TAG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
+ Python: TBD_PYTHON_VERSION
1313
+ Sauce Connect TBD_SAUCE_CONNECT_VERS, build TBD_SAUCE_CONNECT_BUILD TBD_SAUCE_CONNECT_REVISION
1414
+ BrowserStack Local version TBD_BROWSER_STACK_VERSION
15-
+ Tested on kernel dev host: 4.4.0-28-generic x86_64
15+
+ Tested on kernel dev host: 4.4.0-29-generic x86_64
1616
+ Tested on kernel CI host: TBD_HOST_UNAME
1717
+ Built at dev host with: Docker version 1.11.2, build b9f10c9
1818
+ Built at CI host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD

bin/entry.sh

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ function get_free_display() {
114114
# let find_display_num=${find_display_num}+1
115115
local pythonCmd="from random import shuffle;list1 = list(range($MAX_DISPLAY_SEARCH));shuffle(list1);print (' '.join(str(e) for e in list1))"
116116
local displayNums=$(python -c "${pythonCmd}")
117+
# Always find a free DISPLAY port starting with current DISP_N if it was provided
118+
[ "${DISP_N}" != "-1" ] && displayNums=" ${DISP_N} ${displayNums}"
117119
IFS=' ' read -r -a arrayDispNums <<< "$displayNums"
118120
for find_display_num in ${arrayDispNums[@]}; do
119121
# read -r Do not treat a backslash character in any special way.
@@ -170,8 +172,9 @@ if [ ! -z "${XE_DISP_NUM}" ]; then
170172
export DISP_N="${XE_DISP_NUM}"
171173
export DISPLAY=":${DISP_N}"
172174
start_xvfb
173-
elif [ "${PICK_ALL_RANDMON_PORTS}" = "true" ] || [ "${DISP_N}" = "-1" ]; then
174-
# Find a free DISPLAY port
175+
# elif [ "${PICK_ALL_RANDMON_PORTS}" = "true" ] || [ "${DISP_N}" = "-1" ]; then
176+
else
177+
# Find a free DISPLAY port starting with current DISP_N if any
175178
i=0
176179
while true ; do
177180
let i=${i}+1
@@ -191,10 +194,10 @@ elif [ "${PICK_ALL_RANDMON_PORTS}" = "true" ] || [ "${DISP_N}" = "-1" ]; then
191194
break
192195
fi
193196
done
194-
else
195-
export XEPHYR_DISPLAY=":${DISP_N}"
196-
export DISPLAY=":${DISP_N}"
197-
start_xvfb
197+
# else
198+
# export XEPHYR_DISPLAY=":${DISP_N}"
199+
# export DISPLAY=":${DISP_N}"
200+
# start_xvfb
198201
fi
199202

200203

test/compose-test.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,14 @@ for i in $(seq 1 ${NUM_NODES}); do
3737
docker exec selenium_firefox_${i} errors || true
3838
done
3939

40+
# FIXME: We still need to wait a bit because the nodes registration is not
41+
# being waited on wait_all_done script :(
42+
# mabe related to issue #83
43+
sleep 5
44+
4045
# Tests can run anywere, in the hub, in the host, doesn't matter
4146
for i in $(seq 1 ${PARAL_TESTS}); do
42-
docker exec -t selenium_chrome_${i} run_test &
47+
docker exec -t selenium_hub_1 run_test &
4348
done
4449

4550
# not so verbose from here

test/script_scenario_2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ echo "#=============================================================="
1818
echo "# Scenario 2b: Forced quick container restart + run tests again"
1919
echo "#=============================================================="
2020
docker restart --time=0 grid #forced quick restart
21-
sleep 3 #to avoid issue #83
22-
docker exec grid wait_all_done 40s
21+
sleep 7 #to avoid issue #83
22+
docker exec grid wait_all_done 80s
2323
docker exec grid errors || true
2424
docker exec -t grid run_test
2525
docker logs grid

test/script_scenario_4

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,15 @@ set -xe
77
echo "#======================================="
88
echo "# Scenario 4: Docker Compose many nodes"
99
echo "#======================================="
10-
export NUM_NODES=5 PARAL_TESTS=5 SELENIUM_HUB_PORT="4444" \
11-
WAIT_TIMEOUT="80s" WAIT_ALL_DONE="90s"
10+
export SELENIUM_HUB_PORT="4444"
11+
12+
if [ "${TRAVIS}" = "true" ]; then
13+
export NUM_NODES=2 PARAL_TESTS=2 \
14+
WAIT_TIMEOUT="280s" WAIT_ALL_DONE="390s"
15+
else
16+
# My local laptop has more power so hit it harder
17+
export NUM_NODES=7 PARAL_TESTS=7 \
18+
WAIT_TIMEOUT="80s" WAIT_ALL_DONE="90s"
19+
fi
20+
1221
./test/compose-test.sh

0 commit comments

Comments
 (0)