wily-20150829, -e NOVNC=true, supervisor 2015-08-24, pull race condition, grid-hub issues

Author: elgalu

CHANGELOG.md

@@ -19,6 +19,7 @@ How to get container versions
  + Upgrade supervisor 4.0.0.dev0 from 2015-06-24 commit to 2015-08-24.
  + Fix race condition after docker pull and run the image the first time.
  + Fix SSH_AUTH_KEYS detected issue
+ + Fix grid-hub registration issues
  + Image tag details:
   + Selenium: v2.47.1 (411b314)
   + Chrome stable:         45.0.2454.85

README.md

@@ -105,18 +105,18 @@ The important part above is `-e CHROME=false -e FIREFOX=false` which tells the d
 
 You can lunch a node only container via environment variables:
 
-    docker run --rm --name=node -p=5940:25900 -p=2224:22222 -p=6082:26080 \
-      -e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" -e VIDEO=true \
-      -e SELENIUM_HUB_HOST=10.161.128.170 \
-      -e SELENIUM_HUB_PORT=4444 \
-      -e SELENIUM_NODE_HOST=10.161.131.6 \
+    docker run --rm --name=node -p=5940:25900 \
       -p 25550:25550 -p 25551:25551 \
+      -e SELENIUM_HUB_HOST=docker.host \
+      -e SELENIUM_HUB_PORT=4444 \
+      -e SELENIUM_NODE_HOST=docker.host \
       -e GRID=false -e CHROME=true -e FIREFOX=true \
-      -v $(pwd)/videos:/videos \
       elgalu/selenium:2.47.1j
 
 The important part above is `-e GRID=false` which tells the container to be a node-only node, this this case with 2 browsers `-e CHROME=true -e FIREFOX=true` but could be just 1.
 
+Note `SELENIUM_HUB_HOST` and `SELENIUM_NODE_HOST` represent a network firewall config challenge when running on different machines and should be changed to the proper host names or IP addresses of those.
+
 ## Chrome crashed
 
 If your tests crashes in Chrome you may need to increase shm size or simply start your container by sharing `-v /dev/shm:/dev/shm`

READMELeo.md

@@ -1,15 +1,21 @@
 ## Build
 
     time (docker build -t="elgalu/selenium:2.47.1j" . ;echo $?;beep)
-    docker run --rm -ti -m 4000M --cpu-quota=0 --name=ch -p=4470:24444 -p=5920:25900 -p=2222:22222 -e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" -v $(pwd)/videos:/videos -e DISABLE_ROLLBACK=true -e VIDEO=true -e MEM_JAVA="1024m" elgalu/selenium:2.47.1j
+    docker run --rm -ti -m 4000M --cpu-quota=0 --name=grid -p=4470:24444 -p=5920:25900 -p=2222:22222 -e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" -v $(pwd)/videos:/videos -e DISABLE_ROLLBACK=true -e VIDEO=true -e MEM_JAVA="1024m" elgalu/selenium:2.47.1j
+
+Extra nodes
+
+    docker run --rm --name=grid -p 4444:24444 -p 5920:25900 -v /dev/shm:/dev/shm -e VNC_PASSWORD=hola elgalu/selenium:2.47.1j
+
+    docker run --rm --name=node -p=5940:25900 -e SELENIUM_HUB_HOST=docker.host -e SELENIUM_HUB_PORT=4444 -e SELENIUM_NODE_HOST=docker.host -p 25550:25550 -p 25551:25551 -e GRID=false -e CHROME=true -e FIREFOX=true elgalu/selenium:2.47.1j
 
 See logs
 
-    docker exec -ti ch bash -c "ls -lah /var/log/sele/"
+    docker exec -ti grid bash -c "ls -lah /var/log/sele/"
 
 Testing in ssh [email protected]
 
-    docker run --rm --name=ch -p=4470:24444 -p=5920:25900 -p=2222:22222 -e SSH_AUTH_KEYS="$(cat ~/.ssh/authorized_keys)" -e VNC_PASSWORD=Hola3 os-registry.stups.zalan.do/tip/selenium:2.47.1j
+    docker run --rm --name=grid -p=4470:24444 -p=5920:25900 -p=2222:22222 -e SSH_AUTH_KEYS="$(cat ~/.ssh/authorized_keys)" -e VNC_PASSWORD=Hola3 os-registry.stups.zalan.do/tip/selenium:2.47.1j
 
 ## Transfer used browser source artifacts to keep them in the cloud
 
@@ -19,11 +25,11 @@ Testing in ssh [email protected]
 
 List chrome versions via docker exec
 
-    docker exec -ti ch bash -c "ls -lah /home/application/chrome-deb/"
+    docker exec -ti grid bash -c "ls -lah /home/application/chrome-deb/"
 
 List firefox versions via docker exe
 
-    docker exec -ti ch bash -c "ls -lah /home/application/firefox-src/ && ls -lah /home/application/selenium/firefox**/firefox/firefox"
+    docker exec -ti grid bash -c "ls -lah /home/application/firefox-src/ && ls -lah /home/application/selenium/firefox**/firefox/firefox"
 
 ## Transfer the other way around
 
@@ -37,17 +43,17 @@ List firefox versions via docker exe
 
 ## Run with shared dir
 
-    docker run --rm --name=ch -p=127.0.0.1:4460:24444 -p=127.0.0.1:5910:25900 \
+    docker run --rm --name=grid -p=127.0.0.1:4460:24444 -p=127.0.0.1:5910:25900 \
       -v /e2e/uploads:/e2e/uploads elgalu/selenium:2.47.1j
-    docker run --rm --name=ch -p=4460:24444 -p=5910:25900 \
+    docker run --rm --name=grid -p=4460:24444 -p=5910:25900 \
       -v /var/run/docker.sock:/var/run/docker.sock -v $(which docker):$(which docker) elgalu/selenium:2.47.1j
 
 
     docker run --rm --name=ff -p=127.0.0.1:4461:24444 -p=127.0.0.1:5911:25900 -v /e2e/uploads:/e2e/uploads elgalu/selenium:2.47.1j
 
 ## Run without shared dir and bind ports to all network interfaces
 
-    docker run -d --name=ch -p=0.0.0.0:4444:24444 -p=0.0.0.0:5900:25900 elgalu/selenium:0.1
+    docker run -d --name=grid -p=0.0.0.0:4444:24444 -p=0.0.0.0:5900:25900 elgalu/selenium:0.1
 
 ## Opening tunnels
 
@@ -66,11 +72,11 @@ List firefox versions via docker exe
 ## Run without dir and bind to all interfaces
 Note anything after the image will be taken as arguments for the cmd/entrypoint
 
-    docker run --rm --name=ch -p=0.0.0.0:8813:8484 -p=0.0.0.0:2222:2222 -p=0.0.0.0:4470:24444 -p=0.0.0.0:5920:25900 -e SCREEN_WIDTH=1800 -e SCREEN_HEIGHT=1110 -e VNC_PASSWORD=hola -e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" elgalu/selenium:2.47.1j
+    docker run --rm --name=grid -p=0.0.0.0:8813:8484 -p=0.0.0.0:2222:2222 -p=0.0.0.0:4470:24444 -p=0.0.0.0:5920:25900 -e SCREEN_WIDTH=1800 -e SCREEN_HEIGHT=1110 -e VNC_PASSWORD=hola -e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" elgalu/selenium:2.47.1j
 
-    docker run --rm --name=ch -p=4470:24444 -p=5920:25900 -e VNC_PASSWORD=hola elgalu/selenium:2.47.1j
-    docker run --rm --name=ch -p=4470:24444 -p=5920:25900 -e VNC_PASSWORD=hola docker.io/elgalu/selenium:2.47.1j
-    docker run --rm --name=ch -p=0.0.0.0:4470:24444 -p=0.0.0.0:5920:25900 --add-host myserver.dev:172.17.42.1 elgalu/selenium:2.47.1j
+    docker run --rm --name=grid -p=4470:24444 -p=5920:25900 -e VNC_PASSWORD=hola elgalu/selenium:2.47.1j
+    docker run --rm --name=grid -p=4470:24444 -p=5920:25900 -e VNC_PASSWORD=hola docker.io/elgalu/selenium:2.47.1j
+    docker run --rm --name=grid -p=0.0.0.0:4470:24444 -p=0.0.0.0:5920:25900 --add-host myserver.dev:172.17.42.1 elgalu/selenium:2.47.1j
 
 However adding a custom host IP to server-selenium.local (e.g. bsele ssh config) is more work:
 

scm-source.json

@@ -1,6 +1,6 @@
 {
     "url": "https://github.com/elgalu/docker-selenium",
-    "revision": "c9161b539f482b234b6651e5ca016d083ce1285c",
+    "revision": "4951102f2f29de3b4d0b165e3d60315c5a8f77c2",
     "author": "lgallucci",
     "status": ""
 }

selenium-hub/bin/wait-selenium-hub.sh

@@ -5,16 +5,17 @@ SEL_STATUS_URL="http://localhost:${SELENIUM_HUB_PORT}/wd/hub/status"
 # Exit immediately if a command exits with a non-zero status
 set -e
 
-if [ "${GRID}" = "true" ]; then
-  echo "Waiting for Selenium Hub to be ready..."
-  # This is annoying but json endpoint /wd/hub/status returns different things
-  #  - on grid/hub .status should be 13
-  #  - on node .state should be "success"
-  while ! curl -s "${SEL_STATUS_URL}" | jq '.status' | grep "13"; do
-    echo -n '.'
-    sleep 0.1
-  done
-  echo "Done wait-selenium-hub.sh"
-else
-  echo "Won't start selenium node chrome due to GRID env var false"
+if [ "${GRID}" != "true" ]; then
+  echo "Won't start selenium grid due to GRID env var false"
+  exit 0
 fi
+
+echo "Waiting for Selenium Hub to be ready..."
+# This is annoying but json endpoint /wd/hub/status returns different things
+#  - on grid/hub .status should be 13
+#  - on node .state should be "success"
+while ! curl -s "${SEL_STATUS_URL}" | jq '.status' | grep "13"; do
+  echo -n '.'
+  sleep 0.1
+done
+echo "Done wait-selenium-hub.sh"

selenium-node-chrome/bin/wait-selenium-node-chrome.sh

@@ -5,16 +5,17 @@ SEL_STATUS_URL="http://localhost:${SELENIUM_NODE_CH_PORT}/wd/hub/status"
 # Exit immediately if a command exits with a non-zero status
 set -e
 
-if [ "${CHROME}" = "true" ]; then
-  echo "Waiting for Selenium Node Chrome ${CHROME_FLAVOR} to be ready..."
-  # This is annoying but json endpoint /wd/hub/status returns different things
-  #  - on grid/hub .status should be 13
-  #  - on node .state should be "success"
-  while ! curl -s "${SEL_STATUS_URL}" | jq '.state' | grep "success"; do
-    echo -n '.'
-    sleep 0.1
-  done
-  echo "Done wait-selenium-node-chrome-${CHROME_FLAVOR}.sh"
-else
+if [ "${CHROME}" != "true" ]; then
   echo "Won't start selenium node chrome due to CHROME env var false"
+  exit 0
 fi
+
+echo "Waiting for Selenium Node Chrome ${CHROME_FLAVOR} to be ready..."
+# This is annoying but json endpoint /wd/hub/status returns different things
+#  - on grid/hub .status should be 13
+#  - on node .state should be "success"
+while ! curl -s "${SEL_STATUS_URL}" | jq '.state' | grep "success"; do
+  echo -n '.'
+  sleep 0.1
+done
+echo "Done wait-selenium-node-chrome-${CHROME_FLAVOR}.sh"

selenium-node-firefox/bin/wait-selenium-node-firefox.sh

@@ -3,17 +3,18 @@
 # Exit immediately if a command exits with a non-zero status
 set -e
 
-if [ "${FIREFOX}" = "true" ]; then
-  echo "Waiting for Selenium Node Firefox ${FIREFOX_VERSION} to be ready..."
-  # This is annoying but json endpoint /wd/hub/status returns different things
-  #  - on grid/hub .status should be 13
-  #  - on node .state should be "success"
-  while ! curl -s "http://localhost:${SELENIUM_NODE_FF_PORT}/wd/hub/status" \
-           | jq '.state' | grep "success"; do
-    echo -n '.'
-    sleep 0.1
-  done
-  echo "Done wait-selenium-node-firefox-${FIREFOX_VERSION}"
-else
+if [ "${FIREFOX}" != "true" ]; then
   echo "Won't start selenium node firefox due to FIREFOX env var false"
+  exit 0
 fi
+
+echo "Waiting for Selenium Node Firefox ${FIREFOX_VERSION} to be ready..."
+# This is annoying but json endpoint /wd/hub/status returns different things
+#  - on grid/hub .status should be 13
+#  - on node .state should be "success"
+while ! curl -s "http://localhost:${SELENIUM_NODE_FF_PORT}/wd/hub/status" \
+         | jq '.state' | grep "success"; do
+  echo -n '.'
+  sleep 0.1
+done
+echo "Done wait-selenium-node-firefox-${FIREFOX_VERSION}"