Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit 645d5b4

Browse files
authored
Fixing video recording so it works in all browsers. Fixes #263 (#282)
1 parent df9feec commit 645d5b4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -932,7 +932,7 @@ ENV FIREFOX_VERSION="${FF_VER}" \
932932
FIREFOX="true" \
933933
MULTINODE="false" \
934934
FFMPEG_FRAME_RATE=10 \
935-
FFMPEG_CODEC_ARGS="-crf 0 -preset ultrafast -qp 0 -pix_fmt yuv420p" \
935+
FFMPEG_CODEC_ARGS="-vcodec libx264 -preset ultrafast -pix_fmt yuv420p" \
936936
FFMPEG_FINAL_CRF=0 \
937937
FFMPEG_DRAW_MOUSE=1 \
938938
VIDEO_TMP_FILE_EXTENSION="mkv" \

video-rec/bin/start-video-rec.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,13 @@ fi
4848

4949
# avconv or ffmpeg
5050
ffmpeg -f x11grab \
51-
-framerate ${FFMPEG_FRAME_RATE} \
52-
-video_size ${FFMPEG_FRAME_SIZE} \
53-
-i "${DISPLAY}.0+0,0" \
51+
-s ${FFMPEG_FRAME_SIZE} \
52+
-i "${DISPLAY}.0" \
5453
-draw_mouse ${FFMPEG_DRAW_MOUSE} \
5554
${FFMPEG_CODEC_ARGS} \
56-
-segment_format_options movflags=+faststart \
55+
-r ${FFMPEG_FRAME_RATE} \
5756
-y -an "${tmp_video_path}" 2>&1 &
57+
5858
VID_TOOL_PID=$!
5959

6060
# Exit all child processes properly

0 commit comments

Comments
 (0)