Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit 70f3f33

Browse files
authored
Using patched Selenium jar for issue #296 (#319)
* Using self built jar. * Ignoring IntelliJ directory * Updating Chrome version
1 parent 78b8e09 commit 70f3f33

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,4 @@ NEXT_RELEASE.md
3030
temp.md
3131
git_shortlog.stdout
3232
.bitballoon
33+
.idea

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ COPY bin/fail /usr/bin/
639639
#===============
640640
# TODO: Use Google fingerprint to verify downloads
641641
# https://www.google.de/linuxrepositories/
642-
ARG EXPECTED_CHROME_VERSION="74.0.3729.108"
642+
ARG EXPECTED_CHROME_VERSION="74.0.3729.131"
643643
ENV CHROME_URL="https://dl.google.com/linux/direct" \
644644
CHROME_BASE_DEB_PATH="/home/seluser/chrome-deb/google-chrome" \
645645
GREP_ONLY_NUMS_VER="[0-9.]{2,20}"

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ifeq ($(UNAME_S),Linux)
2323
export VNC_CLIENT := vncviewer
2424
endif
2525
ifeq ($(UNAME_S),Darwin)
26-
export VNC_CLIENT := /Applications/RealVNC/VNC Viewer.app/Contents/MacOS/vncviewer
26+
export VNC_CLIENT := /Applications/VNC Viewer.app/Contents/MacOS/vncviewer
2727
endif
2828

2929
default: compose

test/python_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,12 @@
8787

8888
if args.browser == 'firefox':
8989
caps["moz:firefoxOptions"] = {
90-
"log": {
91-
"level": "trace",
92-
},
93-
}
90+
"log": {
91+
"level": "trace",
92+
},
93+
}
9494

95-
# http://selenium-python.readthedocs.org/en/latest/getting-started.html#using-selenium-with-remote-webdriver
95+
# https://selenium-python.readthedocs.io/getting-started.html#using-selenium-with-remote-webdriver
9696
print ("%s %s - (01/15) Will connect to selenium at %s" % (datetime.datetime.utcnow(), longId, myselenium_hub_url))
9797
driver = webdriver.Remote(command_executor=myselenium_hub_url, desired_capabilities=caps)
9898
time.sleep(msleep)

0 commit comments

Comments
 (0)