Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit 8e9149b

Browse files
committed
Upgrade Firefox 46.0.1 & Ubuntu 20160503
1 parent 05a8234 commit 8e9149b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+198
-85
lines changed

.dockerignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ videos/
88
android/
99
binaries
1010
*.md
11+
bats/

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ binaries
1010
scm-source.json
1111
TODO.md
1212
docker_push.log
13+
bats/

CHANGELOG.md

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,29 @@ Note image ids also change after scm-source.json has being updated which trigger
77
###### To get container versions
88
docker exec grid versions
99

10+
## TBD_DOCKER_TAG
11+
+ Date: TBD_DATE
12+
+ Upgrade Firefox patch to TBD_FIREFOX_STABLE
13+
+ Upgrade Ubuntu xenial date to UBUNTU_DATE
14+
+ Image tag details:
15+
+ Selenium: vTBD_SELENIUM_VERSION (TBD_SELENIUM_REVISION)
16+
+ Chrome stable: TBD_CHROME_STABLE
17+
+ Firefox stable: TBD_FIREFOX_STABLE
18+
+ Chromedriver: TBD_CHROME_DRIVER (TBD_CHROMEDRIVER_COMMIT)
19+
+ Java: TBD_JAVA_VENDOR Java TBD_JAVA_BUILD
20+
+ Timezone: TBD_TIME_ZONE
21+
+ FROM ubuntu:UBUNTU_FLAVOR-UBUNTU_DATE
22+
+ Python: TBD_PYTHON_VERSION
23+
+ Sauce Connect TBD_SAUCE_CONNECT_VERS, build TBD_SAUCE_CONNECT_BUILD TBD_SAUCE_CONNECT_REVISION
24+
+ BrowserStack Local version TBD_BROWSER_STACK_VERSION
25+
+ Tested on kernel dev host: 4.4.0-22-generic x86_64
26+
+ Tested on kernel CI host: TBD_HOST_UNAME
27+
+ Built at dev host with: Docker version 1.11.1, build 5604cbe
28+
+ Built at CI host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD
29+
+ Image size: TBD_IMAGE_SIZE
30+
+ Digest: TBD_DIGEST
31+
+ Image ID: TBD_IMAGE_ID
32+
1033
## 2.53.0k
1134
+ Date: 2016-04-29
1235
+ Upgrade Chrome patch to 50.0.2661.94
@@ -23,7 +46,7 @@ Note image ids also change after scm-source.json has being updated which trigger
2346
+ BrowserStack Local version 5.4
2447
+ Tested on kernel dev host: 4.4.0-22-generic x86_64
2548
+ Tested on kernel CI host: 3.19.0-30-generic x86_64
26-
+ Built at dev host with: Docker version 1.11.0, build 4dc5990
49+
+ Built at dev host with: Docker version 1.11.1, build 5604cbe
2750
+ Built at CI host with: Docker version 1.11.1, build 5604cbe
2851
+ Image size: 2.814 GB
2952
+ Digest: sha256:de1cf160aff739f189001aa603a5ea3feba0f6672e3ef1fe73222fdae1673789

CONTRIBUTING.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,24 @@
44
For pull requests:
55

66
./test/before_install_build && ./test/install
7-
#or: ./test/script
8-
./test/script_scenario_1 && ./test/script_scenario_2
9-
./test/script_archive && ./test/script_push
7+
./test/script
108
./test/after_script #or: docker exec grid versions
119
open ./images/grid_console.png #to verify the versions are correct
1210
git checkout ./images/grid_console.png && open ./videos/chrome/test.mkv
1311
travis lint #if you changed .travis.yml
14-
git checkout -b tmp-2.53.0k #name your branch according to your changes
12+
git checkout -b tmp-2.53.0l #name your branch according to your changes
1513
#git add ... git commit ... git push ... open pull request
1614

1715
For repository owners only:
1816

19-
git commit -m "Upgrade Chrome patch to 50.0.2661.94"
17+
git commit -m "Upgrade Firefox 46.0.1 & Ubuntu 20160503"
2018
git tag -d latest #tag latest will be updated from TravisCI
21-
git tag 2.53.0k && git push origin tmp-2.53.0k && git push --tags
19+
git tag 2.53.0l && git push origin tmp-2.53.0l && git push --tags
2220

2321
-- Wait for Travis to pass OK
2422
-- Make sure changes got merged into master by elgalubot
2523

26-
git checkout master && git pull && git branch -d tmp-2.53.0k && git push origin --delete tmp-2.53.0k
24+
git checkout master && git pull && git branch -d tmp-2.53.0l && git push origin --delete tmp-2.53.0l
2725

2826
-- Re-add TBD_* section in CHANGELOG.md starting with TBD_DOCKER_TAG
2927
-- Upgrade release tag in github.com with latest CHANGELOG.md
@@ -40,9 +38,9 @@ Keep certain bins if chrome version changed for example:
4038
## Retry
4139
Failed in Travis? retry
4240

43-
git tag -d 2.53.0k && git push origin :2.53.0k
41+
git tag -d 2.53.0l && git push origin :2.53.0l
4442
#git add ...
45-
git commit --amend && git tag 2.53.0k && git push --force origin tmp-2.53.0k && git push --tags
43+
git commit --amend && git tag 2.53.0l && git push --force origin tmp-2.53.0l && git push --tags
4644

4745
## Docker push from Travis CI
4846
Travis [steps](https://docs.travis-ci.com/user/docker/#Pushing-a-Docker-Image-to-a-Registry) involve `docker login` and docker credentials encryptions.

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
###################################################
44
#== Ubuntu xenial is 16.04, i.e. FROM ubuntu:16.04
55
# search for more at https://registry.hub.docker.com/_/ubuntu/tags/manage/
6-
FROM ubuntu:xenial-20160422
6+
FROM ubuntu:xenial-20160503
77
ENV UBUNTU_FLAVOR="xenial" \
8-
UBUNTU_DATE="20160422"
8+
UBUNTU_DATE="20160503"
99

1010
#== Ubuntu wily is 15.10, i.e. FROM ubuntu:15.10
1111
# FROM ubuntu:wily-20151208
@@ -678,7 +678,7 @@ RUN cd /tmp \
678678
# FF_LANG can be either en-US // de // fr and so on
679679
# Regarding the pip packages, see released versions at:
680680
# https://github.com/mozilla/mozdownload/releases
681-
ENV FF_VER="46.0" \
681+
ENV FF_VER="46.0.1" \
682682
FF_LANG="en-US" \
683683
FF_PLATFORM="linux-x86_64" \
684684
FF_BASE_URL="https://archive.mozilla.org/pub" \

README.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ The purpose of this project is to have [Selenium][] running as simple and as fas
2828

2929
1. Pull the image and run the container
3030

31-
docker pull elgalu/selenium:2.53.0k
31+
docker pull elgalu/selenium:2.53.0l
3232

3333
docker run --rm -ti --name=grid -p 4444:24444 -p 5900:25900 \
34-
-v /dev/shm:/dev/shm -e VNC_PASSWORD=hola elgalu/selenium:2.53.0k
34+
-v /dev/shm:/dev/shm -e VNC_PASSWORD=hola elgalu/selenium:2.53.0l
3535

3636
2. Wait until the grid starts properly before starting the tests _(Optional but recommended)_
3737

@@ -66,7 +66,7 @@ You can also ssh into the machine as long as `SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa
6666
docker run --rm -ti --name=grid -p=4444:24444 -p=5900:25900 -p=22222:22222 \
6767
-e SSHD=true \
6868
-e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" \
69-
-v /dev/shm:/dev/shm elgalu/selenium:2.53.0k
69+
-v /dev/shm:/dev/shm elgalu/selenium:2.53.0l
7070

7171
Then
7272

@@ -77,7 +77,7 @@ Include `-X` in ssh command if you want to redirect the started GUI programs to
7777
docker run --rm -ti --name=grid -p=4444:24444 -p=5900:25900 -p=22222:22222 \
7878
-e SSHD=true -e SSHD_X11FORWARDING=yes \
7979
-e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" \
80-
-v /dev/shm:/dev/shm elgalu/selenium:2.53.0k
80+
-v /dev/shm:/dev/shm elgalu/selenium:2.53.0l
8181

8282
Then
8383

@@ -95,12 +95,12 @@ Supervisor exposes an http server but is not enough to bind the ports via `docke
9595
### Screen size
9696
You can set a custom screen size at docker run time by providing `SCREEN_WIDTH` and `SCREEN_HEIGHT` environment variables:
9797

98-
docker pull elgalu/selenium:2.53.0k
98+
docker pull elgalu/selenium:2.53.0l
9999

100100
docker run -d --name=grid -p 4444:24444 -p 5900:25900 \
101101
-v /dev/shm:/dev/shm -e VNC_PASSWORD=hola \
102102
-e SCREEN_WIDTH=1920 -e SCREEN_HEIGHT=1480 \
103-
elgalu/selenium:2.53.0k
103+
elgalu/selenium:2.53.0l
104104

105105
docker exec grid wait_all_done 10s
106106

@@ -158,7 +158,7 @@ You need to pass the environment variable `-e NOVNC=true` in order to start the
158158

159159
docker run --rm -ti --name=grid -p 4444:24444 -p 5900:25900 \
160160
-v /dev/shm:/dev/shm -p 6080:26080 -e NOVNC=true \
161-
elgalu/selenium:2.53.0k
161+
elgalu/selenium:2.53.0l
162162

163163
If the VNC password was randomly generated find out with
164164

@@ -231,9 +231,9 @@ There are also additional steps you can take to ensure you're using the correct
231231

232232
You can simply verify that image id is indeed the correct one.
233233

234-
# e.g. full image id for tag 2.53.0k
234+
# e.g. full image id for tag 2.53.0l
235235
export IMGID="<<Please see CHANGELOG.md>>"
236-
if docker inspect -f='{{.Id}}' elgalu/selenium:2.53.0k |grep ${IMGID} &> /dev/null; then
236+
if docker inspect -f='{{.Id}}' elgalu/selenium:2.53.0l |grep ${IMGID} &> /dev/null; then
237237
echo "Image ID tested ok"
238238
else
239239
echo "Image ID doesn't match"
@@ -243,7 +243,7 @@ You can simply verify that image id is indeed the correct one.
243243

244244
Given docker.io currently allows to push the same tag image twice this represent a security concern but since docker >= 1.6.2 is possible to fetch the digest sha256 instead of the tag so you can be sure you're using the exact same docker image every time:
245245

246-
# e.g. sha256 for tag 2.53.0k
246+
# e.g. sha256 for tag 2.53.0l
247247
export SHA=<<Please see CHANGELOG.md>>
248248
docker pull elgalu/selenium@sha256:${SHA}
249249

@@ -275,7 +275,7 @@ Host machine, terminal 2:
275275
-v /dev/shm:/dev/shm \
276276
-e SCREEN_WIDTH -e SCREEN_HEIGHT -e XE_DISP_NUM \
277277
-v /tmp/.X11-unix/X${XE_DISP_NUM}:/tmp/.X11-unix/X${XE_DISP_NUM} \
278-
elgalu/selenium:2.53.0k
278+
elgalu/selenium:2.53.0l
279279

280280
Now when you run your tests instead of connecting. If docker run fails try `xhost +`
281281

@@ -297,7 +297,7 @@ ANYPORT=0
297297
REMOTE_DOCKER_SRV=localhost
298298
CONTAINER=$(docker run -d -p=0.0.0.0:${ANYPORT}:22222 -p=0.0.0.0:${ANYPORT}:24444 \
299299
-p=0.0.0.0:${ANYPORT}:25900 -e SCREEN_HEIGHT=1110 -e VNC_PASSWORD=hola \
300-
-e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" elgalu/selenium:2.53.0k
300+
-e SSH_AUTH_KEYS="$(cat ~/.ssh/id_rsa.pub)" elgalu/selenium:2.53.0l
301301
302302
# -- Option 2.docker run- Running docker on remote docker server like in the cloud
303303
# Useful if the docker server is running in the cloud. Establish free local ports
@@ -307,7 +307,7 @@ ssh ${REMOTE_DOCKER_SRV} #get into the remote docker provider somehow
307307
# it acts as a jump host so my public key is already on that server
308308
CONTAINER=$(docker run -d -p=0.0.0.0:${ANYPORT}:22222 -e SCREEN_HEIGHT=1110 \
309309
-e VNC_PASSWORD=hola -e SSH_AUTH_KEYS="$(cat ~/.ssh/authorized_keys)" \
310-
elgalu/selenium:2.53.0k
310+
elgalu/selenium:2.53.0l
311311
312312
# -- Common: Wait for the container to start
313313
./host-scripts/wait-docker-selenium.sh grid 7s
@@ -378,7 +378,7 @@ If you git clone this repo locally, i.e. cd into where the Dockerfile is, you ca
378378
379379
If you prefer to download the final built image from docker you can pull it, personally I always prefer to build them manually except for the base images like Ubuntu 14.04.2:
380380
381-
docker pull elgalu/selenium:2.53.0k
381+
docker pull elgalu/selenium:2.53.0l
382382
383383
### 2. Use this image
384384

bin/entry.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
#!/usr/bin/env bash
22

3-
# Exit immediately if a command exits with a non-zero status
4-
# set -e
5-
63
#-----------------------------------------------
74
# Perform cleanup to support `docker restart`
85
stop 2>&1 >/dev/null || true

bin/functions.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
#!/usr/bin/env bash
2+
3+
# https://github.com/SeleniumHQ/docker-selenium/issues/184
4+
function get_server_num() {
5+
echo $(echo $DISPLAY | sed -r -e 's/([^:]+)?:([0-9]+)(\.[0-9]+)?/\2/')
6+
}

browserstack/bin/start-browserstack.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22

3-
# Exit immediately if a command exits with a non-zero status
3+
# set -e: exit asap if a command exits with a non-zero status
44
set -e
55

66
# echo fn that outputs to stderr http://stackoverflow.com/a/2990533/511069

browserstack/bin/wait-browserstack.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22

3-
# Exit immediately if a command exits with a non-zero status
3+
# set -e: exit asap if a command exits with a non-zero status
44
set -e
55

66
# echo fn that outputs to stderr http://stackoverflow.com/a/2990533/511069

0 commit comments

Comments
 (0)