Upgrade Chrome major to 62.0.3202.62

Author: elgalu

.travis.yml

@@ -34,6 +34,7 @@ jobs:
     - stage: Docker build (re-use in stages)
       env: step=build_push
       script:
+        - travis_retry ./test/before_install_setup
         - travis_retry ./test/before_install_build
 
     - stage: Integration and Unit Tests

CHANGELOG.md

@@ -7,6 +7,31 @@ Note image ids also change after scm-source.json has being updated which trigger
 ###### To get container versions
     docker exec grid versions
 
+## TBD_DOCKER_TAG
+ + **Changes:** https://github.com/elgalu/docker-selenium/compare/3.6.0-p3...3.6.0-p4 (TBD_DATE)
+    + Upgrade Chrome major to 62.0.3202.62
+    + Upgrade ubuntu:xenial-20171006
+    + Start using the Dockerfile ARG instruction
+ + **Image tag details:**
+    + Selenium version: TBD_SELENIUM_VERSION (TBD_SELENIUM_REVISION)
+    + Chrome stable:  TBD_CHROME_STABLE
+    + Firefox stable: TBD_FIREFOX_VERSION
+    + Geckodriver: TBD_GECKO_DRIVER
+    + Chromedriver: TBD_CHROME_DRIVER (TBD_CHROMEDRIVER_COMMIT)
+    + Java: TBD_JAVA_VENDOR Java TBD_JAVA_BUILD
+    + Timezone: TBD_TIME_ZONE
+    + FROM ubuntu:UBUNTU_FLAVOR-UBUNTU_DATE
+    + Python: TBD_PYTHON_VERSION
+    + Tested on kernel dev host: 4.4.0-96-generic x86_64
+    + Tested on kernel CI  host: TBD_HOST_UNAME
+    + Built at dev host with: Docker version 17.10.0-ce, build f4ffd25
+    + Built at CI  host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD
+    + Built at dev host with: Docker Compose version 1.17.0-rc1, build a0f95af
+    + Built at CI  host with: Docker Compose version TBD_DOCKER_COMPOSE_VERS, build TBD_DOCKER_COMPOSE_BUILD
+    + Image size: TBD_IMAGE_SIZE
+    + Digest: TBD_DIGEST
+    + Image ID: TBD_IMAGE_ID
+
 ## 3.6.0-p3
  + **Changes:** https://github.com/elgalu/docker-selenium/compare/3.6.0-p2...3.6.0-p3 (2017-10-10)
     + Upgrade Firefox patch to 56.0.1

CONTRIBUTING.md

@@ -11,7 +11,7 @@ For pull requests or local commits:
 
 For repository owners only:
 
-    git commit -m "Upgrade Firefox patch to 56.0.1"
+    git commit -m "Upgrade Chrome major to 62.0.3202.62"
     git tag -d latest; git tag -d `cat VERSION`; git push origin :`cat VERSION`; git tag `cat VERSION` && git push --force origin tmp-`cat VERSION` && git push --tags
 
 -- Wait for Travis to pass OK

Dockerfile

@@ -1,18 +1,36 @@
+#== FROM instructions support variables that are declared by
+# any ARG instructions that occur before the first FROM
+# ref: https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact
+#
+# To overwrite the build args use:
+#  docker build ... --build-arg UBUNTU_DATE=20171006
+ARG UBUNTU_FLAVOR=xenial
+ARG UBUNTU_DATE=20171006
+
 #== Ubuntu xenial is 16.04, i.e. FROM ubuntu:16.04
 # Find latest images at https://hub.docker.com/r/library/ubuntu/
-# Layer size: big: 127.2 MB
-FROM ubuntu:xenial-20170915
-ENV UBUNTU_FLAVOR="xenial" \
-    UBUNTU_DATE="20170915"
+# Layer size: ~122 MB
+FROM ubuntu:${UBUNTU_FLAVOR}-${UBUNTU_DATE}
+
+#== An ARG declared before a FROM is outside of a build stage,
+# so it can’t be used in any instruction after a FROM. To use
+# the default value of an ARG declared before the first
+# FROM use an ARG instruction without a value inside of a build stage
+# ref: https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact
+ARG UBUNTU_FLAVOR
+ARG UBUNTU_DATE
+
+# Docker build debug logging, green colored
+RUN printf "\033[1;32mFROM ubuntu:${UBUNTU_FLAVOR}-${UBUNTU_DATE} \033[0m\n"
 
 #== Ubuntu flavors - common
 RUN  echo "deb http://archive.ubuntu.com/ubuntu ${UBUNTU_FLAVOR} main universe\n" > /etc/apt/sources.list \
   && echo "deb http://archive.ubuntu.com/ubuntu ${UBUNTU_FLAVOR}-updates main universe\n" >> /etc/apt/sources.list \
   && echo "deb http://archive.ubuntu.com/ubuntu ${UBUNTU_FLAVOR}-security main universe\n" >> /etc/apt/sources.list
 
-MAINTAINER Team TIP <elgalu3+team-tip@gmail.com>
+MAINTAINER Leo Gallucci <elgalu3+dosel@gmail.com>
 # https://github.com/docker/docker/pull/25466#discussion-diff-74622923R677
-LABEL maintainer "Team TIP <elgalu3+team-tip@gmail.com>"
+LABEL maintainer "Leo Gallucci <elgalu3+dosel@gmail.com>"
 
 # No interactive frontend during docker build
 ENV DEBIAN_FRONTEND=noninteractive \
@@ -23,6 +41,7 @@ ENV DEBIAN_FRONTEND=noninteractive \
 #  ref: https://github.com/nodejs/docker-node/issues/340#issuecomment-321669029
 #  ref: http://askubuntu.com/a/235911/134645
 #  ref: https://github.com/moby/moby/issues/20022#issuecomment-182169732
+# How to remove keys? e.g. sudo apt-key del 2EA8F35793D8809A
 RUN set -ex \
   && for key in \
     2EA8F35793D8809A \
@@ -36,7 +55,6 @@ RUN set -ex \
     gpg --keyserver keyserver.ubuntu.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
-# How to remove keys? e.g. sudo apt-key del 2EA8F35793D8809A
 
 #========================
 # Miscellaneous packages
@@ -236,12 +254,18 @@ RUN apt-get -qqy update \
 USER seluser
 WORKDIR /home/seluser
 
+# Docker backward compatibility
+RUN echo "${UBUNTU_FLAVOR}" > UBUNTU_FLAVOR \
+ && echo "${UBUNTU_DATE}" > UBUNTU_DATE
+
 #=================
 # Selenium latest
 #=================
 # Layer size: medium ~22 MB
 ENV SEL_DIRECTORY="3.6" \
     SEL_VER="3.6.0"
+
+RUN echo $SEL_VER
 RUN  export SELBASE="https://selenium-release.storage.googleapis.com" \
   && export SELPATH="${SEL_DIRECTORY}/selenium-server-standalone-${SEL_VER}.jar" \
   && wget -nv ${SELBASE}/${SELPATH} \
@@ -603,12 +627,12 @@ RUN wget --no-verbose -O geckodriver.tar.gz \
 #===============
 # TODO: Use Google fingerprint to verify downloads
 #  https://www.google.de/linuxrepositories/
-ENV CHROME_VERSION_TRIGGER="61.0.3163.100" \
+ENV CHROME_VERSION_TRIGGER="62.0.3202.62" \
     CHROME_URL="https://dl.google.com/linux/direct" \
     CHROME_BASE_DEB_PATH="/home/seluser/chrome-deb/google-chrome" \
     GREP_ONLY_NUMS_VER="[0-9.]{2,20}"
 
-LABEL selenium_chrome_version "61.0.3163.100"
+LABEL selenium_chrome_version "62.0.3202.62"
 
 # Layer size: huge: 196.3 MB
 RUN apt-get -qqy update \

TBD_DOCKER_TAG.md

@@ -13,9 +13,9 @@
     + Python: TBD_PYTHON_VERSION
     + Tested on kernel dev host: 4.4.0-96-generic x86_64
     + Tested on kernel CI  host: TBD_HOST_UNAME
-    + Built at dev host with: Docker version 17.07.0-ce, build 8784753
+    + Built at dev host with: Docker version 17.10.0-ce, build f4ffd25
     + Built at CI  host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD
-    + Built at dev host with: Docker Compose version 1.16.1, build 6d1ac21
+    + Built at dev host with: Docker Compose version 1.17.0-rc1, build a0f95af
     + Built at CI  host with: Docker Compose version TBD_DOCKER_COMPOSE_VERS, build TBD_DOCKER_COMPOSE_BUILD
     + Image size: TBD_IMAGE_SIZE
     + Digest: TBD_DIGEST

VERSION

@@ -1 +1 @@
-3.6.0-p3
+3.6.0-p4

capabilities.json

@@ -2,7 +2,7 @@
   "caps": [
     {
       "BROWSER_NAME": "chrome",
-      "VERSION": "61.0.3163.100",
+      "VERSION": "62.0.3202.62",
       "PLATFORM": "LINUX"
     },
     {

images/grid3_console.png

@@ -23,6 +23,7 @@ if [[ ${TRAVIS_PULL_REQUEST_SLUG} != "" && \
       ${TRAVIS_PULL_REQUEST_SLUG} != ${TRAVIS_REPO_SLUG} && \
       ${TRAVIS_PULL_REQUEST} != "false" ]]; then
   echo "WARN: External PRs are untrusted by default therefore we need can't reuse and pull the image so building it from scratch..."
+  ./test/before_install_setup
   ./host-scripts/gen-scm-source.sh
   docker build -t selenium .
 else

test/before_install_pull

@@ -148,9 +148,9 @@ update_changelog() {
     || die "while trying to get TBD_JAVA_VENDOR"
   TBD_TIME_ZONE="$(docker exec grid printenv TZ | sed -r 's/[\/]+/\\\//g')" \
     || die "while trying to get TBD_TIME_ZONE"
-  UBUNTU_FLAVOR=$(docker exec grid printenv UBUNTU_FLAVOR) \
+  UBUNTU_FLAVOR=$(docker exec grid cat UBUNTU_FLAVOR) \
     || die "while trying to get UBUNTU_FLAVOR"
-  UBUNTU_DATE=$(docker exec grid printenv UBUNTU_DATE) \
+  UBUNTU_DATE=$(docker exec grid cat UBUNTU_DATE) \
     || die "while trying to get UBUNTU_DATE"
   sed -i -- "s/TBD_DOCKER_TAG/${TBD_DOCKER_TAG}/g" CHANGELOG.md || true
   sed -i -- "s/TBD_DIGEST/${TBD_DIGEST}/g" CHANGELOG.md || true