Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit a141112

Browse files
committed
README.md and CHANGELOG.md fixes
1 parent 05fd477 commit a141112

File tree

4 files changed

+29
-7
lines changed

4 files changed

+29
-7
lines changed

CHANGELOG.md

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,31 @@ Note image ids also change after scm-source.json has being updated which trigger
77
###### To get container versions
88
docker exec grid versions
99

10+
## TBD_DOCKER_TAG
11+
+ Date: TBD_DATE
12+
+ TBD_COMMIT_MSG
13+
+ Image tag details:
14+
+ Selenium: vTBD_SELENIUM_VERSION (TBD_SELENIUM_REVISION)
15+
+ Chrome stable: TBD_CHROME_STABLE
16+
+ Firefox stable: TBD_FIREFOX_STABLE
17+
+ Chromedriver: TBD_CHROME_DRIVER (TBD_CHROMEDRIVER_COMMIT)
18+
+ Java: TBD_JAVA_VENDOR Java TBD_JAVA_BUILD
19+
+ Timezone: TBD_TIME_ZONE
20+
+ FROM ubuntu:UBUNTU_FLAVOR-UBUNTU_DATE
21+
+ Python: TBD_PYTHON_VERSION
22+
+ Sauce Connect TBD_SAUCE_CONNECT_VERS, build TBD_SAUCE_CONNECT_BUILD TBD_SAUCE_CONNECT_REVISION
23+
+ BrowserStack Local version TBD_BROWSER_STACK_VERSION
24+
+ Tested on kernel dev host: 4.4.0-21-generic x86_64
25+
+ Tested on kernel CI host: TBD_HOST_UNAME
26+
+ Built at dev host with: Docker version 1.11.0, build 4dc5990
27+
+ Built at CI host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD
28+
+ Image size: TBD_IMAGE_SIZE
29+
+ Digest: TBD_DIGEST
30+
+ Image ID: TBD_IMAGE_ID
31+
1032
## 2.53.0i
1133
+ Date: 2016-04-24
12-
+ Upgrade Chrome major to 50.0.2661.86
13-
+ Chore: modularize script_push a bit
14-
+ Chore: Update more changelog versions from Travis
34+
+ Upgrade Chrome patch to 50.0.2661.86
1535
+ Image tag details:
1636
+ Selenium: v2.53.0 (35ae25b)
1737
+ Chrome stable: 50.0.2661.86

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ For pull requests:
1414

1515
For repository owners only:
1616

17-
git commit -m "Upgrade Chrome major to 50.0.2661.86"
17+
git commit -m "Upgrade Chrome patch to 50.0.2661.86"
18+
git tag -d latest #tag latest will be updated from TravisCI
1819
git tag 2.53.0i && git push origin tmp-2.53.0i && git push --tags
1920

2021
-- Wait for Travis to pass OK

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<<h1 id="h1">Selenium in Docker with Chrome and Firefox</h1>
1+
<h1 id="h1">Selenium in Docker with Chrome and Firefox</h1>
22

33
[![Build Status](https://travis-ci.org/elgalu/docker-selenium.svg?branch=master)](https://travis-ci.org/elgalu/docker-selenium)
44
[![Gitter](https://badges.gitter.im/Join Chat.svg)](https://gitter.im/elgalu/docker-selenium?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
@@ -15,7 +15,7 @@
1515

1616
![docker-selenium-grid](./images/grid_console.png)
1717

18-
<h2 id="official">Notes on similar repo: SeleniumHQ/docker-selenium</h2>
18+
<h2 id="official">Notes on the official repo</h2>
1919

2020
Note [SeleniumHQ/docker-selenium](https://github.com/SeleniumHQ/docker-selenium) project is more useful for building selenium grids while this one focuses on building disposable standalone seleniums with [video recording support](./docs/videos.md) and both browsers on the same container. It also adds some other features like [customizing the screen size](#screen-size) and [ssh access](#ssh) that can be particularly useful for tunneling support.
2121

test/script_push

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ die () {
2525
# Docker login, tag and push selenium #
2626
#######################################
2727
docker_login_tag_push() {
28-
docker login -e="$DOCKER_EMAIL" -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"
28+
# -e="$DOCKER_EMAIL"
29+
docker login -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"
2930
echo "Logged in to docker with user '${DOCKER_USERNAME}'"
3031
echo "docker tag and docker push using TRAVIS_TAG=${TRAVIS_TAG}"
3132
docker tag selenium:latest elgalu/selenium:${TRAVIS_TAG}

0 commit comments

Comments
 (0)