Add /var/log/cont/chrome_browser.log

Author: elgalu

CHANGELOG.md

@@ -7,6 +7,33 @@ Note image ids also change after scm-source.json has being updated which trigger
 ###### To get container versions
     docker exec grid versions
 
+## TBD_DOCKER_TAG
+ + **Changes:** https://github.com/elgalu/docker-selenium/compare/TBD_PREV_COMM...TBD_CUR_COMM (TBD_DATE)
+    + Add /var/log/cont/chrome_browser.log for Chrome driver logs via transfer-logs.sh
+    + Fix /var/log/cont/firefox_browser.log due to https://goo.gl/5NgU2t
+    + Breaking change: Rename chromedriver.log into chrome_driver.log
+ + **Image tag details:**
+    + Selenium 2: TBD_SELENIUM_2_VERSION (TBD_SELENIUM_2_REVISION)
+    + Selenium 3: TBD_SELENIUM_3_VERSION (TBD_SELENIUM_3_REVISION)
+    + Chrome stable:  TBD_CHROME_STABLE
+    + Firefox for Selenium 2: TBD_FIREFOX_FOR_SEL2
+    + Firefox for Selenium 3: TBD_FIREFOX_FOR_SEL3
+    + Geckodriver: TBD_GECKO_DRIVER
+    + Chromedriver: TBD_CHROME_DRIVER (TBD_CHROMEDRIVER_COMMIT)
+    + Java: TBD_JAVA_VENDOR Java TBD_JAVA_BUILD
+    + Timezone: TBD_TIME_ZONE
+    + FROM ubuntu:UBUNTU_FLAVOR-UBUNTU_DATE
+    + Python: TBD_PYTHON_VERSION
+    + Tested on kernel dev host: 4.4.0-72-generic x86_64
+    + Tested on kernel CI  host: TBD_HOST_UNAME
+    + Built at dev host with: Docker version 17.03.1-ce, build c6d412e
+    + Built at CI  host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD
+    + Built at dev host with: Docker Compose version 1.11.2, build dfed245
+    + Built at CI  host with: Docker Compose version TBD_DOCKER_COMPOSE_VERS, build TBD_DOCKER_COMPOSE_BUILD
+    + Image size: TBD_IMAGE_SIZE
+    + Digest: TBD_DIGEST
+    + Image ID: TBD_IMAGE_ID
+
 ## 3.3.1-p1
  + **Changes:** https://github.com/elgalu/docker-selenium/compare/236b861177bd2917d86...273a2e5e236f854eaace315 (2017-04-11)
     + Upgrade Chromedriver minor from 2.28 to 2.29
@@ -1048,7 +1075,7 @@ Note image ids also change after scm-source.json has being updated which trigger
 
 ## 2.53.1y
  + **Changes:** (2016-09-27)
- + Set chromedriver --log-path='/var/log/cont/chromedriver.log'
+ + Set chromedriver --log-path='/var/log/cont/chromedriver.log' **RENAMED** to chrome_driver.log
  + Add geckodriver for Firefox >= 48 (future releases)
  + Upgrade Ubuntu xenial to 20160923
  + Perhaps fixed DBUS mistery. See `entry.sh`

CONTRIBUTING.md

@@ -12,7 +12,7 @@ For pull requests or local commits:
 
 For repository owners only:
 
-    git commit -m "Upgrade Chromedriver minor from 2.28 to 2.29"
+    git commit -m "Add /var/log/cont/chrome_browser.log"
     git tag -d latest; git tag -d `cat VERSION`; git push origin :`cat VERSION`; git tag `cat VERSION` && git push --force origin tmp-`cat VERSION` && git push --tags
 
 -- Wait for Travis to pass OK

VERSION

@@ -1 +1 @@
-3.3.1-p1
+3.3.1-p2

bin/entry.sh

@@ -75,6 +75,11 @@ export VNC_TRYOUT_ERR_LOG="${LOGS_DIR}/vnc-tryouts-stderr"
 export VNC_TRYOUT_OUT_LOG="${LOGS_DIR}/vnc-tryouts-stdout"
 touch ${DOCKER_SELENIUM_STATUS}
 
+# https://github.com/SeleniumHQ/selenium/issues/2078#issuecomment-218320864
+# https://github.com/SeleniumHQ/selenium/blob/master/py/selenium/webdriver/firefox/firefox_binary.py#L27
+echo "webdriver.log.file has been discontinued. Please send us a PR if you know how to set the path for the Firefox browser logs" \
+  > "${LOGS_DIR}/firefox_browser.log"
+
 # We recalculate screen dimensions because docker run supports changing them
 export SCREEN_DEPTH="${SCREEN_MAIN_DEPTH}+${SCREEN_SUB_DEPTH}"
 export GEOMETRY="${SCREEN_WIDTH}""x""${SCREEN_HEIGHT}""x""${SCREEN_DEPTH}"

misc/misc.md

@@ -463,3 +463,24 @@ RUN  wget -nv -O unTrunc.zip \
             -L/usr/local/lib -lavformat \
             -lavcodec -lavutil \
   && mv untrunc /usr/bin
+
+### Log files
+Everything I tried before coming up with
+
+> webdriver.log.file has been discontinued. Please send us a PR if you know how to set the path for the Firefox browser logs
+
+Tried:
+
+```sh
+FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},log_path=${LOGS_DIR}/firefox_browser.log"
+-Dwebdriver.log.path="${LOGS_DIR}/firefox_browser.log" \
+-Dwebdriver.log.file="${LOGS_DIR}/firefox_browser.log" \
+-Dwebdriver.gecko.log_path="${LOGS_DIR}/firefox_browser.log" \
+export BROWSER_LOGFILE="${LOGS_DIR}/firefox_browser.log"
+```
+
+TODO: Figure out how to set `log_path`:
+https://github.com/mozilla/geckodriver/issues/362#issuecomment-273948335
+https://github.com/SeleniumHQ/selenium/commit/40a5d80e995071fb85f86e70e15e4b96cc692d11
+
+Outside of the running tests.

selenium-node-chrome/bin/start-selenium-node-chrome.sh

@@ -40,7 +40,7 @@ CHROME_BROWSER_CAPS="${CHROME_BROWSER_CAPS},chrome_binary=${CHROME_PATH}"
 
 java \
   -Dwebdriver.chrome.driver="/home/seluser/chromedriver" \
-  -Dwebdriver.chrome.logfile="${LOGS_DIR}/chromedriver.log" \
+  -Dwebdriver.chrome.logfile="${LOGS_DIR}/chrome_driver.log" \
   -Dwebdriver.chrome.verboseLogging="${CHROME_VERBOSELOGGING}" \
   ${JAVA_OPTS} \
   -jar ${SELENIUM_JAR_PATH} \

selenium-node-chrome/bin/transfer-logs.sh

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+
+# Try to retrieve Browser console logs
+cp /tmp/.*/chrome_debug.log "/var/log/cont/chrome_browser.log"

selenium-node-firefox/bin/start-selenium-node-firefox.sh

@@ -43,9 +43,11 @@ FIREFOX_BROWSER_CAPS="browserName=firefox,${COMMON_CAPS}"
 FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},version=${FIREFOX_VERSION}"
 FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},firefox_binary=${FIREFOX_DEST_BIN}"
 
+# public static final String BROWSER_LOGFILE = "webdriver.firefox.logfile";
+#   System property that defines the location of the file where Firefox log should be stored.
+
 java \
-  -Dwebdriver.firefox.logfile="${LOGS_DIR}/firefox_browser.log" \
-  -Dwebdriver.log.file="${LOGS_DIR}/firefox_driver.log" \
+  -Dwebdriver.firefox.logfile="${LOGS_DIR}/firefox_driver.log" \
   ${JAVA_OPTS} \
   -jar ${SELENIUM_JAR_PATH} \
   -port ${SELENIUM_NODE_FF_PORT} \

selenium-rc-chrome/bin/start-selenium-rc-chrome.sh

@@ -33,7 +33,7 @@ echo "INFO: JAVA_OPTS are '${JAVA_OPTS}'"
 CHROME_BROWSER_CAPS="browserName=*chrome,${COMMON_CAPS},version=${CHROME_VERSION},chrome_binary=${CHROME_PATH}"
 java \
   -Dwebdriver.chrome.driver="/home/seluser/chromedriver" \
-  -Dwebdriver.chrome.logfile="${LOGS_DIR}/chromedriver.log" \
+  -Dwebdriver.chrome.logfile="${LOGS_DIR}/rc_chromedriver.log" \
   -Dwebdriver.chrome.verboseLogging="${CHROME_VERBOSELOGGING}" \
   ${JAVA_OPTS} \
   -jar ${SELENIUM_JAR_PATH} \