Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit ec72a25

Browse files
committed
No need to set chrome_binary nor firefox_binary as binaries are already in the path
1 parent a95b051 commit ec72a25

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

selenium-multinode/bin/start-selenium-multinode.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ echo "INFO: JAVA_OPTS are '${JAVA_OPTS}'"
3939
# https://github.com/pilwon/selenium-webdriver/blob/master/java/server/src/org/openqa/grid/common/defaults/DefaultNode.json
4040
CHROME_BROWSER_CAPS="browserName=chrome,${COMMON_CAPS}"
4141
CHROME_BROWSER_CAPS="${CHROME_BROWSER_CAPS},version=${CHROME_VERSION}"
42-
CHROME_BROWSER_CAPS="${CHROME_BROWSER_CAPS},chrome_binary=${CHROME_PATH}"
42+
# CHROME_BROWSER_CAPS="${CHROME_BROWSER_CAPS},chrome_binary=${CHROME_PATH}"
4343

4444
FIREFOX_BROWSER_CAPS="browserName=firefox,${COMMON_CAPS}"
4545
FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},version=${FIREFOX_VERSION}"
46-
FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},firefox_binary=${FIREFOX_DEST_BIN}"
46+
# FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},firefox_binary=${FIREFOX_DEST_BIN}"
4747

4848
java \
4949
-Dwebdriver.chrome.driver="/home/seluser/chromedriver" \

selenium-node-chrome/bin/start-selenium-node-chrome.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ echo "INFO: JAVA_OPTS are '${JAVA_OPTS}'"
3636
# https://github.com/pilwon/selenium-webdriver/blob/master/java/server/src/org/openqa/grid/common/defaults/DefaultNode.json
3737
CHROME_BROWSER_CAPS="browserName=chrome,${COMMON_CAPS}"
3838
CHROME_BROWSER_CAPS="${CHROME_BROWSER_CAPS},version=${CHROME_VERSION}"
39-
CHROME_BROWSER_CAPS="${CHROME_BROWSER_CAPS},chrome_binary=${CHROME_PATH}"
39+
# CHROME_BROWSER_CAPS="${CHROME_BROWSER_CAPS},chrome_binary=${CHROME_PATH}"
4040

4141
java \
4242
-Dwebdriver.chrome.driver="/home/seluser/chromedriver" \

selenium-node-firefox/bin/start-selenium-node-firefox.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ echo "INFO: JAVA_OPTS are '${JAVA_OPTS}'"
3838
# TODO: how to set default firefox to latest?
3939
FIREFOX_BROWSER_CAPS="browserName=firefox,${COMMON_CAPS}"
4040
FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},version=${FIREFOX_VERSION}"
41-
FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},firefox_binary=${FIREFOX_DEST_BIN}"
41+
# FIREFOX_BROWSER_CAPS="${FIREFOX_BROWSER_CAPS},firefox_binary=${FIREFOX_DEST_BIN}"
4242

4343
# public static final String BROWSER_LOGFILE = "webdriver.firefox.logfile";
4444
# System property that defines the location of the file where Firefox log should be stored.

0 commit comments

Comments
 (0)