Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Commit f101b3f

Browse files
committed
Add warning that Selenium 2 support will be deprecated
1 parent e5c6176 commit f101b3f

File tree

6 files changed

+54
-17
lines changed

6 files changed

+54
-17
lines changed

CHANGELOG.md

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,32 @@ Note image ids also change after scm-source.json has being updated which trigger
77
###### To get container versions
88
docker exec grid versions
99

10+
## TBD_DOCKER_TAG
11+
+ **Changes:** https://github.com/elgalu/docker-selenium/compare/113d70a33933ea54168f85c2f5...TBD_CUR_COMM (TBD_DATE)
12+
+ Upgrade Chrome patch to 58.0.3029.96
13+
+ Add warning that Selenium 2 support will be deprecated
14+
+ **Image tag details:**
15+
+ Selenium version: TBD_SELENIUM_3_VERSION (TBD_SELENIUM_3_REVISION)
16+
+ Chrome stable: TBD_CHROME_STABLE
17+
+ Firefox stable: TBD_FIREFOX_FOR_SEL3
18+
+ Geckodriver: TBD_GECKO_DRIVER
19+
+ Chromedriver: TBD_CHROME_DRIVER (TBD_CHROMEDRIVER_COMMIT)
20+
+ Java: TBD_JAVA_VENDOR Java TBD_JAVA_BUILD
21+
+ Timezone: TBD_TIME_ZONE
22+
+ FROM ubuntu:UBUNTU_FLAVOR-UBUNTU_DATE
23+
+ Python: TBD_PYTHON_VERSION
24+
+ Tested on kernel dev host: 4.4.0-77-generic x86_64
25+
+ Tested on kernel CI host: TBD_HOST_UNAME
26+
+ Built at dev host with: Docker version 17.04.0-ce, build 4845c56
27+
+ Built at CI host with: Docker version TBD_DOCKER_VERS, build TBD_DOCKER_BUILD
28+
+ Built at dev host with: Docker Compose version 1.13.0, build 1719ceb
29+
+ Built at CI host with: Docker Compose version TBD_DOCKER_COMPOSE_VERS, build TBD_DOCKER_COMPOSE_BUILD
30+
+ Image size: TBD_IMAGE_SIZE
31+
+ Digest: TBD_DIGEST
32+
+ Image ID: TBD_IMAGE_ID
33+
1034
## 3.3.1-p6
11-
+ **Changes:** https://github.com/elgalu/docker-selenium/compare/TBD_PREV_COMM...TBD_CUR_COMM (2017-04-26)
35+
+ **Changes:** https://github.com/elgalu/docker-selenium/compare/c4e8df12781eb031795ea6...113d70a33933ea54168f85c2f5 (2017-04-26)
1236
+ Fix: Do not set --user-data-dir as it breaks the ability of clients to set Chrome options via the capabilities
1337
+ Continue deprecating Selenium 2
1438
+ Chrome arg default: --disable-infobars

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,9 @@ RUN apt-get -qqy update \
219219
USER seluser
220220
WORKDIR /home/seluser
221221

222-
#======================
223-
# Selenium 2 (default)
224-
#======================
222+
#========================
223+
# Selenium 2 (deprecated)
224+
#========================
225225
# Layer size: medium: 21.23 MB
226226
ENV SEL_MAJOR_VER="2.53" \
227227
SEL_PATCH_LEVEL_VER="1"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
Selenium 3 `docker run ... elgalu/selenium:latest`
2121
![docker-selenium-grid](./images/grid3_console.png)
2222

23-
Selenium 2 `docker run ... elgalu/selenium:2` *no longer maintained*
23+
Selenium 2 `docker run ... elgalu/selenium:2` **no longer maintained**
2424
![docker-selenium-grid](./images/grid2_console.png)
2525

2626
### Purpose

bin/entry.sh

Lines changed: 23 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ set -e
1111
# - this gives less erros: DBUS_SESSION_BUS_ADDRESS="unix:abstract=/dev/null"
1212
sudo rm -f /var/lib/dbus/machine-id
1313
sudo mkdir -p /var/run/dbus
14-
sudo service dbus restart
14+
sudo service dbus restart >dbus_service.log
1515
# Test dbus works
16-
service dbus status
16+
service dbus status >dbus_service_status.log
1717
export $(dbus-launch)
1818
export NSS_USE_SHARED_DB=ENABLED
19-
echo "-- INFO: DBUS_SESSION_BUS_ADDRESS=${DBUS_SESSION_BUS_ADDRESS}"
19+
# echo "-- INFO: DBUS_SESSION_BUS_ADDRESS=${DBUS_SESSION_BUS_ADDRESS}"
2020
#=> e.g. DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-APZO4BE4TJ,guid=6e9c098d053d3038cb0756ae57ecc885
21-
echo "-- INFO: DBUS_SESSION_BUS_PID=${DBUS_SESSION_BUS_PID}"
21+
# echo "-- INFO: DBUS_SESSION_BUS_PID=${DBUS_SESSION_BUS_PID}"
2222
#=> e.g. DBUS_SESSION_BUS_PID=44
2323
#
2424
#-----------------------------------------------
@@ -54,10 +54,23 @@ export FIREFOX_VERSION=$(firefox_version)
5454
export CHROME_VESION=$(chrome_stable_version)
5555
export DOSEL_VERSION=$(cat VERSION)
5656

57+
echo "-- INFO: Docker Img. Version: ${DOSEL_VERSION}"
5758
echo "-- INFO: Chrome..... Version: ${CHROME_VESION}"
5859
echo "-- INFO: Firefox.... Version: ${FIREFOX_VERSION}"
59-
echo "-- INFO: Using Selenium.....: ${USE_SELENIUM}"
60-
echo "-- INFO: Docker Img. Version: ${DOSEL_VERSION}"
60+
61+
if [ "${USE_SELENIUM}" == "2" ]; then
62+
# In the future this warning will be changed to an error and exit command
63+
echo "-- INFO: Using Selenium.....: ${USE_SELENIUM}"
64+
echo -e "\n\n\n\n"
65+
echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
66+
echo "!!! WARNING!!! You are using the unmaintained Selenium 2 !!!"
67+
echo "!!! to continue using Selenium 2 please use the proper tag:"
68+
echo "!!! docker pull elgalu/selenium:2 !!!"
69+
echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
70+
echo -e "\n\n\n\n"
71+
else
72+
echo "-- INFO: Using Selenium.....: ${SEL_VER}"
73+
fi
6174

6275
# export PATH="${PATH}:${BIN_UTILS}"
6376
export SUPERVISOR_PIDFILE="${RUN_DIR}/supervisord.pid"
@@ -390,8 +403,8 @@ function get_free_display() {
390403
local find_display_num=-1
391404

392405
# Get a list of socket DISPLAYs already used
393-
netstat -nlp | grep -Po '(?<=\/tmp\/\.X11-unix\/X)([0-9]+)' | sort -u > /tmp/netstatX11.log
394-
[ ! -s /tmp/netstatX11.log ] && echo "-- INFO: Emtpy file /tmp/netstatX11.log" 1>&3
406+
netstat -nlp 2>/dev/null | grep -Po '(?<=\/tmp\/\.X11-unix\/X)([0-9]+)' | sort -u > /tmp/netstatX11.log
407+
# [ ! -s /tmp/netstatX11.log ] && echo "-- INFO: Emtpy file /tmp/netstatX11.log" 1>&3
395408

396409
# important: while loops are executed in a subshell
397410
# var assignments will be lost unless using <<<
@@ -441,15 +454,15 @@ function get_free_display() {
441454
break
442455
fi
443456
done
444-
[ "${selected_disp_num}" = "-1" ] || echo "-- INFO: Found free DISPLAY=:${selected_disp_num}" 1>&3
457+
[ "${selected_disp_num}" = "-1" ] #|| echo "-- INFO: Found free DISPLAY=:${selected_disp_num}" 1>&3
445458

446459
echo ${selected_disp_num}
447460
}
448461

449462
function start_xvfb() {
450463
# Start the X server that can run on machines with no real display
451464
# using Xvfb instead of Xdummy
452-
echo "-- INFO: Will try to start Xvfb at DISPLAY=${DISPLAY}" 1>&3
465+
# echo "-- INFO: Will try to start Xvfb at DISPLAY=${DISPLAY}" 1>&3
453466
# if DEBUG = true ...
454467
# echo "Will use the following values for Xvfb"
455468
# echo " screen=${SCREEN_NUM} geometry=${GEOMETRY}"

capabilities.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"caps": [
33
{
44
"BROWSER_NAME": "chrome",
5-
"VERSION": "58.0.3029.81",
5+
"VERSION": "58.0.3029.96",
66
"PLATFORM": "LINUX"
77
},
88
{

capabilities3.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"caps": [
33
{
44
"BROWSER_NAME": "chrome",
5-
"VERSION": "58.0.3029.81",
5+
"VERSION": "58.0.3029.96",
66
"PLATFORM": "LINUX"
77
},
88
{

0 commit comments

Comments
 (0)