Skip to content

Commit 56891d9

Browse files
authored
fix(cli): test runner should display full exception stacktrace on failed cases (#1672)
* fix(cli): print full exception stacktrace on test failures Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com> * fix(build): use oracle gvm instead of community Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com> --------- Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
1 parent 1b49592 commit 56891d9

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/cli/src/main/kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ import elide.tool.cli.output.JLineLogbackAppender
117117
import elide.tool.cli.output.TOOL_LOGGER_APPENDER
118118
import elide.tool.cli.output.TOOL_LOGGER_NAME
119119
import elide.tool.err.ErrPrinter
120+
import elide.tool.err.ErrorHandler.ErrorUtils.buildStacktrace
120121
import elide.tool.exec.SubprocessRunner.delegateTask
121122
import elide.tool.exec.SubprocessRunner.stringToTask
122123
import elide.tool.exec.SubprocessRunner.subprocess
@@ -1848,7 +1849,7 @@ internal class ToolShellCommand : ProjectAwareSubcommand<ToolState, CommandConte
18481849
is TestOutcome.Error -> {
18491850
val reason = outcome.reason
18501851
val msg = when {
1851-
reason is Throwable && reason.message != null -> reason.message
1852+
reason is Throwable -> reason.buildStacktrace()
18521853
reason != null -> reason.toString()
18531854
else -> "Unknown error"
18541855
}
@@ -1862,7 +1863,7 @@ internal class ToolShellCommand : ProjectAwareSubcommand<ToolState, CommandConte
18621863
is TestOutcome.Failure -> {
18631864
val reason = outcome.reason
18641865
val msg = when {
1865-
reason is Throwable && reason.message != null -> reason.message
1866+
reason is Throwable -> reason.buildStacktrace()
18661867
reason != null -> reason.toString()
18671868
else -> "Unknown error"
18681869
}

packages/graalvm/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ version = rootProject.version as String
5858
// - `LD`: Linker
5959
// - `CFLAGS`: C compiler flags
6060

61-
val oracleGvm = false
61+
val oracleGvm = true
6262
val oracleGvmLibs = oracleGvm
6363
val enableJpms = false
6464
val enableEdge = false
@@ -81,7 +81,7 @@ val selectedJvm = if (enableEdge) edgeJvm else stableJvm
8181
val elideTarget = TargetInfo.current(project)
8282

8383
val jvmType: JvmVendorSpec =
84-
if (oracleGvm) JvmVendorSpec.matching("Oracle Corporation") else JvmVendorSpec.GRAAL_VM
84+
if (oracleGvm) JvmVendorSpec.ORACLE else JvmVendorSpec.GRAAL_VM
8585

8686
val gvmLauncher = javaToolchains.launcherFor {
8787
languageVersion.set(JavaLanguageVersion.of(selectedJvmTarget))

0 commit comments

Comments
 (0)