Skip to content

Commit 6d2f303

Browse files
darvldsgammon
authored andcommitted
fix: review cleanup
- Remove empty function in CLI - Clarify `--wsgi` CLI option's description - Format native image metadata Signed-off-by: Dario Valdespino <[email protected]>
1 parent 7ae69d6 commit 6d2f303

File tree

3 files changed

+24
-25
lines changed

3 files changed

+24
-25
lines changed

packages/cli/src/main/kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3151,10 +3151,6 @@ internal class ToolShellCommand : ProjectAwareSubcommand<ToolState, CommandConte
31513151
}
31523152
}
31533153
}
3154-
3155-
private fun bindServer() {
3156-
3157-
}
31583154
}
31593155

31603156
private fun PackageManifestService.resolveToTask(

packages/cli/src/main/kotlin/elide/tool/cli/options/ServerOptions.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,17 @@ import elide.tooling.project.ElideProject
4949
/** Specifies a WSGI app to be served. */
5050
@Option(
5151
names = ["--wsgi"],
52-
description = ["Import spec for a WSGI application to serve."],
52+
description = [
53+
"Name of a callable symbol to be used as the WSGI application, may contain arguments for factory functions, " +
54+
"e.g. my_app(arg1,arg2).",
55+
],
5356
)
5457
var wsgi: String? = null
5558

5659
fun effectiveServerOptions(project: ElideProject?): EffectiveServerOptions {
5760
return EffectiveServerOptions(
5861
host = host ?: project?.manifest?.dev?.server?.host ?: DEFAULT_SERVER_HOST,
59-
port = (port ?: project?.manifest?.dev?.server?.port ?:DEFAULT_SERVER_PORT).toUShort(),
62+
port = (port ?: project?.manifest?.dev?.server?.port ?: DEFAULT_SERVER_PORT).toUShort(),
6063
linkHost = when (val explicit = host) {
6164
null -> DEFAULT_LINK_HOST
6265
LOCAL_SERVER_HOST, DEFAULT_SERVER_HOST -> DEFAULT_LINK_HOST

packages/cli/src/main/resources/META-INF/native-image/dev/elide/elide-cli/reachability-metadata.json

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15077,7 +15077,7 @@
1507715077
}
1507815078
],
1507915079
"foreign": {
15080-
"downcalls": [
15080+
"upcalls": [
1508115081
{
1508215082
"returnType": "void",
1508315083
"parameterTypes": [
@@ -15369,12 +15369,6 @@
1536915369
"jlong"
1537015370
]
1537115371
},
15372-
{
15373-
"returnType": "jint",
15374-
"parameterTypes": [
15375-
"jint"
15376-
]
15377-
},
1537815372
{
1537915373
"returnType": "jlong",
1538015374
"parameterTypes": [
@@ -15514,16 +15508,6 @@
1551415508
"jlong"
1551515509
]
1551615510
},
15517-
{
15518-
"returnType": "jint",
15519-
"parameterTypes": [
15520-
"jlong",
15521-
"jint",
15522-
"jlong",
15523-
"jlong",
15524-
"jlong"
15525-
]
15526-
},
1552715511
{
1552815512
"returnType": "jlong",
1552915513
"parameterTypes": [
@@ -15640,7 +15624,7 @@
1564015624
]
1564115625
}
1564215626
],
15643-
"upcalls": [
15627+
"downcalls": [
1564415628
{
1564515629
"returnType": "void",
1564615630
"parameterTypes": [
@@ -15932,6 +15916,12 @@
1593215916
"jlong"
1593315917
]
1593415918
},
15919+
{
15920+
"returnType": "jint",
15921+
"parameterTypes": [
15922+
"jint"
15923+
]
15924+
},
1593515925
{
1593615926
"returnType": "jlong",
1593715927
"parameterTypes": [
@@ -16071,6 +16061,16 @@
1607116061
"jlong"
1607216062
]
1607316063
},
16064+
{
16065+
"returnType": "jint",
16066+
"parameterTypes": [
16067+
"jlong",
16068+
"jint",
16069+
"jlong",
16070+
"jlong",
16071+
"jlong"
16072+
]
16073+
},
1607416074
{
1607516075
"returnType": "jlong",
1607616076
"parameterTypes": [
@@ -16188,4 +16188,4 @@
1618816188
}
1618916189
]
1619016190
}
16191-
}
16191+
}

0 commit comments

Comments
 (0)