Skip to content

feat(secrets): allow changing remote superuser credentials #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(secrets): allow changing remote superuser credentials #1754

wants to merge 1 commit into from
+38 −1

Conversation

@melodicore
Copy link
Member

@melodicore melodicore commented Nov 14, 2025 •
edited by pull-request-badge bot
Loading

Ready for review Powered by Pull Request Badge

Summary

The superuser credentials for managing all remote secret access files could not be changed. Now they can.

@melodicore melodicore requested a review from sgammon as a code owner November 14, 2025 10:37
@codecov
Copy link

codecov bot commented Nov 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.93%. Comparing base (c8c853d) to head (466087b).

Files with missing lines Patch % Lines
.../kotlin/elide/secrets/impl/SecretManagementImpl.kt 11.11% 8 Missing ⚠️
...n/elide/tool/cli/cmd/secrets/ToolSecretsCommand.kt 0.00% 2 Missing ⚠️
.../kotlin/elide/secrets/impl/RemoteManagementImpl.kt 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   42.94%   42.93%   -0.02%     
==========================================
  Files         895      895              
  Lines       42415    42432      +17     
  Branches     5959     5962       +3     
==========================================
+ Hits        18216    18218       +2     
- Misses      21997    22012      +15     
  Partials     2202     2202
Flag Coverage Δ
jvm 42.93% <33.33%> (-0.02%) ⬇️
lib 42.93% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rets/src/main/kotlin/elide/secrets/SecretValues.kt 61.53% <ø> (ø)
...n/elide/tool/cli/cmd/secrets/ToolSecretsCommand.kt 1.33% <0.00%> (-0.02%) ⬇️
.../kotlin/elide/secrets/impl/RemoteManagementImpl.kt 71.42% <71.42%> (ø)
.../kotlin/elide/secrets/impl/SecretManagementImpl.kt 64.98% <11.11%> (-1.69%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c853d...466087b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgammon sgammon Awaiting requested review from sgammon sgammon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@melodicore