fix(napi/parser): utf16 span for errors (oxc-project#9112)

Author: hi-ogawa

napi/parser/src/lib.rs

@@ -69,7 +69,7 @@ fn parse_with_return(filename: &str, source_text: String, options: &ParserOption
     let allocator = Allocator::default();
     let source_type = get_source_type(filename, options);
     let mut ret = parse(&allocator, source_type, &source_text, options);
-    let errors = ret.errors.into_iter().map(OxcError::from).collect::<Vec<_>>();
+    let mut errors = ret.errors.into_iter().map(OxcError::from).collect::<Vec<_>>();
 
     let mut comments = ret
         .program
@@ -87,8 +87,6 @@ fn parse_with_return(filename: &str, source_text: String, options: &ParserOption
         .collect::<Vec<Comment>>();
 
     if options.convert_span_utf16.unwrap_or(false) {
-        // TODO: fix spans in `errors`
-
         // Empty `comments` so comment spans don't get converted twice
         ret.program.comments.clear();
 
@@ -100,6 +98,13 @@ fn parse_with_return(filename: &str, source_text: String, options: &ParserOption
             comment.start = converter.convert_offset(comment.start);
             comment.end = converter.convert_offset(comment.end);
         }
+
+        for error in &mut errors {
+            for label in &mut error.labels {
+                label.start = converter.convert_offset(label.start);
+                label.end = converter.convert_offset(label.end);
+            }
+        }
     }
     let program = serde_json::to_string(&ret.program).unwrap();
     let module = EcmaScriptModule::from(&ret.module_record);

napi/parser/test/parse.test.ts

@@ -205,6 +205,26 @@ it('utf16 span', async () => {
       }
     `);
   }
+  {
+    const ret = await parseAsync('test.js', `"🤨";asdf asdf`, {
+      convertSpanUtf16: true,
+    });
+    expect(ret.errors).toMatchInlineSnapshot(`
+      [
+        {
+          "helpMessage": "Try insert a semicolon here",
+          "labels": [
+            {
+              "end": 9,
+              "start": 9,
+            },
+          ],
+          "message": "Expected a semicolon or an implicit semicolon after a statement, but found none",
+          "severity": "Error",
+        },
+      ]
+    `);
+  }
 });
 
 describe('error', () => {