Skip to content

Commit 7a54493

Browse files
authored
test(coverage/typescript): Update 8xxx error codes handling (oxc-project#12034)
Part of oxc-project#11582
1 parent ff1d42f commit 7a54493

File tree

5 files changed

+19
-41
lines changed

5 files changed

+19
-41
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
commit: 81c95189
22

33
codegen_typescript Summary:
4-
AST Parsed : 6576/6576 (100.00%)
5-
Positive Passed: 6576/6576 (100.00%)
4+
AST Parsed : 6592/6592 (100.00%)
5+
Positive Passed: 6592/6592 (100.00%)

tasks/coverage/snapshots/estree_typescript.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
commit: 81c95189
22

33
estree_typescript Summary:
4-
AST Parsed : 6528/6528 (100.00%)
5-
Positive Passed: 6525/6528 (99.95%)
4+
AST Parsed : 6544/6544 (100.00%)
5+
Positive Passed: 6541/6544 (99.95%)
66
Mismatch: tasks/coverage/typescript/tests/cases/conformance/jsx/jsxReactTestSuite.tsx
77

88
Mismatch: tasks/coverage/typescript/tests/cases/conformance/jsx/tsxReactEmitEntities.tsx

tasks/coverage/snapshots/parser_typescript.snap

Lines changed: 3 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
commit: 81c95189
22

33
parser_typescript Summary:
4-
AST Parsed : 6569/6576 (99.89%)
5-
Positive Passed: 6558/6576 (99.73%)
6-
Negative Passed: 1422/5722 (24.85%)
4+
AST Parsed : 6585/6592 (99.89%)
5+
Positive Passed: 6574/6592 (99.73%)
6+
Negative Passed: 1422/5706 (24.92%)
77
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/ExportAssignment7.ts
88

99
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/ExportAssignment8.ts
@@ -2422,8 +2422,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsFileMethod
24222422

24232423
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsFunctionWithPrototypeNoErrorTruncationNoCrash.ts
24242424

2425-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsNoImplicitAnyNoCascadingReferenceErrors.ts
2426-
24272425
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsPropertyAssignedAfterMethodDeclaration.ts
24282426

24292427
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocArrayObjectPromiseNoImplicitAny.ts
@@ -2442,8 +2440,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocImportT
24422440

24432441
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocInTypeScript.ts
24442442

2445-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocParamTagInvalid.ts
2446-
24472443
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocParameterParsingInfiniteLoop.ts
24482444

24492445
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocPropertyTagInvalid.ts
@@ -2458,8 +2454,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocTypeCas
24582454

24592455
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocTypeNongenericInstantiationAttempt.ts
24602456

2461-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocTypedefMissingType.ts
2462-
24632457
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsxCallElaborationCheckNoCrash1.tsx
24642458

24652459
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsxChildWrongType.tsx
@@ -2960,8 +2954,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/noInferUnion
29602954

29612955
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/noMappedGetSet.ts
29622956

2963-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/noParameterReassignmentIIFEAnnotated.ts
2964-
29652957
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/noRepeatedPropertyNames.ts
29662958

29672959
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/noStrictGenericChecks.ts
@@ -6464,8 +6456,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/che
64646456

64656457
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/checkJsdocOptionalParamOrder.ts
64666458

6467-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/checkJsdocParamOnVariableDeclaredFunctionExpression.ts
6468-
64696459
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/checkJsdocReturnTag1.ts
64706460

64716461
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/checkJsdocReturnTag2.ts
@@ -6528,10 +6518,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/enu
65286518

65296519
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/errorOnFunctionReturnType.ts
65306520

6531-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/extendsTag2.ts
6532-
6533-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/extendsTag4.ts
6534-
65356521
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/extendsTag5.ts
65366522

65376523
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/extendsTagEmit.ts
@@ -6564,12 +6550,8 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsd
65646550

65656551
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocAugments_errorInExtendsExpression.ts
65666552

6567-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocAugments_nameMismatch.ts
6568-
65696553
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocAugments_noExtends.ts
65706554

6571-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocAugments_notAClass.ts
6572-
65736555
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocFunctionType.ts
65746556

65756557
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocFunction_missingReturn.ts
@@ -6598,8 +6580,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsd
65986580

65996581
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocParamTag2.ts
66006582

6601-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocParamTagTypeLiteral.ts
6602-
66036583
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocParseBackquotedParamName.ts
66046584

66056585
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/jsdocParseDotDotDotInJSDocFunction.ts
@@ -6654,14 +6634,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/ove
66546634

66556635
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/overloadTag2.ts
66566636

6657-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/paramTagNestedWithoutTopLevelObject.ts
6658-
6659-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/paramTagNestedWithoutTopLevelObject2.ts
6660-
6661-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/paramTagNestedWithoutTopLevelObject3.ts
6662-
6663-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/paramTagNestedWithoutTopLevelObject4.ts
6664-
66656637
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/paramTagOnFunctionUsingArguments.ts
66666638

66676639
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/paramTagWrapping.ts
@@ -6672,8 +6644,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/tem
66726644

66736645
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/thisTag3.ts
66746646

6675-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typeTagCircularReferenceOnConstructorFunction.ts
6676-
66776647
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typeTagModuleExports.ts
66786648

66796649
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typeTagNoErasure.ts
@@ -6688,8 +6658,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typ
66886658

66896659
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typedefCrossModule5.ts
66906660

6691-
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typedefDuplicateTypeDeclaration.ts
6692-
66936661
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typedefInnerNamepaths.ts
66946662

66956663
Expect Syntax Error: tasks/coverage/typescript/tests/cases/conformance/jsdoc/typedefMultipleTypeParameters.ts

tasks/coverage/snapshots/transformer_typescript.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
commit: 81c95189
22

33
transformer_typescript Summary:
4-
AST Parsed : 6576/6576 (100.00%)
5-
Positive Passed: 6572/6576 (99.94%)
4+
AST Parsed : 6592/6592 (100.00%)
5+
Positive Passed: 6588/6592 (99.94%)
66
Mismatch: tasks/coverage/typescript/tests/cases/compiler/esDecoratorsClassFieldsCrash.ts
77

88
Mismatch: tasks/coverage/typescript/tests/cases/conformance/classes/propertyMemberDeclarations/autoAccessor2.ts

tasks/coverage/src/typescript/mod.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,16 @@ impl Case for TypeScriptCase {
135135
// TODO: Filter out more not-supported error codes here
136136
static NOT_SUPPORTED_ERROR_CODES: phf::Set<&'static str> = phf::phf_set![
137137
"2315", // Type 'U' is not generic.
138+
"8021", // JSDoc '@typedef' tag should either have a type annotation or be followed by '@property' or '@member' tags.
139+
"8022", // JSDoc '@extends' is not attached to a class.
140+
"8023", // JSDoc '@extends Mismatch' does not match the 'extends B' clause.
141+
"8024", // JSDoc '@param' tag has name 's', but there is no parameter with that name.
142+
"8026", // Expected A<T> type arguments; provide these with an '@extends' tag.
143+
"8029", // JSDoc '@param' tag has name 'rest', but there is no parameter with that name. It would match 'arguments' if it had an array type.
144+
"8030", // The type of a function declaration must match the function's signature.
145+
"8032", // Qualified name 'xyz.p' is not allowed without a leading '@param {object} xyz'.
146+
"8033", // A JSDoc '@typedef' comment may not contain multiple '@type' tags.
147+
"8039", // A JSDoc '@template' tag may not follow a '@typedef', '@callback', or '@overload' tag
138148
"9005", // Declaration emit for this file requires using private name 'Sub'. An explicit type annotation may unblock declaration emit.
139149
"9006", // DeclaDeclaration emit for this file requires using private name 'Item' from module '"some-mod"'. An explicit type annotation may unblock declaration emit.
140150
"9007", // FunctDeclaion must have an explicit return type annotation with --isolatedDeclarations.

0 commit comments

Comments
 (0)