Skip to content

Commit beeda9a

Browse files
overlookmoteloverlookmotel
committed
refactor(ast): alter comments in generated Visit trait (oxc-project#8793)
Make these comments more descriptive.
1 parent 6f4a023 commit beeda9a

File tree

3 files changed

+70
-72
lines changed

3 files changed

+70
-72
lines changed

‎crates/oxc_ast/src/generated/visit.rs‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1363,7 +1363,7 @@ pub mod walk {
13631363

13641364
#[inline]
13651365
pub fn walk_span<'a, V: Visit<'a>>(visitor: &mut V, it: &Span) {
1366-
// NOTE: AstKind doesn't exists!
1366+
// No `AstKind` for this type
13671367
}
13681368

13691369
#[inline]
@@ -1607,7 +1607,7 @@ pub mod walk {
16071607

16081608
#[inline]
16091609
pub fn walk_template_element<'a, V: Visit<'a>>(visitor: &mut V, it: &TemplateElement<'a>) {
1610-
// NOTE: AstKind doesn't exists!
1610+
// No `AstKind` for this type
16111611
visitor.visit_span(&it.span);
16121612
}
16131613

@@ -1935,7 +1935,7 @@ pub mod walk {
19351935

19361936
#[inline]
19371937
pub fn walk_ts_array_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSArrayType<'a>) {
1938-
// NOTE: AstKind doesn't exists!
1938+
// No `AstKind` for this type
19391939
visitor.visit_span(&it.span);
19401940
visitor.visit_ts_type(&it.element_type);
19411941
}
@@ -1956,7 +1956,7 @@ pub mod walk {
19561956

19571957
#[inline]
19581958
pub fn walk_ts_constructor_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSConstructorType<'a>) {
1959-
// NOTE: AstKind doesn't exists!
1959+
// No `AstKind` for this type
19601960
visitor.visit_span(&it.span);
19611961
if let Some(type_parameters) = &it.type_parameters {
19621962
visitor.visit_ts_type_parameter_declaration(type_parameters);
@@ -2015,7 +2015,7 @@ pub mod walk {
20152015

20162016
#[inline]
20172017
pub fn walk_binding_pattern<'a, V: Visit<'a>>(visitor: &mut V, it: &BindingPattern<'a>) {
2018-
// NOTE: AstKind doesn't exists!
2018+
// No `AstKind` for this type
20192019
visitor.visit_binding_pattern_kind(&it.kind);
20202020
if let Some(type_annotation) = &it.type_annotation {
20212021
visitor.visit_ts_type_annotation(type_annotation);
@@ -2059,7 +2059,7 @@ pub mod walk {
20592059

20602060
#[inline]
20612061
pub fn walk_binding_property<'a, V: Visit<'a>>(visitor: &mut V, it: &BindingProperty<'a>) {
2062-
// NOTE: AstKind doesn't exists!
2062+
// No `AstKind` for this type
20632063
visitor.visit_span(&it.span);
20642064
visitor.visit_property_key(&it.key);
20652065
visitor.visit_binding_pattern(&it.value);
@@ -2132,7 +2132,7 @@ pub mod walk {
21322132

21332133
#[inline]
21342134
pub fn walk_ts_function_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSFunctionType<'a>) {
2135-
// NOTE: AstKind doesn't exists!
2135+
// No `AstKind` for this type
21362136
visitor.visit_span(&it.span);
21372137
if let Some(type_parameters) = &it.type_parameters {
21382138
visitor.visit_ts_type_parameter_declaration(type_parameters);
@@ -2200,7 +2200,7 @@ pub mod walk {
22002200
visitor: &mut V,
22012201
it: &TSImportAttributes<'a>,
22022202
) {
2203-
// NOTE: AstKind doesn't exists!
2203+
// No `AstKind` for this type
22042204
visitor.visit_span(&it.span);
22052205
visitor.visit_identifier_name(&it.attributes_keyword);
22062206
visitor.visit_ts_import_attribute_list(&it.elements);
@@ -2218,7 +2218,7 @@ pub mod walk {
22182218

22192219
#[inline]
22202220
pub fn walk_ts_import_attribute<'a, V: Visit<'a>>(visitor: &mut V, it: &TSImportAttribute<'a>) {
2221-
// NOTE: AstKind doesn't exists!
2221+
// No `AstKind` for this type
22222222
visitor.visit_span(&it.span);
22232223
visitor.visit_ts_import_attribute_name(&it.name);
22242224
visitor.visit_expression(&it.value);
@@ -2360,14 +2360,14 @@ pub mod walk {
23602360

23612361
#[inline]
23622362
pub fn walk_ts_optional_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSOptionalType<'a>) {
2363-
// NOTE: AstKind doesn't exists!
2363+
// No `AstKind` for this type
23642364
visitor.visit_span(&it.span);
23652365
visitor.visit_ts_type(&it.type_annotation);
23662366
}
23672367

23682368
#[inline]
23692369
pub fn walk_ts_rest_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSRestType<'a>) {
2370-
// NOTE: AstKind doesn't exists!
2370+
// No `AstKind` for this type
23712371
visitor.visit_span(&it.span);
23722372
visitor.visit_ts_type(&it.type_annotation);
23732373
}
@@ -2395,7 +2395,7 @@ pub mod walk {
23952395

23962396
#[inline]
23972397
pub fn walk_ts_tuple_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSTupleType<'a>) {
2398-
// NOTE: AstKind doesn't exists!
2398+
// No `AstKind` for this type
23992399
visitor.visit_span(&it.span);
24002400
visitor.visit_ts_tuple_elements(&it.element_types);
24012401
}
@@ -2443,7 +2443,7 @@ pub mod walk {
24432443

24442444
#[inline]
24452445
pub fn walk_ts_index_signature<'a, V: Visit<'a>>(visitor: &mut V, it: &TSIndexSignature<'a>) {
2446-
// NOTE: AstKind doesn't exists!
2446+
// No `AstKind` for this type
24472447
visitor.visit_span(&it.span);
24482448
visitor.visit_ts_index_signature_names(&it.parameters);
24492449
visitor.visit_ts_type_annotation(&it.type_annotation);
@@ -2464,7 +2464,7 @@ pub mod walk {
24642464
visitor: &mut V,
24652465
it: &TSIndexSignatureName<'a>,
24662466
) {
2467-
// NOTE: AstKind doesn't exists!
2467+
// No `AstKind` for this type
24682468
visitor.visit_span(&it.span);
24692469
visitor.visit_ts_type_annotation(&it.type_annotation);
24702470
}
@@ -2489,7 +2489,7 @@ pub mod walk {
24892489
visitor: &mut V,
24902490
it: &TSCallSignatureDeclaration<'a>,
24912491
) {
2492-
// NOTE: AstKind doesn't exists!
2492+
// No `AstKind` for this type
24932493
visitor.visit_span(&it.span);
24942494
if let Some(type_parameters) = &it.type_parameters {
24952495
visitor.visit_ts_type_parameter_declaration(type_parameters);
@@ -2545,14 +2545,14 @@ pub mod walk {
25452545

25462546
#[inline]
25472547
pub fn walk_ts_type_operator<'a, V: Visit<'a>>(visitor: &mut V, it: &TSTypeOperator<'a>) {
2548-
// NOTE: AstKind doesn't exists!
2548+
// No `AstKind` for this type
25492549
visitor.visit_span(&it.span);
25502550
visitor.visit_ts_type(&it.type_annotation);
25512551
}
25522552

25532553
#[inline]
25542554
pub fn walk_ts_type_predicate<'a, V: Visit<'a>>(visitor: &mut V, it: &TSTypePredicate<'a>) {
2555-
// NOTE: AstKind doesn't exists!
2555+
// No `AstKind` for this type
25562556
visitor.visit_span(&it.span);
25572557
visitor.visit_ts_type_predicate_name(&it.parameter_name);
25582558
if let Some(type_annotation) = &it.type_annotation {
@@ -2634,7 +2634,7 @@ pub mod walk {
26342634
visitor: &mut V,
26352635
it: &JSDocNullableType<'a>,
26362636
) {
2637-
// NOTE: AstKind doesn't exists!
2637+
// No `AstKind` for this type
26382638
visitor.visit_span(&it.span);
26392639
visitor.visit_ts_type(&it.type_annotation);
26402640
}
@@ -2644,14 +2644,14 @@ pub mod walk {
26442644
visitor: &mut V,
26452645
it: &JSDocNonNullableType<'a>,
26462646
) {
2647-
// NOTE: AstKind doesn't exists!
2647+
// No `AstKind` for this type
26482648
visitor.visit_span(&it.span);
26492649
visitor.visit_ts_type(&it.type_annotation);
26502650
}
26512651

26522652
#[inline]
26532653
pub fn walk_js_doc_unknown_type<'a, V: Visit<'a>>(visitor: &mut V, it: &JSDocUnknownType) {
2654-
// NOTE: AstKind doesn't exists!
2654+
// No `AstKind` for this type
26552655
visitor.visit_span(&it.span);
26562656
}
26572657

@@ -2802,7 +2802,7 @@ pub mod walk {
28022802
visitor: &mut V,
28032803
it: &ComputedMemberExpression<'a>,
28042804
) {
2805-
// NOTE: AstKind doesn't exists!
2805+
// No `AstKind` for this type
28062806
visitor.visit_span(&it.span);
28072807
visitor.visit_expression(&it.object);
28082808
visitor.visit_expression(&it.expression);
@@ -2813,7 +2813,7 @@ pub mod walk {
28132813
visitor: &mut V,
28142814
it: &StaticMemberExpression<'a>,
28152815
) {
2816-
// NOTE: AstKind doesn't exists!
2816+
// No `AstKind` for this type
28172817
visitor.visit_span(&it.span);
28182818
visitor.visit_expression(&it.object);
28192819
visitor.visit_identifier_name(&it.property);
@@ -2824,7 +2824,7 @@ pub mod walk {
28242824
visitor: &mut V,
28252825
it: &PrivateFieldExpression<'a>,
28262826
) {
2827-
// NOTE: AstKind doesn't exists!
2827+
// No `AstKind` for this type
28282828
visitor.visit_span(&it.span);
28292829
visitor.visit_expression(&it.object);
28302830
visitor.visit_private_identifier(&it.field);
@@ -2901,7 +2901,7 @@ pub mod walk {
29012901
visitor: &mut V,
29022902
it: &AssignmentTargetRest<'a>,
29032903
) {
2904-
// NOTE: AstKind doesn't exists!
2904+
// No `AstKind` for this type
29052905
visitor.visit_span(&it.span);
29062906
visitor.visit_assignment_target(&it.target);
29072907
}
@@ -2951,7 +2951,7 @@ pub mod walk {
29512951
visitor: &mut V,
29522952
it: &AssignmentTargetPropertyIdentifier<'a>,
29532953
) {
2954-
// NOTE: AstKind doesn't exists!
2954+
// No `AstKind` for this type
29552955
visitor.visit_span(&it.span);
29562956
visitor.visit_identifier_reference(&it.binding);
29572957
if let Some(init) = &it.init {
@@ -2964,7 +2964,7 @@ pub mod walk {
29642964
visitor: &mut V,
29652965
it: &AssignmentTargetPropertyProperty<'a>,
29662966
) {
2967-
// NOTE: AstKind doesn't exists!
2967+
// No `AstKind` for this type
29682968
visitor.visit_span(&it.span);
29692969
visitor.visit_property_key(&it.name);
29702970
visitor.visit_assignment_target_maybe_default(&it.binding);
@@ -3200,7 +3200,7 @@ pub mod walk {
32003200

32013201
#[inline]
32023202
pub fn walk_accessor_property<'a, V: Visit<'a>>(visitor: &mut V, it: &AccessorProperty<'a>) {
3203-
// NOTE: AstKind doesn't exists!
3203+
// No `AstKind` for this type
32043204
visitor.visit_span(&it.span);
32053205
visitor.visit_decorators(&it.decorators);
32063206
visitor.visit_property_key(&it.key);
@@ -3496,7 +3496,7 @@ pub mod walk {
34963496

34973497
#[inline]
34983498
pub fn walk_jsx_attribute<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXAttribute<'a>) {
3499-
// NOTE: AstKind doesn't exists!
3499+
// No `AstKind` for this type
35003500
visitor.visit_span(&it.span);
35013501
visitor.visit_jsx_attribute_name(&it.name);
35023502
if let Some(value) = &it.value {
@@ -3546,7 +3546,7 @@ pub mod walk {
35463546

35473547
#[inline]
35483548
pub fn walk_jsx_empty_expression<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXEmptyExpression) {
3549-
// NOTE: AstKind doesn't exists!
3549+
// No `AstKind` for this type
35503550
visitor.visit_span(&it.span);
35513551
}
35523552

@@ -3587,7 +3587,7 @@ pub mod walk {
35873587

35883588
#[inline]
35893589
pub fn walk_jsx_spread_child<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXSpreadChild<'a>) {
3590-
// NOTE: AstKind doesn't exists!
3590+
// No `AstKind` for this type
35913591
visitor.visit_span(&it.span);
35923592
visitor.visit_expression(&it.expression);
35933593
}
@@ -3953,7 +3953,7 @@ pub mod walk {
39533953

39543954
#[inline]
39553955
pub fn walk_ts_interface_body<'a, V: Visit<'a>>(visitor: &mut V, it: &TSInterfaceBody<'a>) {
3956-
// NOTE: AstKind doesn't exists!
3956+
// No `AstKind` for this type
39573957
visitor.visit_span(&it.span);
39583958
visitor.visit_ts_signatures(&it.body);
39593959
}
@@ -4203,7 +4203,7 @@ pub mod walk {
42034203

42044204
#[inline]
42054205
pub fn walk_with_clause<'a, V: Visit<'a>>(visitor: &mut V, it: &WithClause<'a>) {
4206-
// NOTE: AstKind doesn't exists!
4206+
// No `AstKind` for this type
42074207
visitor.visit_span(&it.span);
42084208
visitor.visit_identifier_name(&it.attributes_keyword);
42094209
visitor.visit_import_attributes(&it.with_entries);
@@ -4221,7 +4221,7 @@ pub mod walk {
42214221

42224222
#[inline]
42234223
pub fn walk_import_attribute<'a, V: Visit<'a>>(visitor: &mut V, it: &ImportAttribute<'a>) {
4224-
// NOTE: AstKind doesn't exists!
4224+
// No `AstKind` for this type
42254225
visitor.visit_span(&it.span);
42264226
visitor.visit_import_attribute_key(&it.key);
42274227
visitor.visit_string_literal(&it.value);
@@ -4347,7 +4347,7 @@ pub mod walk {
43474347
visitor: &mut V,
43484348
it: &TSNamespaceExportDeclaration<'a>,
43494349
) {
4350-
// NOTE: AstKind doesn't exists!
4350+
// No `AstKind` for this type
43514351
visitor.visit_span(&it.span);
43524352
visitor.visit_identifier_name(&it.id);
43534353
}

0 commit comments

Comments
 (0)