Add trailing space around readlines (astral-sh#18542)

Closes astral-sh#17683.

Author: charliermarsh

crates/ruff_linter/resources/test/fixtures/refurb/FURB129.py

@@ -102,3 +102,8 @@ def readlines(self) -> list[str]:
         pass
     for line in(f).readlines():
         pass
+    # Test case for issue #17683 - missing space before keyword
+    print([line for line in f.readlines()if True])
+    print([line for line in f.readlines()and True])
+    print([line for line in f.readlines()or True])
+    print([line for line in f.readlines()in ["test"]])

crates/ruff_linter/src/rules/refurb/rules/readlines_in_for.rs

@@ -6,6 +6,7 @@ use ruff_python_semantic::analyze::typing::is_io_base_expr;
 use ruff_text_size::Ranged;
 
 use crate::checkers::ast::Checker;
+use crate::fix::edits::pad_end;
 use crate::preview::is_readlines_in_for_fix_safe_enabled;
 use crate::{AlwaysFixableViolation, Edit, Fix};
 
@@ -91,9 +92,21 @@ fn readlines_in_iter(checker: &Checker, iter_expr: &Expr) {
         checker.comment_ranges(),
         checker.source(),
     ) {
-        Edit::range_deletion(expr_call.range().add_start(parenthesized_range.len()))
+        let deletion_range = expr_call.range().add_start(parenthesized_range.len());
+        let padded = pad_end(String::new(), deletion_range.end(), checker.locator());
+        if padded.is_empty() {
+            Edit::range_deletion(deletion_range)
+        } else {
+            Edit::range_replacement(padded, deletion_range)
+        }
     } else {
-        Edit::range_deletion(expr_call.range().add_start(expr_attr.value.range().len()))
+        let deletion_range = expr_call.range().add_start(expr_attr.value.range().len());
+        let padded = pad_end(String::new(), deletion_range.end(), checker.locator());
+        if padded.is_empty() {
+            Edit::range_deletion(deletion_range)
+        } else {
+            Edit::range_replacement(padded, deletion_range)
+        }
     };
 
     let mut diagnostic = checker.report_diagnostic(ReadlinesInFor, expr_call.range());

crates/ruff_linter/src/rules/refurb/snapshots/ruff_linter__rules__refurb__tests__FURB129_FURB129.py.snap

@@ -307,6 +307,7 @@ FURB129.py:103:16: FURB129 [*] Instead of calling `readlines()`, iterate over fi
 103 |     for line in(f).readlines():
     |                ^^^^^^^^^^^^^^^ FURB129
 104 |         pass
+105 |     # Test case for issue #17683 - missing space before keyword
     |
     = help: Remove `readlines()`
 
@@ -317,3 +318,26 @@ FURB129.py:103:16: FURB129 [*] Instead of calling `readlines()`, iterate over fi
 103     |-    for line in(f).readlines():
     103 |+    for line in(f):
 104 104 |         pass
+105 105 |     # Test case for issue #17683 - missing space before keyword
+106 106 |     print([line for line in f.readlines()if True])
+
+FURB129.py:106:29: FURB129 [*] Instead of calling `readlines()`, iterate over file object directly
+    |
+104 |         pass
+105 |     # Test case for issue #17683 - missing space before keyword
+106 |     print([line for line in f.readlines()if True])
+    |                             ^^^^^^^^^^^^^ FURB129
+107 |     print([line for line in f.readlines()and True])
+108 |     print([line for line in f.readlines()or True])
+    |
+    = help: Remove `readlines()`
+
+ℹ Unsafe fix
+103 103 |     for line in(f).readlines():
+104 104 |         pass
+105 105 |     # Test case for issue #17683 - missing space before keyword
+106     |-    print([line for line in f.readlines()if True])
+    106 |+    print([line for line in f if True])
+107 107 |     print([line for line in f.readlines()and True])
+108 108 |     print([line for line in f.readlines()or True])
+109 109 |     print([line for line in f.readlines()in ["test"]])

crates/ruff_linter/src/rules/refurb/snapshots/ruff_linter__rules__refurb__tests__preview__FURB129_FURB129.py.snap

@@ -307,6 +307,7 @@ FURB129.py:103:16: FURB129 [*] Instead of calling `readlines()`, iterate over fi
 103 |     for line in(f).readlines():
     |                ^^^^^^^^^^^^^^^ FURB129
 104 |         pass
+105 |     # Test case for issue #17683 - missing space before keyword
     |
     = help: Remove `readlines()`
 
@@ -317,3 +318,26 @@ FURB129.py:103:16: FURB129 [*] Instead of calling `readlines()`, iterate over fi
 103     |-    for line in(f).readlines():
     103 |+    for line in(f):
 104 104 |         pass
+105 105 |     # Test case for issue #17683 - missing space before keyword
+106 106 |     print([line for line in f.readlines()if True])
+
+FURB129.py:106:29: FURB129 [*] Instead of calling `readlines()`, iterate over file object directly
+    |
+104 |         pass
+105 |     # Test case for issue #17683 - missing space before keyword
+106 |     print([line for line in f.readlines()if True])
+    |                             ^^^^^^^^^^^^^ FURB129
+107 |     print([line for line in f.readlines()and True])
+108 |     print([line for line in f.readlines()or True])
+    |
+    = help: Remove `readlines()`
+
+ℹ Safe fix
+103 103 |     for line in(f).readlines():
+104 104 |         pass
+105 105 |     # Test case for issue #17683 - missing space before keyword
+106     |-    print([line for line in f.readlines()if True])
+    106 |+    print([line for line in f if True])
+107 107 |     print([line for line in f.readlines()and True])
+108 108 |     print([line for line in f.readlines()or True])
+109 109 |     print([line for line in f.readlines()in ["test"]])