Skip to content

Commit 98438a7

Browse files
authored
Don't install Rust before running pre-commit in CI (astral-sh#17050)
Following astral-sh@29573da, it doesn't look to me like any of the pre-commit hooks run in CI here are Rust-based: - `cargo fmt` is Rust-based but it's explicitly skipped as part of this job and run as a separate CI job: https://github.com/astral-sh/ruff/blob/93052331b07e8cbc84660340019db4f582fb4ad1/.pre-commit-config.yaml#L124-L125 - The `typos` hook is Rust-based, but according to https://github.com/crate-ci/typos/blob/master/docs/pre-commit.md pre-commit should install a built binary rather than building the binary from source As such, I think this step in the workflow is just taking up 15s of CI time and not actually speeding up pre-commit at all
1 parent 9305233 commit 98438a7

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -651,9 +651,6 @@ jobs:
651651
- uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5
652652
with:
653653
python-version: ${{ env.PYTHON_VERSION }}
654-
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2
655-
- name: "Install Rust toolchain"
656-
run: rustup show
657654
- name: "Install pre-commit"
658655
run: pip install pre-commit
659656
- name: "Cache pre-commit"

0 commit comments

Comments
 (0)