fix: more tool cache fixes

Signed-off-by: Sam Gammon <[email protected]>

Author: sgammon

src/main.ts

@@ -108,10 +108,10 @@ export async function run(
       ? buildOptions(options)
       : buildOptions({
           version: stringOption(OptionName.VERSION, 'latest'),
-          target: stringOption(
-            OptionName.TARGET,
+          install_path: stringOption(
+            OptionName.INSTALL_PATH,
             /* istanbul ignore next */
-            process.env.ELIDE_HOME || defaults.target
+            process.env.ELIDE_HOME || defaults.install_path
           ),
           os: normalizeOs(
             stringOption(OptionName.OS, process.platform) as string

src/options.ts

@@ -12,7 +12,7 @@ export enum OptionName {
   CUSTOM_URL = 'custom_url',
   VERSION_TAG = 'version_tag',
   TOKEN = 'token',
-  TARGET = 'target',
+  INSTALL_PATH = 'install_path',
   FORCE = 'force'
 }
 
@@ -33,8 +33,8 @@ export interface ElideSetupActionOptions {
   // Desired arch for the downloaded binary. If not provided, the current arch is resolved.
   arch: 'amd64' | 'aarch64'
 
-  // Directory path where Elide should be installed; if none is provided, `~/elide` is used.
-  target: string
+  // Directory path where Elide should be installed; if none is provided, conventional location is used for GHA.
+  install_path: string
 
   // Whether to disable tool and action caching.
   no_cache: boolean
@@ -71,7 +71,7 @@ export const nixDefaultPath = path.resolve(os.homedir(), 'elide')
 export const configPath = path.resolve(os.homedir(), '.elide')
 
 /* istanbul ignore next */
-const defaultTarget =
+const defaultTargetPath =
   process.platform === 'win32' ? windowsDefaultPath : nixDefaultPath
 
 /**
@@ -85,7 +85,7 @@ export const defaults: ElideSetupActionOptions = {
   prewarm: true,
   os: normalizeOs(process.platform),
   arch: normalizeArch(process.arch),
-  target: defaultTarget
+  install_path: defaultTargetPath
 }
 
 /**

src/releases.ts

@@ -284,19 +284,21 @@ async function maybeDownload(
 ): Promise<ElideRelease> {
   // build download URL, use result from cache or disk
   const { url, archiveType } = await buildDownloadUrl(options, version)
-  core.info(`Installing from URL: ${url} (type: ${archiveType})`)
+  let targetBin = `${options.install_path}/elide`
 
-  let targetBin = `${options.target}/elide`
+  if (options.no_cache === true) {
+    console.info('Tool caching is disabled.')
+  }
 
   /* istanbul ignore next */
   if (options.os === ElideOS.WINDOWS) {
-    targetBin = `${options.target}\\elide.exe`
+    targetBin = `${options.install_path}\\elide.exe`
   }
 
   // build resulting tarball path and resolved tool info
   let elidePath: string = targetBin
   /* istanbul ignore next */
-  let elideHome: string = process.env.ELIDE_HOME || options.target
+  let elideHome: string = process.env.ELIDE_HOME || options.install_path
   let elidePathTarget = elideHome
   const elideBin: string = elideHome // @TODO(sgammon): bin folder?
   let elideDir: string | null = null
@@ -315,6 +317,7 @@ async function maybeDownload(
     // we have an existing cached copy of elide
     core.debug('Caching enabled and cached Elide release found; using it')
     elidePath = elideDir
+    core.info(`Using cached copy of Elide at version ${version.tag_name}`)
   } else {
     /* istanbul ignore next */
     if (options.no_cache) {
@@ -325,6 +328,8 @@ async function maybeDownload(
       core.debug('Cache enabled but no hit was found; downloading release')
     }
 
+    core.info(`Installing from URL: ${url} (type: ${archiveType})`)
+
     // we do not have an existing copy; download it
     let elideArchive: string | null = null
     try {
@@ -339,6 +344,7 @@ async function maybeDownload(
     }
 
     core.debug(`Elide release downloaded to: ${elideArchive}`)
+
     elideHome = await unpackRelease(
       elideArchive,
       elideHome,
@@ -400,7 +406,7 @@ export async function downloadRelease(
       }
 
       /* istanbul ignore next */
-      let elideHome: string = process.env.ELIDE_HOME || options.target
+      let elideHome: string = process.env.ELIDE_HOME || options.install_path
       elideHome = await unpackRelease(
         customArchive,
         elideHome,