Skip to content

Commit f80ce23

Browse files
committed
đź”§ Update CI workflow to use 'go build .' and fix errcheck linting issues by properly handling ignored error returns
1 parent cac1cf1 commit f80ce23

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464

6565
- name: Build binary
6666
working-directory: ./sidekick
67-
run: go build -v -o sidekick main.go processes.go notifications.go
67+
run: go build -v -o sidekick .
6868

6969
- name: Upload coverage to Codecov
7070
if: matrix.os == 'ubuntu-latest'

‎sidekick/main.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ func handleGracefulShutdown() {
198198
err := terminateProcessGroup(tracker.Process.Process.Pid)
199199
if err != nil {
200200
// If platform-specific termination fails, use standard process.Kill()
201-
tracker.Process.Process.Kill()
201+
_ = tracker.Process.Process.Kill()
202202
}
203203
}
204204
tracker.Mutex.RUnlock()
@@ -239,7 +239,7 @@ func handleGracefulShutdown() {
239239
err := forceKillProcessGroup(tracker.Process.Process.Pid)
240240
if err != nil {
241241
// If platform-specific force kill fails, use standard process.Kill()
242-
tracker.Process.Process.Kill()
242+
_ = tracker.Process.Process.Kill()
243243
}
244244
}
245245
tracker.Mutex.RUnlock()

‎sidekick/notifications.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ func handleSpeak(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToo
2828

2929
// 🔊 Play system sound asynchronously
3030
go func() {
31-
exec.Command("afplay", "/System/Library/Sounds/Glass.aiff", "-v", "5").Run()
31+
_ = exec.Command("afplay", "/System/Library/Sounds/Glass.aiff", "-v", "5").Run()
3232
}()
3333

3434
// 🗣️ Speak the text after a short delay
3535
go func() {
3636
time.Sleep(500 * time.Millisecond)
37-
exec.Command("say", "-v", "Zoe (Premium)", text).Run()
37+
_ = exec.Command("say", "-v", "Zoe (Premium)", text).Run()
3838
}()
3939

4040
return mcp.NewToolResultText("Notification spoken!"), nil

‎sidekick/processes.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ func handleSpawnProcess(ctx context.Context, request mcp.CallToolRequest) (*mcp.
576576
// Start background goroutine to wait and then execute
577577
go func() {
578578
time.Sleep(delay)
579-
executeDelayedProcess(context.Background(), tracker, envVars)
579+
_ = executeDelayedProcess(context.Background(), tracker, envVars)
580580
}()
581581

582582
result = map[string]any{

0 commit comments

Comments
 (0)