Reduce IDE noise by refactoring how command line arguments are accessed

Giorgio Sironi · Giorgio Sironi · commit 4968d53984f1 · 2025-02-07T15:06:32.000Z
https://github.com/elifesciences/issues/issues/9169
diff --git a/test/SilexTestCase.php b/test/SilexTestCase.php
@@ -25,14 +25,15 @@ final protected function getApp() : Application
      */
     final public function it_returns_valid_responses(Request $request, $contentType, int $statusCode = 200, $warning = [], int $expectedCount = null)
     {
+        global $argv;
         $response = $this->getApp()->handle($request);
 
-        if (in_array('--debug', $_SERVER['argv'], true) && 500 === $response->getStatusCode()) {
+        if (in_array('--debug', $argv, true) && 500 === $response->getStatusCode()) {
             $json = json_decode($response->getContent(), true);
             if (isset($json['exception'])) {
                 $this->fail($json['exception']);
             }
-            $this->fail($json);
+            $this->fail('A 500 response was returned with: '.$response->getContent());
         }
 
         if (is_int($expectedCount)) {

Original file line number	Diff line number	Diff line change
`@@ -25,14 +25,15 @@ final protected function getApp() : Application`
`25`	`25`	`*/`
`26`	`26`	`final public function it_returns_valid_responses(Request $request, $contentType, int $statusCode = 200, $warning = [], int $expectedCount = null)`
`27`	`27`	`{`
	`28`	`+ global $argv;`
`28`	`29`	`$response = $this->getApp()->handle($request);`
`29`	`30`
`30`		`- if (in_array('--debug', $_SERVER['argv'], true) && 500 === $response->getStatusCode()) {`
	`31`	`+ if (in_array('--debug', $argv, true) && 500 === $response->getStatusCode()) {`
`31`	`32`	`$json = json_decode($response->getContent(), true);`
`32`	`33`	`if (isset($json['exception'])) {`
`33`	`34`	`$this->fail($json['exception']);`
`34`	`35`	`}`
`35`		`- $this->fail($json);`
	`36`	`+ $this->fail('A 500 response was returned with: '.$response->getContent());`
`36`	`37`	`}`
`37`	`38`
`38`	`39`	`if (is_int($expectedCount)) {`