Added test_should_return_none_for_invalid_evaluation_id

Author: de-code

data_hub_api/docmaps/v2/provider.py

@@ -89,4 +89,5 @@ def iter_docmaps_index_json_stream(self):
         LOGGER.info('Finished streaming docmaps index as JSON.')
 
     def get_evaluation_content_by_id(self, evaluation_id: str) -> Optional[str]:
-        return 'dummy evaluation content for evaluation_id: ' + evaluation_id
+        LOGGER.debug('Getting evaluation content for evaluation_id: %s', evaluation_id)
+        return None

tests/unit_tests/docmaps/v2/provider_test.py

@@ -55,3 +55,11 @@ def test_should_cache_docmaps_query_results(
         assert docmaps_index['docmaps'] == [
             get_docmap_item_for_query_result_item(cast(ApiInput, DOCMAPS_QUERY_RESULT_ITEM_1))
         ]
+
+    def test_should_return_none_for_invalid_evaluation_id(
+        self,
+        iter_dict_from_bq_query_mock: MagicMock
+    ):
+        iter_dict_from_bq_query_mock.return_value = []
+        docmaps_provider = DocmapsProvider()
+        assert docmaps_provider.get_evaluation_content_by_id('not_found_id_1') is None