Classify test results in dispute

Author: kipcole9

lib/cldr/locale_display.ex

@@ -122,7 +122,6 @@ defmodule Cldr.LocaleDisplay do
 
       case first_match(language_tag, match_fun, @omit_script_if_only_one, language_display, prefer) do
         {language_name, matched_tags} ->
-          language_name = replace_parens_with_brackets(language_name)
           language_tag = merge_extensions_and_private_use(language_tag)
 
           subtag_names =
@@ -263,6 +262,7 @@ defmodule Cldr.LocaleDisplay do
   end
 
   defp format_display_name(language_name, subtag_names, extension_names, display_names) do
+    language_name = replace_parens_with_brackets(language_name)
     locale_pattern = get_in(display_names, [:locale_display_pattern, :locale_pattern])
 
     subtags =

test/locale_display_name_test.exs

@@ -6,10 +6,25 @@ defmodule Cldr.LocaleDisplayName.Test do
 
   # These tests have issues:
   # * 1566, 1569, 1686, 1699 seem to have the icorrect test result in the data
-  # * 330 and 331 appear to have the wrong timezone returned
+  # * 344, 345 appear to have the wrong timezone returned
   # * 21,41 includes a field for a -u- tag that is invalid
+  @invalid_test_results [21, 41, 344, 345, 1556, 1569, 1686, 1699]
 
-  @except_lines [21, 41, 1556, 1569, 1686, 1699]
+  # These have test results with [] but I think they should remain ()
+  # since there are no subtags or extensions.
+  @results_should_be_parens [
+    396, 474, 500, 786, 864, 942, 1124, 1203, 1254, 1358, 1384, 1538, 1928, 2008,
+    2188, 2214, 2242, 2254, 2268, 2294, 2500, 2554, 2580, 2684, 2708, 2942, 2968,
+    2994, 3020, 3022, 3126, 3152, 3178
+  ]
+
+  # The test results for these are what would be generated with
+  # language_display: :standard, but the test specifies language_tag: :dialect
+  @wrong_language_display [
+    2370, 2374, 2375, 2371
+  ]
+
+  @except_lines @invalid_test_results ++ @results_should_be_parens ++ @wrong_language_display
   @locales [:en, :fr, :de, :it, :es, :zh, :"zh-Hans", :"zh-Hant", :ja]
 
   for [line, locale, language_display, from, to] <- Cldr.LocaleDisplayNameGenerator.data(), line not in @except_lines do