Allow virtual embeds

Author: v0idpwn

lib/ecto/embedded.ex

@@ -28,6 +28,7 @@ defmodule Ecto.Embedded do
     :owner,
     :related,
     :on_cast,
+    virtual: false,
     on_replace: :raise,
     unique: true,
     ordered: true
@@ -149,7 +150,11 @@ defmodule Ecto.Embedded do
   @doc false
   def prepare(changeset, embeds, adapter, repo_action) do
     %{changes: changes, types: types, repo: repo} = changeset
-    prepare(Map.take(changes, embeds), types, adapter, repo, repo_action)
+    #non_virtual_embeds = Enum.reject(embeds, & &1.virtual)
+
+    changes
+    |> Map.take(embeds)
+    |> prepare(types, adapter, repo, repo_action)
   end
 
   defp prepare(embeds, _types, _adapter, _repo, _repo_action) when embeds == %{} do
@@ -158,9 +163,15 @@ defmodule Ecto.Embedded do
 
   defp prepare(embeds, types, adapter, repo, repo_action) do
     Enum.reduce(embeds, embeds, fn {name, changeset_or_changesets}, acc ->
-      {:embed, embed} = Map.get(types, name)
-      Map.put(acc, name, prepare_each(embed, changeset_or_changesets, adapter, repo, repo_action))
-    end)
+      case Map.get(types, name) do
+        {:embed, %{virtual: false} = embed} ->
+          prepared = prepare_each(embed, changeset_or_changesets, adapter, repo, repo_action)
+          Map.put(acc, name, prepared)
+
+        {:embed, %{virtual: true}} ->
+          acc
+      end)
+    end
   end
 
   defp prepare_each(%{cardinality: :one}, nil, _adapter, _repo, _repo_action) do

lib/ecto/schema.ex

@@ -2143,7 +2143,7 @@ defmodule Ecto.Schema do
     Module.put_attribute(mod, :ecto_changeset_fields, {name, {:assoc, struct}})
   end
 
-  @valid_embeds_one_options [:on_replace, :source, :load_in_query, :defaults_to_struct]
+  @valid_embeds_one_options [:on_replace, :source, :load_in_query, :defaults_to_struct, :virtual]
 
   @doc false
   def __embeds_one__(mod, name, schema, opts) when is_atom(schema) do
@@ -2164,7 +2164,7 @@ defmodule Ecto.Schema do
           "`embeds_one/3` expects `schema` to be a module name, but received #{inspect(schema)}"
   end
 
-  @valid_embeds_many_options [:on_replace, :source, :load_in_query]
+  @valid_embeds_many_options [:on_replace, :source, :load_in_query, :virtual]
 
   @doc false
   def __embeds_many__(mod, name, schema, opts) when is_atom(schema) do

test/ecto/embedded_test.exs

@@ -19,6 +19,7 @@ defmodule Ecto.EmbeddedTest do
       field :name, :string
       embeds_one :profile, Profile, on_replace: :delete
       embeds_one :post, Post
+      embeds_one :virtual_post, Post, virtual: true
       embeds_many :posts, Post, on_replace: :delete
     end
   end
@@ -45,7 +46,7 @@ defmodule Ecto.EmbeddedTest do
 
   test "__schema__" do
     assert Author.__schema__(:embeds) ==
-      [:profile, :post, :posts]
+      [:profile, :post, :virtual_post, :posts]
 
     assert Author.__schema__(:embed, :profile) ==
       %Embedded{field: :profile, cardinality: :one, owner: Author, on_replace: :delete, related: Profile}

test/ecto/repo_test.exs

@@ -160,6 +160,15 @@ defmodule Ecto.RepoTest do
     end
   end
 
+  defmodule MySchemaVirtualEmbed do
+    use Ecto.Schema
+
+    schema "my_schema" do
+      field :x, :string
+      embeds_one :virtual_embed, MyEmbed, virtual: true
+    end
+  end
+
   defmodule MySchemaNoPK do
     use Ecto.Schema