review comment from ecto

Author: greg-rychlewski

lib/ecto/adapters/myxql/connection.ex

@@ -746,10 +746,6 @@ if Code.ensure_loaded?(MyXQL) do
       [?(, values_list(types, num_rows, query), ?)]
     end
 
-    defp expr({:literal, _, [literal]}, _sources, _query) do
-      quote_name(literal)
-    end
-
     defp expr({:identifier, _, [literal]}, _sources, _query) do
       quote_name(literal)
     end

lib/ecto/adapters/postgres/connection.ex

@@ -987,10 +987,6 @@ if Code.ensure_loaded?(Postgrex) do
       [?(, values_list(types, idx + 1, num_rows), ?)]
     end
 
-    defp expr({:literal, _, [literal]}, _sources, _query) do
-      quote_name(literal)
-    end
-
     defp expr({:identifier, _, [literal]}, _sources, _query) do
       quote_name(literal)
     end

lib/ecto/adapters/tds/connection.ex

@@ -826,10 +826,6 @@ if Code.ensure_loaded?(Tds) do
       [?(, values_list(types, idx + 1, num_rows), ?)]
     end
 
-    defp expr({:literal, _, [literal]}, _sources, _query) do
-      quote_name(literal)
-    end
-
     defp expr({:identifier, _, [literal]}, _sources, _query) do
       quote_name(literal)
     end

test/ecto/adapters/myxql_test.exs

@@ -655,9 +655,6 @@ defmodule Ecto.Adapters.MyXQLTest do
     query = Schema |> select([r], r.x) |> where([], fragment("? = \"query\\?\"", ^10)) |> plan()
     assert all(query) == ~s{SELECT s0.`x` FROM `schema` AS s0 WHERE (? = \"query?\")}
 
-    query = Schema |> select([r], fragment("? COLLATE ?", r.x, literal(^"es_ES"))) |> plan()
-    assert all(query) == ~s{SELECT s0.`x` COLLATE `es_ES` FROM `schema` AS s0}
-
     query = Schema |> select([r], fragment("? COLLATE ?", r.x, identifier(^"es_ES"))) |> plan()
     assert all(query) == ~s{SELECT s0.`x` COLLATE `es_ES` FROM `schema` AS s0}
 

test/ecto/adapters/postgres_test.exs

@@ -835,9 +835,6 @@ defmodule Ecto.Adapters.PostgresTest do
     query = Schema |> select([r], fragment("downcase(?)", r.x)) |> plan()
     assert all(query) == ~s{SELECT downcase(s0."x") FROM "schema" AS s0}
 
-    query = Schema |> select([r], fragment("? COLLATE ?", r.x, literal(^"es_ES"))) |> plan()
-    assert all(query) == ~s{SELECT s0."x" COLLATE "es_ES" FROM "schema" AS s0}
-
     query = Schema |> select([r], fragment("? COLLATE ?", r.x, identifier(^"es_ES"))) |> plan()
     assert all(query) == ~s{SELECT s0."x" COLLATE "es_ES" FROM "schema" AS s0}
 

test/ecto/adapters/tds_test.exs

@@ -691,9 +691,6 @@ defmodule Ecto.Adapters.TdsTest do
     query = Schema |> select([r], fragment("lower(?)", r.x)) |> plan()
     assert all(query) == ~s{SELECT lower(s0.[x]) FROM [schema] AS s0}
 
-    query = Schema |> select([r], fragment("? COLLATE ?", r.x, literal(^"es_ES"))) |> plan()
-    assert all(query) == ~s{SELECT s0.[x] COLLATE [es_ES] FROM [schema] AS s0}
-
     query = Schema |> select([r], fragment("? COLLATE ?", r.x, identifier(^"es_ES"))) |> plan()
     assert all(query) == ~s{SELECT s0.[x] COLLATE [es_ES] FROM [schema] AS s0}