allow string names in field/2

Author: greg-rychlewski

lib/ecto/adapters/myxql/connection.ex

@@ -671,14 +671,14 @@ if Code.ensure_loaded?(MyXQL) do
     end
 
     defp expr({{:., _, [{:parent_as, _, [as]}, field]}, _, []}, _sources, query)
-         when is_atom(field) do
+         when is_atom(field) or is_binary(field) do
       {ix, sources} = get_parent_sources_ix(query, as)
       {_, name, _} = elem(sources, ix)
       [name, ?. | quote_name(field)]
     end
 
     defp expr({{:., _, [{:&, _, [idx]}, field]}, _, []}, sources, _query)
-         when is_atom(field) do
+         when is_atom(field) or is_binary(field) do
       {_, name, _} = elem(sources, idx)
       [name, ?. | quote_name(field)]
     end

lib/ecto/adapters/postgres/connection.ex

@@ -916,12 +916,13 @@ if Code.ensure_loaded?(Postgrex) do
     end
 
     defp expr({{:., _, [{:parent_as, _, [as]}, field]}, _, []}, _sources, query)
-         when is_atom(field) do
+         when is_atom(field) or is_binary(field) do
       {ix, sources} = get_parent_sources_ix(query, as)
       quote_qualified_name(field, sources, ix)
     end
 
-    defp expr({{:., _, [{:&, _, [idx]}, field]}, _, []}, sources, _query) when is_atom(field) do
+    defp expr({{:., _, [{:&, _, [idx]}, field]}, _, []}, sources, _query)
+         when is_atom(field) or is_binary(field) do
       quote_qualified_name(field, sources, idx)
     end
 

lib/ecto/adapters/tds/connection.ex

@@ -733,7 +733,7 @@ if Code.ensure_loaded?(Tds) do
     end
 
     defp expr({{:., _, [{:parent_as, _, [as]}, field]}, _, []}, _sources, query)
-         when is_atom(field) do
+         when is_atom(field) or is_binary(field) do
       {ix, sources} = get_parent_sources_ix(query, as)
       {_, name, _} = elem(sources, ix)
       [name, ?. | quote_name(field)]

mix.exs

@@ -76,7 +76,7 @@ defmodule EctoSQL.MixProject do
     if path = System.get_env("ECTO_PATH") do
       {:ecto, path: path}
     else
-      {:ecto, "~> 3.12"}
+      {:ecto, git: "https://github.com/greg-rychlewski/ecto.git", branch: "string_field_name"}
     end
   end
 

test/ecto/adapters/myxql_test.exs

@@ -1627,6 +1627,14 @@ defmodule Ecto.Adapters.MyXQLTest do
     end)
   end
 
+  test "field/2 with string name" do
+    query = from(s in "schema", select: field(s, "x")) |> plan(:all) |> all()
+    assert query == ~s{SELECT s0.`x` FROM `schema` AS s0}
+
+    query = from(s in "schema", as: :schema, select: field(as(:schema), "x")) |> plan(:all) |> all()
+    assert query == ~s{SELECT s0.`x` FROM `schema` AS s0}
+  end
+
   # DDL
 
   import Ecto.Migration,

test/ecto/adapters/postgres_test.exs

@@ -2033,6 +2033,14 @@ defmodule Ecto.Adapters.PostgresTest do
     end)
   end
 
+  test "field/2 with string name" do
+    query = from(s in "schema", select: field(s, "x")) |> plan(:all) |> all()
+    assert query == ~s{SELECT s0."x" FROM "schema" AS s0}
+
+    query = from(s in "schema", as: :schema, select: field(as(:schema), "x")) |> plan(:all) |> all()
+    assert query == ~s{SELECT s0."x" FROM "schema" AS s0}
+  end
+
   # DDL
 
   alias Ecto.Migration.Reference

test/ecto/adapters/tds_test.exs

@@ -1397,6 +1397,14 @@ defmodule Ecto.Adapters.TdsTest do
     end)
   end
 
+  test "field/2 with string name" do
+    query = from(s in "schema", select: field(s, "x")) |> plan(:all) |> all()
+    assert query == ~s{SELECT s0.[x] FROM [schema] AS s0}
+
+    query = from(s in "schema", as: :schema, select: field(as(:schema), "x")) |> plan(:all) |> all()
+    assert query == ~s{SELECT s0.[x] FROM [schema] AS s0}
+  end
+
   ## DDL
 
   import Ecto.Migration,