todo: floats are losing precision, need to be fixed, issue is when 8byte long floats need to be stored in sql

Author: mjaric

lib/tds/types.ex

@@ -1022,11 +1022,11 @@ defmodule Tds.Types do
           String.length(p)
       end
     if precision <= 7 + 1 do
-      <<0x04, value::little-float-size(32)>>
+      <<0x04, value::little-float-32>>
     else
       # up to 15 digits of precision https://docs.microsoft.com/en-us/sql/t-sql/data-types/float-and-real-transact-sql
-      <<0x08, value::little-float-size(64)>>
-    end
+      <<0x08, value::little-float-64>>      
+    end  
   end
 
   @doc """

lib/tds/utils.ex

@@ -1,6 +1,5 @@
 defmodule Tds.Utils do
   require Logger
-  #alias Tds.Connection
 
   def to_hex_list(x) when is_list(x) do
     Enum.map x, &( Base.encode16(<<&1>>))
@@ -58,43 +57,8 @@ defmodule Tds.Utils do
     end
   end
 
-
   def reply(reply, {_, _} = from) do
     GenServer.reply(from, reply)
     true
   end
-
-#  Connection.next is undefined
- # def ready(%{queue: queue} = s) do
- #   queue =
- #     case :queue.out(queue) do
- #     {{:value, {_, _, ref}}, q} ->
- #       Process.demonitor(ref)
- #       q
- #     {:empty, q} ->
- #       q
- #   end
- #   Connection.next(%{s | statement: "", queue: queue, state: :ready})
- # end
-
-  # def pow10(num,0), do: num
-  # def pow10(num,pow) when pow > 0 do
-  #   pow10(10*num, pow - 1)
-  # end
-
-  # def pow10(num,pow) when pow < 0 do
-  #   pow10(num/10, pow + 1)
-  # end
-
-  # def pow(_, 0), do: 1
-  # def pow(a, 1), do: a
-
-  # def pow(a, n) when rem(n, 2) === 0 do
-  #   tmp = pow(a, div(n, 2))
-  #   tmp * tmp
-  # end
-
-  # def pow(a, n) do
-  #   a * pow(a, n-1)
-  # end
 end

test/tds_issues.exs

@@ -1,7 +1,7 @@
-defmodule TdsTest do
-  use ExUnit.Case, async: true
-  require Logger
+defmodule TdsIssuesTest do
   import Tds.TestHelper
+  require Logger
+  use ExUnit.Case, async: true
 
   @tag timeout: 50000
 
@@ -30,7 +30,7 @@ defmodule TdsTest do
                   %Tds.Parameter{name: "@3", value: {{2016, 12, 20}, {23, 59, 23, 0}}}]) 
 
       assert :ok == res
-      assert [[val]] = query("SELECT [total] FROM hades_sealed_cfdis WHERE id in (select max(id) from hades_sealed_cfdis)", [])
+      assert [[val]] == IO.inspect(query("SELECT [total] FROM hades_sealed_cfdis WHERE id in (select max(id) from hades_sealed_cfdis)", []))
     end
     Enum.flat_map(1..17, &([1/&1, -1/&1]))
     |> Enum.each(f)

test/test_helper.exs

@@ -1,5 +1,3 @@
-ExUnit.start()
-
 defmodule Tds.TestHelper do
   require Logger
   defmacro query(statement, params, opts \\ []) do
@@ -39,3 +37,5 @@ end
 
 Application.get_env(:tds, :opts)
 |> Tds.TestHelper.sqlcmd("IF NOT EXISTS(SELECT * FROM sys.databases where name = 'test') BEGIN CREATE DATABASE [test]; END;")
+
+ExUnit.start()