Skip to content

Commit 69346f3

Browse files
committed
Rename bread_crumbs to breadcrumbs.
1 parent 3954c38 commit 69346f3

File tree

8 files changed

+36
-36
lines changed

8 files changed

+36
-36
lines changed

dev.exs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,17 @@ defmodule ErrorTrackerDevWeb.PageController do
7171
end
7272

7373
def call(conn, :noroute) do
74-
ErrorTracker.add_bread_crumb("ErrorTrackerDevWeb.PageController.no_route")
74+
ErrorTracker.add_breadcrumb("ErrorTrackerDevWeb.PageController.no_route")
7575
raise Phoenix.Router.NoRouteError, conn: conn, router: ErrorTrackerDevWeb.Router
7676
end
7777

7878
def call(_conn, :exception) do
79-
ErrorTracker.add_bread_crumb("ErrorTrackerDevWeb.PageController.exception")
79+
ErrorTracker.add_breadcrumb("ErrorTrackerDevWeb.PageController.exception")
8080
raise "This is a controller exception"
8181
end
8282

8383
def call(_conn, :exit) do
84-
ErrorTracker.add_bread_crumb("ErrorTrackerDevWeb.PageController.exit")
84+
ErrorTracker.add_breadcrumb("ErrorTrackerDevWeb.PageController.exit")
8585
exit(:timeout)
8686
end
8787

@@ -145,13 +145,13 @@ defmodule ErrorTrackerDevWeb.Endpoint do
145145

146146
plug Plug.RequestId
147147
plug Plug.Telemetry, event_prefix: [:phoenix, :endpoint]
148-
plug :add_bread_crumb
148+
plug :add_breadcrumb
149149
plug :maybe_exception
150150
plug :set_csp
151151
plug ErrorTrackerDevWeb.Router
152152

153-
def add_bread_crumb(conn, _) do
154-
ErrorTracker.add_bread_crumb("ErrorTrackerDevWeb.Endpoint.add_bread_crumb")
153+
def add_breadcrumb(conn, _) do
154+
ErrorTracker.add_breadcrumb("ErrorTrackerDevWeb.Endpoint.add_breadcrumb")
155155
conn
156156
end
157157

lib/error_tracker.ex

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,13 @@ defmodule ErrorTracker do
119119
{:ok, stacktrace} = ErrorTracker.Stacktrace.new(stacktrace)
120120
{:ok, error} = Error.new(kind, reason, stacktrace)
121121
context = Map.merge(get_context(), given_context)
122-
bread_crumbs = exception_bread_crumbs(exception) ++ get_bread_crumbs()
122+
breadcrumbs = exception_breadcrumbs(exception) ++ get_breadcrumbs()
123123

124124
if enabled?() && !ignored?(error, context) do
125125
sanitized_context = sanitize_context(context)
126126

127127
{_error, occurrence} =
128-
upsert_error!(error, stacktrace, sanitized_context, bread_crumbs, reason)
128+
upsert_error!(error, stacktrace, sanitized_context, breadcrumbs, reason)
129129

130130
occurrence
131131
else
@@ -205,21 +205,21 @@ defmodule ErrorTracker do
205205
end
206206

207207
@spec set_context(String.t()) :: list(String.t())
208-
def add_bread_crumb(bread_crumb) when is_binary(bread_crumb) do
209-
current_bread_crumbs = Process.get(:error_tracker_bread_crumbs, [])
210-
new_bread_crumbs = current_bread_crumbs ++ [bread_crumb]
208+
def add_breadcrumb(breadcrumb) when is_binary(breadcrumb) do
209+
current_breadcrumbs = Process.get(:error_tracker_breadcrumbs, [])
210+
new_breadcrumbs = current_breadcrumbs ++ [breadcrumb]
211211

212-
Process.put(:error_tracker_bread_crumbs, new_bread_crumbs)
212+
Process.put(:error_tracker_breadcrumbs, new_breadcrumbs)
213213

214-
new_bread_crumbs
214+
new_breadcrumbs
215215
end
216216

217217
@doc """
218218
Obtain the context of the current process.
219219
"""
220-
@spec get_bread_crumbs() :: list(String.t())
221-
def get_bread_crumbs do
222-
Process.get(:error_tracker_bread_crumbs, [])
220+
@spec get_breadcrumbs() :: list(String.t())
221+
def get_breadcrumbs do
222+
Process.get(:error_tracker_breadcrumbs, [])
223223
end
224224

225225
defp enabled? do
@@ -254,15 +254,15 @@ defmodule ErrorTracker do
254254
end
255255
end
256256

257-
defp exception_bread_crumbs(exception) do
257+
defp exception_breadcrumbs(exception) do
258258
case exception do
259-
{_kind, exception} -> exception_bread_crumbs(exception)
260-
%{bread_crumbs: bread_crumbs} -> bread_crumbs
259+
{_kind, exception} -> exception_breadcrumbs(exception)
260+
%{bread_crumbs: breadcrumbs} -> breadcrumbs
261261
_other -> []
262262
end
263263
end
264264

265-
defp upsert_error!(error, stacktrace, context, bread_crumbs, reason) do
265+
defp upsert_error!(error, stacktrace, context, breadcrumbs, reason) do
266266
existing_status =
267267
Repo.one(from e in Error, where: [fingerprint: ^error.fingerprint], select: e.status)
268268

@@ -288,7 +288,7 @@ defmodule ErrorTracker do
288288
|> Occurrence.changeset(%{
289289
stacktrace: stacktrace,
290290
context: context,
291-
bread_crumbs: bread_crumbs,
291+
breadcrumbs: breadcrumbs,
292292
reason: reason
293293
})
294294
|> Repo.insert!()

lib/error_tracker/migration/mysql/v04.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ defmodule ErrorTracker.Migration.MySQL.V04 do
55

66
def up(_opts) do
77
alter table(:error_tracker_occurrences) do
8-
add :bread_crumbs, :json, null: true
8+
add :breadcrumbs, :json, null: true
99
end
1010
end
1111

1212
def down(_opts) do
1313
alter table(:error_tracker_occurrences) do
14-
remove :bread_crumbs
14+
remove :breadcrumbs
1515
end
1616
end
1717
end

lib/error_tracker/migration/postgres/v04.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ defmodule ErrorTracker.Migration.Postgres.V04 do
55

66
def up(_opts) do
77
alter table(:error_tracker_occurrences) do
8-
add :bread_crumbs, {:array, :string}, default: [], null: false
8+
add :breadcrumbs, {:array, :string}, default: [], null: false
99
end
1010
end
1111

1212
def down(_opts) do
1313
alter table(:error_tracker_occurrences) do
14-
remove :bread_crumbs
14+
remove :breadcrumbs
1515
end
1616
end
1717
end

lib/error_tracker/migration/sqlite/v04.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ defmodule ErrorTracker.Migration.SQLite.V04 do
55

66
def up(_opts) do
77
alter table(:error_tracker_occurrences) do
8-
add :bread_crumbs, {:array, :string}, default: [], null: false
8+
add :breadcrumbs, {:array, :string}, default: [], null: false
99
end
1010
end
1111

1212
def down(_opts) do
1313
alter table(:error_tracker_occurrences) do
14-
remove :bread_crumbs
14+
remove :breadcrumbs
1515
end
1616
end
1717
end

lib/error_tracker/schemas/occurrence.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ defmodule ErrorTracker.Occurrence do
1818
field :reason, :string
1919

2020
field :context, :map
21-
field :bread_crumbs, {:array, :string}
21+
field :breadcrumbs, {:array, :string}
2222

2323
embeds_one :stacktrace, ErrorTracker.Stacktrace
2424
belongs_to :error, ErrorTracker.Error
@@ -29,7 +29,7 @@ defmodule ErrorTracker.Occurrence do
2929
@doc false
3030
def changeset(occurrence, attrs) do
3131
occurrence
32-
|> cast(attrs, [:context, :reason, :bread_crumbs])
32+
|> cast(attrs, [:context, :reason, :breadcrumbs])
3333
|> maybe_put_stacktrace()
3434
|> validate_required([:reason, :stacktrace])
3535
|> validate_context()

lib/error_tracker/web/live/show.html.heex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,17 @@
2525
<%= @error.source_line %></pre>
2626
</.section>
2727

28-
<.section :if={@occurrence.bread_crumbs != []} title="Bread crumbs">
28+
<.section :if={@occurrence.breadcrumbs != []} title="Bread crumbs">
2929
<div class="relative overflow-x-auto shadow-md sm:rounded-lg ring-1 ring-gray-900">
3030
<table class="w-full text-sm text-gray-400 table-fixed">
3131
<tr
32-
:for={{bread_crumb, index} <- Enum.with_index(@occurrence.bread_crumbs)}
32+
:for={{breadcrumb, index} <- Enum.with_index(@occurrence.breadcrumbs)}
3333
class="border-b bg-gray-400/10 border-gray-900 last:border-b-0"
3434
>
3535
<td class="w-11 pl-2 py-4 font-medium text-white relative text-right">
36-
<%= length(@occurrence.bread_crumbs) - index %>.
36+
<%= length(@occurrence.breadcrumbs) - index %>.
3737
</td>
38-
<td class="px-2 py-4 font-medium text-white relative"><%= bread_crumb %></td>
38+
<td class="px-2 py-4 font-medium text-white relative"><%= breadcrumb %></td>
3939
</tr>
4040
</table>
4141
</div>

test/error_tracker_test.exs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,14 @@ defmodule ErrorTrackerTest do
101101
end
102102

103103
test "includes bread crumbs if present" do
104-
bread_crumbs = ["bread crumb 1", "bread crumb 2"]
104+
breadcrumbs = ["breadcrumb 1", "breadcrumb 2"]
105105

106106
occurrence =
107107
report_error(fn ->
108-
raise ErrorWithBreadcrumbs, message: "test", bread_crumbs: bread_crumbs
108+
raise ErrorWithBreadcrumbs, message: "test", bread_crumbs: breadcrumbs
109109
end)
110110

111-
assert occurrence.bread_crumbs == bread_crumbs
111+
assert occurrence.breadcrumbs == breadcrumbs
112112
end
113113
end
114114

0 commit comments

Comments
 (0)