Skip to content

Removed unnecessary cleaning of Elixir manifests #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

Removed unnecessary cleaning of Elixir manifests #423

merged 1 commit into from
Nov 3, 2025
+0 −3

Conversation

@josevalim
Copy link
Contributor

@josevalim josevalim commented Oct 28, 2025

Closes #373.

@josevalim josevalim mentioned this pull request Oct 28, 2025
Closed
@coveralls
Copy link

coveralls commented Oct 28, 2025

Pull Request Test Coverage Report for Build 71f2cdd8fd5a60c25b44caa4dfdc1813c6bc2618-PR-423

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.275%
Totals Coverage Status
Change from base Build d33d7452b20281cf7b1aaba299955e5c92719669: -0.02%
Covered Lines: 645
Relevant Lines: 699
💛 - Coveralls

maennchen
maennchen approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer have access to a project that caused trouble. So I propose to just merge and see if there’s any issues.

whatyouhide
whatyouhide approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@josevalim josevalim merged commit 30bf87d into main Nov 3, 2025
2 checks passed
@josevalim josevalim deleted the jv-fix-redefining branch November 3, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maennchen maennchen maennchen approved these changes

@whatyouhide whatyouhide whatyouhide approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicate references in POT files and warnings about redefining modules

5 participants

@josevalim @coveralls @maennchen @whatyouhide