fix: update accepted_compressors to use channel's accepted_compressors (#445)

Signed-off-by: Yordis Prieto <[email protected]>

Author: yordis

lib/grpc/stub.ex

@@ -309,7 +309,11 @@ defmodule GRPC.Stub do
       end
 
     compressor = Keyword.get(opts, :compressor, channel.compressor)
-    accepted_compressors = Keyword.get(opts, :accepted_compressors, [])
+    accepted_compressors = Keyword.get(opts, :accepted_compressors, channel.accepted_compressors)
+
+    if not is_list(accepted_compressors) do
+      raise ArgumentError, "accepted_compressors is not a list"
+    end
 
     accepted_compressors =
       if compressor do
@@ -321,7 +325,7 @@ defmodule GRPC.Stub do
     stream = %{
       stream
       | codec: Keyword.get(opts, :codec, channel.codec),
-        compressor: Keyword.get(opts, :compressor, channel.compressor),
+        compressor: compressor,
         accepted_compressors: accepted_compressors
     }
 

test/grpc/integration/compressor_test.exs

@@ -36,6 +36,16 @@ defmodule GRPC.Integration.CompressorTest do
     end
   end
 
+  defmodule AcceptCompressServer do
+    use GRPC.Server,
+      service: Helloworld.Greeter.Service
+
+    def say_hello(_, stream) do
+      GRPC.Server.set_compressor(stream, GRPC.Compressor.Gzip)
+      %Helloworld.HelloReply{message: "Hola, Mundo! Olá, Mundo!"}
+    end
+  end
+
   defmodule HelloStub do
     use GRPC.Stub, service: Helloworld.Greeter.Service
   end
@@ -108,4 +118,28 @@ defmodule GRPC.Integration.CompressorTest do
                |> HelloStub.say_hello(req, compressor: GRPC.Compressor.Gzip, return_headers: true)
     end)
   end
+
+  test "error when accepted_compressors is not a list" do
+    run_server(AcceptCompressServer, fn port ->
+      {:ok, channel} = GRPC.Stub.connect("localhost:#{port}")
+
+      assert_raise ArgumentError, "accepted_compressors is not a list", fn ->
+        HelloStub.say_hello(channel, %Helloworld.HelloRequest{name: ""},
+          accepted_compressors: nil
+        )
+      end
+    end)
+  end
+
+  test "fallback to channel's accepted_compressors" do
+    run_server(AcceptCompressServer, fn port ->
+      {:ok, channel} =
+        GRPC.Stub.connect("localhost:#{port}", accepted_compressors: [GRPC.Compressor.Gzip])
+
+      req = %Helloworld.HelloRequest{name: ""}
+
+      {:ok, _reply, headers} = HelloStub.say_hello(channel, req, return_headers: true)
+      assert headers[:headers]["grpc-encoding"]
+    end)
+  end
 end