Fix warnings (#441)

Signed-off-by: Yordis Prieto <[email protected]>

Author: yordis

.github/workflows/ci.yml

@@ -52,7 +52,7 @@ jobs:
       - name: Install Dependencies
         run: mix deps.get 1>/dev/null
       - name: Run Tests
-        run: mix test
+        run: mix test --warnings-as-errors
   interop-tests:
     runs-on: ubuntu-latest
     name: Interop tests

lib/grpc/transport/http2.ex

@@ -9,7 +9,7 @@ defmodule GRPC.Transport.HTTP2 do
   require Logger
 
   def server_headers(%{codec: GRPC.Codec.WebText = codec}) do
-    %{"content-type" => "application/grpc-web-#{codec.name()}"}
+    %{"content-type" => "application/grpc-web-#{codec_name(codec)}"}
   end
 
   # TO-DO: refactor when we add a GRPC.Codec.content_type callback
@@ -18,7 +18,7 @@ defmodule GRPC.Transport.HTTP2 do
   end
 
   def server_headers(%{codec: codec}) do
-    %{"content-type" => "application/grpc+#{codec.name()}"}
+    %{"content-type" => "application/grpc+#{codec_name(codec)}"}
   end
 
   @spec server_trailers(integer, String.t()) :: map
@@ -69,8 +69,11 @@ defmodule GRPC.Transport.HTTP2 do
   # Some gRPC implementations don't support application/grpc+xyz,
   # to avoid this kind of trouble, use application/grpc by default
   defp content_type(_, GRPC.Codec.Proto), do: "application/grpc"
-  defp content_type(_, codec = GRPC.Codec.WebText), do: "application/grpc-web-#{codec.name()}"
-  defp content_type(_, codec), do: "application/grpc+#{codec.name()}"
+
+  defp content_type(_, codec = GRPC.Codec.WebText),
+    do: "application/grpc-web-#{codec_name(codec)}"
+
+  defp content_type(_, codec), do: "application/grpc+#{codec_name(codec)}"
 
   def extract_metadata(headers) do
     headers
@@ -105,13 +108,13 @@ defmodule GRPC.Transport.HTTP2 do
   defp append_encoding(headers, _), do: headers
 
   defp append_compressor(headers, compressor) when not is_nil(compressor) do
-    [{"grpc-encoding", compressor.name()} | headers]
+    [{"grpc-encoding", compressor_name(compressor)} | headers]
   end
 
   defp append_compressor(headers, _), do: headers
 
   defp append_accepted_compressors(headers, [_] = compressors) do
-    encoding = Enum.map_join(compressors, ",", & &1.name())
+    encoding = Enum.map_join(compressors, ",", &compressor_name/1)
     [{"grpc-accept-encoding", encoding} | headers]
   end
 
@@ -165,4 +168,10 @@ defmodule GRPC.Transport.HTTP2 do
   defp is_metadata(key) do
     !is_reserved_header(key)
   end
+
+  defp codec_name(codec) when is_atom(codec), do: apply(codec, :name, [])
+  defp codec_name(%{name: name}), do: name
+
+  defp compressor_name(compressor) when is_atom(compressor), do: apply(compressor, :name, [])
+  defp compressor_name(%{name: name}), do: name
 end