More assertions

Author: josevalim

lib/elixir/src/elixir_erl_compiler.erl

@@ -118,6 +118,7 @@ format_warnings(Opts, Warnings) ->
 %% Those we implement ourselves
 handle_file_warning(_, _File, {_Line, v3_core, {map_key_repeated, _}}) -> ok;
 handle_file_warning(_, _File, {_Line, sys_core_fold, {ignored, useless_building}}) -> ok;
+handle_file_warning(_, _File, {_Line, sys_core_fold, {nomatch, _}}) -> ok;
 
 %% Ignore all linting errors (only come up on parse transforms)
 handle_file_warning(_, _File, {_Line, erl_lint, _}) -> ok;
@@ -150,18 +151,6 @@ custom_format(sys_core_fold, {ignored, {no_effect, {erlang, F, A}}}) ->
   end,
   io_lib:format(Fmt, Args);
 
-%% Rewrite nomatch to be more generic, it can happen inside if, unless, and the like
-custom_format(sys_core_fold, {nomatch, X}) when X == guard; X == no_clause ->
-  "this check/guard will always yield the same result";
-
-custom_format(sys_core_fold, {nomatch, {shadow, Line, {ErlName, ErlArity}}}) ->
-  {Name, Arity} = elixir_utils:erl_fa_to_elixir_fa(ErlName, ErlArity),
-
-  io_lib:format(
-    "this clause for ~ts/~B cannot match because a previous clause at line ~B always matches",
-    [Name, Arity, Line]
-  );
-
 custom_format([], Desc) ->
   io_lib:format("~p", [Desc]);
 

lib/elixir/src/elixir_expand.erl

@@ -739,7 +739,9 @@ expand_case(Meta, Expr, Opts, S, E) ->
   end.
 
 prune_case_clauses(false, [{do, [{'->', _, [[false], Body]}, {'->', _, [[true], _]}]}]) -> {ok, Body};
+prune_case_clauses(false, [{do, [{'->', _, [[true], _]}, {'->', _, [[false], Body]}]}]) -> {ok, Body};
 prune_case_clauses(true, [{do, [{'->', _, [[false], _]}, {'->', _, [[true], Body]}]}]) -> {ok, Body};
+prune_case_clauses(true, [{do, [{'->', _, [[true], Body]}, {'->', _, [[false], _]}]}]) -> {ok, Body};
 prune_case_clauses(_, _) -> error.
 
 rewrite_case_clauses([{do, [

lib/elixir/test/elixir/module/types/expr_test.exs

@@ -1049,6 +1049,22 @@ defmodule Module.Types.ExprTest do
 
       assert type == atom([:ok, :error])
     end
+
+    test "does not report on literal booleans" do
+      assert typecheck!(
+               case true do
+                 true -> :ok
+                 false -> :error
+               end
+             ) == atom([:ok])
+
+      assert typecheck!(
+               case false do
+                 true -> :ok
+                 false -> :error
+               end
+             ) == atom([:error])
+    end
   end
 
   describe "conditionals" do