Skip to content

Commit 0872fdd

Browse files
author
José Valim
committed
Revert "IEx autocompletion should show all exported functions, not only documented ones"
This reverts commit 3ffc5e9. Closes #879.
1 parent e27707e commit 0872fdd

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

lib/iex/lib/iex/autocomplete.ex

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,11 @@ defmodule IEx.Autocomplete do
253253

254254
defp get_funs(mod) do
255255
if function_exported?(mod, :__info__, 1) do
256-
(mod.__info__(:functions) -- [__info__: 1]) ++ mod.__info__(:macros)
256+
if docs = mod.__info__(:docs) do
257+
lc { tuple, _line, _kind, _sign, doc } inlist docs, doc != false, do: tuple
258+
else
259+
(mod.__info__(:functions) -- [__info__: 1]) ++ mod.__info__(:macros)
260+
end
257261
else
258262
mod.module_info(:exports)
259263
end

lib/iex/test/iex/autocomplete_test.exs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,6 @@ defmodule IEx.AutocompleteTest do
5454
assert expand('System.ve') == {:yes, 'rsion', []}
5555
end
5656

57-
test :elixir_function_nodoc do
58-
{:yes, '', list} = expand('Keyword.get')
59-
assert 'get/2' inlist list
60-
end
61-
6257
test :elixir_function_completion_with_arity do
6358
assert expand('String.printable?') == {:yes, '', ['printable?/1']}
6459
assert expand('String.printable?/') == {:yes, '', ['printable?/1']}

0 commit comments

Comments
 (0)