Skip to content

Commit 0d75496

Browse files
committed
Placed excluded count in parens to improve clarity
1 parent 190afac commit 0d75496

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

lib/ex_unit/lib/ex_unit/cli_formatter.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ defmodule ExUnit.CLIFormatter do
352352
)
353353
|> if_true(
354354
config.excluded_counter > 0,
355-
&(&1 <> ", #{config.excluded_counter} excluded")
355+
&(&1 <> " (#{config.excluded_counter} excluded)")
356356
)
357357

358358
cond do

lib/ex_unit/test/ex_unit_test.exs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -331,19 +331,19 @@ defmodule ExUnitTest do
331331

332332
{result, output} = run_with_filter([exclude: [even: true]], [ParityTest])
333333
assert result == %{failures: 0, skipped: 0, excluded: 1, total: 4}
334-
assert output =~ "\n3 tests, 0 failures, 1 excluded\n"
334+
assert output =~ "\n3 tests, 0 failures (1 excluded)\n"
335335

336336
{result, output} = run_with_filter([exclude: :even], [ParityTest])
337337
assert result == %{failures: 0, skipped: 0, excluded: 3, total: 4}
338-
assert output =~ "\n1 test, 0 failures, 3 excluded\n"
338+
assert output =~ "\n1 test, 0 failures (3 excluded)\n"
339339

340340
{result, output} = run_with_filter([exclude: :even, include: [even: true]], [ParityTest])
341341
assert result == %{failures: 1, skipped: 0, excluded: 2, total: 4}
342-
assert output =~ "\n2 tests, 1 failure, 2 excluded\n"
342+
assert output =~ "\n2 tests, 1 failure (2 excluded)\n"
343343

344344
{result, output} = run_with_filter([exclude: :test, include: [even: true]], [ParityTest])
345345
assert result == %{failures: 1, skipped: 0, excluded: 3, total: 4}
346-
assert output =~ "\n1 test, 1 failure, 3 excluded\n"
346+
assert output =~ "\n1 test, 1 failure (3 excluded)\n"
347347
end
348348

349349
test "log capturing" do
@@ -510,15 +510,15 @@ defmodule ExUnitTest do
510510
{result, output} = run_with_filter([exclude: :module], [])
511511

512512
assert result == %{failures: 0, skipped: 0, excluded: 2, total: 2}
513-
assert output =~ "\n0 tests, 0 failures, 2 excluded\n"
513+
assert output =~ "\n0 tests, 0 failures (2 excluded)\n"
514514

515515
{result, output} =
516516
[exclude: :test, include: [module: "ExUnitTest.SecondTestModule"]]
517517
|> run_with_filter([FirstTestModule, SecondTestModule])
518518

519519
assert result == %{failures: 1, skipped: 0, excluded: 1, total: 2}
520520
assert output =~ "\n 1) test false (ExUnitTest.SecondTestModule)\n"
521-
assert output =~ "\n1 test, 1 failure, 1 excluded\n"
521+
assert output =~ "\n1 test, 1 failure (1 excluded)\n"
522522
end
523523

524524
test "raises on reserved tag :file in module" do
@@ -681,7 +681,7 @@ defmodule ExUnitTest do
681681
end)
682682

683683
refute output =~ max_failures_reached_msg()
684-
assert output =~ "\n5 tests, 0 failures, 4 invalid, 1 skipped, 1 excluded\n"
684+
assert output =~ "\n5 tests, 0 failures, 4 invalid, 1 skipped (1 excluded)\n"
685685
end
686686

687687
test "parameterized tests" do
@@ -788,7 +788,7 @@ defmodule ExUnitTest do
788788
end)
789789

790790
assert output =~ max_failures_reached_msg()
791-
assert output =~ "\n5 tests, 2 failures, 1 skipped, 1 excluded\n"
791+
assert output =~ "\n5 tests, 2 failures, 1 skipped (1 excluded)\n"
792792
end
793793

794794
test ":max_failures is not reached" do
@@ -819,7 +819,7 @@ defmodule ExUnitTest do
819819
end)
820820

821821
refute output =~ max_failures_reached_msg()
822-
assert output =~ "\n6 tests, 2 failures, 1 skipped, 2 excluded\n"
822+
assert output =~ "\n6 tests, 2 failures, 1 skipped (2 excluded)\n"
823823
end
824824

825825
test ":max_failures has been reached" do
@@ -853,7 +853,7 @@ defmodule ExUnitTest do
853853
end)
854854

855855
assert output =~ max_failures_reached_msg()
856-
assert output =~ "\n5 tests, 2 failures, 2 skipped, 2 excluded\n"
856+
assert output =~ "\n5 tests, 2 failures, 2 skipped (2 excluded)\n"
857857
end
858858

859859
# Excluded and skipped tests are detected before setup_all
@@ -887,7 +887,7 @@ defmodule ExUnitTest do
887887
end)
888888

889889
assert output =~ max_failures_reached_msg()
890-
assert output =~ "\n3 tests, 0 failures, 2 invalid, 1 skipped, 1 excluded\n"
890+
assert output =~ "\n3 tests, 0 failures, 2 invalid, 1 skipped (1 excluded)\n"
891891
end
892892

893893
test ":max_failures flushes all async/sync cases" do
@@ -1060,7 +1060,7 @@ defmodule ExUnitTest do
10601060
end)
10611061

10621062
assert output =~ "All tests have been excluded.\n"
1063-
assert output =~ "0 tests, 0 failures, 2 excluded\n"
1063+
assert output =~ "0 tests, 0 failures (2 excluded)\n"
10641064
end
10651065

10661066
test "tests are run in compile order (FIFO)" do

0 commit comments

Comments
 (0)