Skip to content

Commit 0fdc751

Browse files
author
José Valim
committed
Remove guard checks on is_odd/is_even as those are tested in defguard, closes #9700
1 parent 0e88732 commit 0fdc751

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lib/elixir/test/elixir/integer_test.exs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@ defmodule IntegerTest do
88
require Integer
99

1010
def test_is_odd_in_guards(number) when Integer.is_odd(number), do: number
11-
def test_is_odd_in_guards(atom) when is_atom(atom) and not Integer.is_odd(atom), do: :atom
1211
def test_is_odd_in_guards(_number), do: false
1312

1413
def test_is_even_in_guards(number) when Integer.is_even(number), do: number
15-
def test_is_even_in_guards(atom) when is_atom(atom) and not Integer.is_even(atom), do: :atom
1614
def test_is_even_in_guards(_number), do: false
1715

1816
test "is_odd/1" do
@@ -25,7 +23,7 @@ defmodule IntegerTest do
2523
assert Integer.is_odd(-3) == true
2624
assert test_is_odd_in_guards(10) == false
2725
assert test_is_odd_in_guards(11) == 11
28-
assert test_is_odd_in_guards(:not_integer) == :atom
26+
assert test_is_odd_in_guards(:not_integer) == false
2927
end
3028

3129
test "is_even/1" do
@@ -38,7 +36,7 @@ defmodule IntegerTest do
3836
assert Integer.is_even(-3) == false
3937
assert test_is_even_in_guards(10) == 10
4038
assert test_is_even_in_guards(11) == false
41-
assert test_is_even_in_guards(:not_integer) == :atom
39+
assert test_is_even_in_guards(:not_integer) == false
4240
end
4341

4442
test "mod/2" do

0 commit comments

Comments
 (0)