Skip to content

Commit 1120c55

Browse files
authored
Apply suggestions from code review
1 parent a581c21 commit 1120c55

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

lib/elixir/lib/module/types/descr.ex

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2246,7 +2246,7 @@ defmodule Module.Types.Descr do
22462246
# `%{..., a: if_set(not atom()), b: integer()}`. For maps with more keys,
22472247
# each key in a negated literal may create a new union when eliminated.
22482248
#
2249-
# Instead of a tag :open or :closed, we can also use a map od domains which
2249+
# Instead of a tag :open or :closed, we can also use a map of domains which
22502250
# specifies for each defined key domain (@domain_key_types) the type associated with
22512251
# those keys.
22522252
#
@@ -2281,7 +2281,8 @@ defmodule Module.Types.Descr do
22812281
end
22822282
end
22832283

2284-
# TOD: Double check if we indeed want the union here
2284+
# TODO: Double check if we indeed want the union here
2285+
# when we start using domain types from Elixir itself
22852286
defp map_put_domain(domain, key, value) do
22862287
Map.update(domain, key, if_set(value), &union(&1, value))
22872288
end
@@ -2725,6 +2726,7 @@ defmodule Module.Types.Descr do
27252726
Refreshes the type of map after assuming some type was given to a key of a given type.
27262727
Assuming that the descr is exclusively a map (or dynamic).
27272728
"""
2729+
# TODO: Figure out how this operation will be used from Elixir
27282730
def map_refresh(:term, _key, _type), do: :badmap
27292731

27302732
def map_refresh(descr, key_descr, type) do
@@ -2796,6 +2798,7 @@ defmodule Module.Types.Descr do
27962798
- `:badkey`: If the key is considered invalid during the take operation (e.g.,
27972799
an optional key that resolves to an empty type).
27982800
"""
2801+
# TODO: Figure out how this operation will be used from Elixir
27992802
def map_refresh_key(descr, key, new_additional_type) when is_atom(key) do
28002803
case map_fetch(descr, key) do
28012804
:badmap ->
@@ -2940,6 +2943,7 @@ defmodule Module.Types.Descr do
29402943
* `:badkeytype`: The input `key_type` was invalid (e.g., not a subtype
29412944
of the allowed key types like `atom()`, `integer()`, etc.).
29422945
"""
2946+
# TODO: Figure out how to use this operation from Elixir
29432947
def map_get(:term, _key_descr), do: :badmap
29442948

29452949
def map_get(%{} = descr, key_descr) do

0 commit comments

Comments
 (0)