Fix more tests

Author: josevalim

lib/elixir/lib/calendar/time.ex

@@ -797,15 +797,8 @@ defmodule Time do
   @doc since: "1.5.0"
   @spec convert!(Calendar.time(), Calendar.calendar()) :: t
   def convert!(time, calendar) do
-    case convert(time, calendar) do
-      {:ok, value} ->
-        value
-
-      {:error, reason} ->
-        raise ArgumentError,
-              "cannot convert #{inspect(time)} to target calendar #{inspect(calendar)}, " <>
-                "reason: #{inspect(reason)}"
-    end
+    {:ok, value} = convert(time, calendar)
+    value
   end
 
   @doc """

lib/elixir/lib/kernel.ex

@@ -302,7 +302,7 @@ defmodule Kernel do
   @compile {:inline, bootstrapped?: 1}
   case :code.ensure_loaded(Kernel) do
     {:module, _} ->
-      defp bootstrapped?(_), do: true
+      defp bootstrapped?(module), do: is_atom(module)
 
     {:error, _} ->
       defp bootstrapped?(module), do: :code.ensure_loaded(module) == {:module, module}

lib/elixir/lib/set.ex

@@ -90,7 +90,7 @@ defmodule Set do
     if target1 == target2 do
       target1.intersection(set1, set2)
     else
-      Enumerable.reduce(set1, {:cont, target1.new}, fn v, acc ->
+      Enumerable.reduce(set1, {:cont, target1.new()}, fn v, acc ->
         {:cont, if(target2.member?(set2, v), do: target1.put(acc, v), else: acc)}
       end)
       |> elem(1)

lib/elixir/src/elixir_locals.erl

@@ -106,9 +106,9 @@ ensure_no_undefined_local(Module, All, E) ->
 
 warn_unused_local(Module, All, Private, E) ->
   if_tracker(Module, [], fun(Tracker) ->
-    {_Unreachable, Warnings} = ?locals:collect_unused_locals(Tracker, All, Private),
+    {Unreachable, Warnings} = ?locals:collect_unused_locals(Tracker, All, Private),
     [elixir_errors:file_warn(Meta, E, ?MODULE, Error) || {Meta, Error} <- Warnings],
-    []
+    Unreachable
   end).
 
 format_error({function_conflict, {Receiver, {Name, Arity}}}) ->

lib/elixir/test/elixir/kernel/quote_test.exs

@@ -383,8 +383,6 @@ defmodule Kernel.QuoteTest.ErrorsTest do
         mod = Kernel.QuoteTest.ErrorsTest
         file = __ENV__.file |> Path.relative_to_cwd() |> String.to_charlist()
         assert [{^mod, :will_raise, 2, [file: ^file, line: @line] ++ _} | _] = __STACKTRACE__
-    else
-      _ -> flunk("expected failure")
     end
   end