Add support for Mix.install/2 in deps.partition

Author: josevalim

lib/mix/lib/mix.ex

@@ -420,7 +420,7 @@ defmodule Mix do
 
   """
 
-  @mix_install_project __MODULE__.InstallProject
+  @mix_install_project Mix.InstallProject
   @mix_install_app :mix_install
   @mix_install_app_string Atom.to_string(@mix_install_app)
 
@@ -905,9 +905,7 @@ defmodule Mix do
 
     case Mix.State.get(:installed) do
       nil ->
-        Application.put_all_env(config, persistent: true)
         System.put_env(system_env)
-
         install_project_dir = install_project_dir(id)
 
         if Keyword.fetch!(opts, :verbose) do
@@ -924,10 +922,14 @@ defmodule Mix do
           config_path: config_path
         ]
 
-        config = install_project_config(dynamic_config)
+        :ok =
+          Mix.ProjectStack.push(
+            @mix_install_project,
+            [compile_config: config] ++ install_project_config(dynamic_config),
+            "nofile"
+          )
 
         started_apps = Application.started_applications()
-        :ok = Mix.ProjectStack.push(@mix_install_project, config, "nofile")
         build_dir = Path.join(install_project_dir, "_build")
         external_lockfile = expand_path(opts[:lockfile], deps, :lockfile, "mix.lock")
 
@@ -944,9 +946,9 @@ defmodule Mix do
           File.mkdir_p!(install_project_dir)
 
           File.cd!(install_project_dir, fn ->
-            if config_path do
-              Mix.Task.rerun("loadconfig")
-            end
+            # This steps need to be mirror in mix deps.partition
+            Application.put_all_env(config, persistent: true)
+            Mix.Task.rerun("loadconfig")
 
             cond do
               external_lockfile ->
@@ -1079,7 +1081,7 @@ defmodule Mix do
 
   defp install_project_config(dynamic_config) do
     [
-      version: "0.1.0",
+      version: "1.0.0",
       build_per_environment: true,
       build_path: "_build",
       lockfile: "mix.lock",

lib/mix/lib/mix/tasks/deps.partition.ex

@@ -7,6 +7,8 @@ defmodule Mix.Tasks.Deps.Partition do
 
   ## Server
 
+  @deps_partition_install_mix_exs ~c"deps.partition.mix.exs"
+
   def server(deps, count, force?) do
     {:ok, socket} = :gen_tcp.listen(0, [:binary, packet: :line, active: true, reuseaddr: true])
 
@@ -26,6 +28,31 @@ defmodule Mix.Tasks.Deps.Partition do
     ansi_flag = if IO.ANSI.enabled?(), do: ~c"--color", else: ~c"--no-color"
     force_flag = if force?, do: ~c"--force", else: ~c"--no-force"
 
+    env_vars =
+      if Mix.install?() do
+        blob =
+          Mix.Project.config()
+          |> :erlang.term_to_binary()
+          |> :binary.bin_to_list()
+          |> Enum.join(",")
+
+        # We replicate the initialization logic from Mix.install/2 as part of mix.exs
+        File.write!(@deps_partition_install_mix_exs, """
+        config = <<#{blob}>>
+        project = :erlang.binary_to_term(config)
+
+        if compile_config = project[:compile_config] do
+          Application.put_all_env(compile_config, persistent: true)
+        end
+
+        Mix.ProjectStack.push(Mix.InstallProject, project, "nofile")
+        """)
+
+        [{~c"MIX_EXS", @deps_partition_install_mix_exs}]
+      else
+        []
+      end
+
     args = [
       ansi_flag,
       ~c"-e",
@@ -45,7 +72,7 @@ defmodule Mix.Tasks.Deps.Partition do
       :stderr_to_stdout,
       line: 1_000_000,
       args: args,
-      env: [{~c"MIX_OS_CONCURRENCY_LOCK", ~c"false"}]
+      env: [{~c"MIX_OS_CONCURRENCY_LOCK", ~c"false"} | env_vars]
     ]
 
     clients =
@@ -123,11 +150,11 @@ defmodule Mix.Tasks.Deps.Partition do
 
       {:tcp_closed, socket} ->
         shutdown_clients(available ++ busy)
-        Mix.raise("ERROR! mix deps.partition #{inspect(socket)} closed unexpectedly")
+        Mix.raise("mix deps.partition #{inspect(socket)} closed unexpectedly")
 
       {:tcp_error, socket, error} ->
         shutdown_clients(available ++ busy)
-        Mix.raise("ERROR! mix deps.partition #{inspect(socket)} errored: #{inspect(error)}")
+        Mix.raise("mix deps.partition #{inspect(socket)} errored: #{inspect(error)}")
 
       {port, {:data, {eol, data}}} ->
         with %{index: index} <-
@@ -164,7 +191,12 @@ defmodule Mix.Tasks.Deps.Partition do
       {^port, {:data, {:noeol, data}}} -> [data | close_port(port, prefix)]
     after
       0 ->
-        Port.close(port)
+        try do
+          Port.close(port)
+        catch
+          _, _ -> :ok
+        end
+
         []
     end
   end

lib/mix/lib/mix/tasks/loadconfig.ex

@@ -40,10 +40,10 @@ defmodule Mix.Tasks.Loadconfig do
   end
 
   defp load_default do
-    config = Mix.Project.config()
+    config_path = Mix.Project.config()[:config_path]
 
-    if File.regular?(config[:config_path]) or config[:config_path] != "config/config.exs" do
-      load_compile(config[:config_path])
+    if config_path != nil and (File.regular?(config_path) or config_path != "config/config.exs") do
+      load_compile(config_path)
     else
       []
     end

lib/mix/test/mix/tasks/loadconfig_test.exs

@@ -67,6 +67,11 @@ defmodule Mix.Tasks.LoadconfigTest do
     end)
   end
 
+  test "is a no-op with nil custom config_path" do
+    Mix.ProjectStack.post_config(config_path: nil)
+    assert Mix.Task.run("loadconfig", []) == []
+  end
+
   test "updates config files and config mtime", context do
     in_tmp(context.test, fn ->
       Mix.Project.push(MixTest.Case.Sample)