Skip to content

Commit 2bf898e

Browse files
committed
Fix race condition in Logger.ErrorHandlerTest
When crashing the error logger handler, the handler's watcher could log its message before Logger was flushed, causing the watcher's log message to appear in the first, rather than second, capture_log.
1 parent 0792fe2 commit 2bf898e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/logger/test/logger/error_handler_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ defmodule Logger.ErrorHandlerTest do
22
use Logger.Case
33

44
test "survives after crashes" do
5-
assert error_log(:info_msg, "~p~n", []) == ""
65
assert capture_log(fn ->
6+
:error_logger.info_msg("~p~n", [])
77
wait_for_handler(:error_logger, Logger.ErrorHandler)
88
end) =~ "[error] GenEvent handler Logger.ErrorHandler installed at :error_logger\n" <>
99
"** (exit) an exception was raised:"

0 commit comments

Comments
 (0)