Skip to content

Commit 3c10057

Browse files
josevalimJosé Valim
authored andcommitted
Merge pull request #2953 from liveforeverx/fix_compile_error
resolves #2952 Signed-off-by: José Valim <[email protected]>
1 parent d1b6161 commit 3c10057

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

lib/elixir/src/elixir_exp.erl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,8 +490,8 @@ validate_opts(Meta, Kind, Allowed, Opts, E) when is_list(Opts) ->
490490
"unsupported option ~ts given to ~s", ['Elixir.Kernel':inspect(Key), Kind])
491491
end || {Key, _} <- Opts, not lists:member(Key, Allowed)];
492492

493-
validate_opts(Meta, Kind, _Allowed, _Opts, S) ->
494-
compile_error(Meta, S#elixir_scope.file, "invalid options for ~s, expected a keyword list", [Kind]).
493+
validate_opts(Meta, Kind, _Allowed, _Opts, E) ->
494+
compile_error(Meta, ?m(E, file), "invalid options for ~s, expected a keyword list", [Kind]).
495495

496496
no_alias_opts(KV) when is_list(KV) ->
497497
case lists:keyfind(as, 1, KV) of

lib/elixir/test/elixir/kernel/errors_test.exs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,13 @@ defmodule Kernel.ErrorsTest do
324324
assert_compile_fail CompileError,
325325
"nofile:1: invalid arguments for quote",
326326
'quote 1'
327+
assert_compile_fail CompileError,
328+
"nofile:1: invalid options for quote, expected a keyword list",
329+
'''
330+
quote :foo do
331+
foo
332+
end
333+
'''
327334
end
328335

329336
test :invalid_calls do

0 commit comments

Comments
 (0)