Deprecate IEx.inspect_opts in favor of IEx.Options

Author: alco

lib/iex/lib/iex.ex

@@ -147,23 +147,16 @@ defmodule IEx do
     match?({ :ok, true }, :application.get_env(:iex, :started))
   end
 
-  @doc """
-  Registers options used on inspect.
-  """
+  @doc false
   def inspect_opts(opts) when is_list(opts) do
-    old_opts = inspect_opts()
-    filtered_opts = Enum.filter opts, fn {name, _} ->
-      name in old_opts
-    end
-    :application.set_env(:iex, :inspect_opts, Keyword.merge(old_opts, filtered_opts))
+    IO.write "[WARNING] IEx.inspect_opts is deprecated, please use IEx.Options.get/set instead. See `IEx.Options.print_help :inspect`.\n#{Exception.format_stacktrace}"
+    IEx.Options.set :inspect, opts
   end
 
-  @doc """
-  Returns currently registered inspect options.
-  """
+  @doc false
   def inspect_opts do
-    { :ok, opts } = :application.get_env(:iex, :inspect_opts)
-    opts
+    IO.write "[WARNING] IEx.inspect_opts is deprecated, please use IEx.Options.get/set instead. See `IEx.Options.print_help :inspect`.\n#{Exception.format_stacktrace}"
+    IEx.Options.get :inspect
   end
 
   # This is a callback invoked by Erlang shell utilities
@@ -207,7 +200,7 @@ defmodule IEx do
     )
 
     if opts[:inspect_opts] do
-      IEx.inspect_opts(opts[:inspect_opts])
+      IEx.Options.set :inspect, opts[:inspect_opts]
     end
 
     IEx.Config[

lib/iex/lib/iex/options.ex

@@ -93,7 +93,8 @@ defmodule IEx.Options do
   end
 
   def get(:inspect) do
-    IEx.inspect_opts
+    { :ok, opts } = :application.get_env(:iex, :inspect_opts)
+    opts
   end
 
   def get(name) do
@@ -122,7 +123,7 @@ defmodule IEx.Options do
   def set(name, value)
 
   def set(:colors, colors) when is_list(colors) do
-    { :ok, old_colors } = :application.get_env(:iex, :colors)
+    old_colors = get(:colors)
     # Validate keys before setting
     filtered_colors = Enum.filter colors, fn {name, _} ->
       name in old_colors
@@ -136,9 +137,12 @@ defmodule IEx.Options do
   end
 
   def set(:inspect, opts) when is_list(opts) do
-    old_opts = IEx.inspect_opts
-    # `opts` are validated by IEx.inspect_opts
-    IEx.inspect_opts(opts)
+    old_opts = get(:inspect)
+    # Validate keys before setting
+    filtered_opts = Enum.filter opts, fn {name, _} ->
+      name in old_opts
+    end
+    :application.set_env(:iex, :inspect_opts, Keyword.merge(old_opts, filtered_opts))
     old_opts
   end
 

lib/iex/lib/iex/server.ex

@@ -157,7 +157,7 @@ defmodule IEx.Server do
   end
 
   defp io_put(result) do
-    IO.puts :stdio, IEx.color(:eval_result, inspect(result, IEx.inspect_opts))
+    IO.puts :stdio, IEx.color(:eval_result, inspect(result, IEx.Options.get(:inspect)))
   end
 
   defp io_error(result) do