Move is_odd and is_even to Integer

Author: José Valim

CHANGELOG.md

@@ -8,9 +8,9 @@
   * [ExUnit] Show failures on CLIFormatter as soon as they pop up
   * [IEx] Allow for strings in `h` helper
   * [IEx] Helpers `r` and `c` can handle erlang sources
+  * [Integer] Add `odd?/1` and `even?/1`
   * [IO] Added support to specifying a number of bytes to stream to `IO.stream`, `IO.binstream`, `File.stream!` and `File.binstream!`
   * [Kernel] Include file and line on error report for overriding an existing function/macro
-  * [Kernel] Add `is_odd/1` and `is_even/1`
   * [Kernel] Convert external functions into quoted expressions. This allows record fields to contain functions as long as they point to an `&Mod.fun/arity`
   * [Kernel] Allow `foo?` and `bar!` as valid variable names
   * [List] Add `List.replace_at/3`

lib/elixir/lib/integer.ex

@@ -0,0 +1,19 @@
+defmodule Integer do
+  @moduledoc """
+  Functions for working with integers.
+  """
+
+  @doc """
+  Returns true if `n` is an odd number, otherwise false.
+  """
+  defmacro odd?(n) do
+    quote do: rem(unquote(n), 2) != 0
+  end
+
+  @doc """
+  Returns true if `n` is an even number, otherwise false.
+  """
+  defmacro even?(n) do
+    quote do: rem(unquote(n), 2) == 0
+  end
+end

lib/elixir/lib/kernel.ex

@@ -3528,20 +3528,6 @@ defmodule Kernel do
     split_words(string, modifiers)
   end
 
-  @doc """
-  Returns true if `n` is an odd number, otherwise false.
-  """
-  defmacro is_odd(n) do
-    quote do: rem(unquote(n), 2) != 0
-  end
-
-  @doc """
-  Returns true if `n` is an even number, otherwise false.
-  """
-  defmacro is_even(n) do
-    quote do: rem(unquote(n), 2) == 0
-  end
-
   ## Private functions
 
   # Extracts concatenations in order to optimize many

lib/elixir/src/elixir_dispatch.erl

@@ -17,7 +17,7 @@ default_functions() ->
 default_macros() ->
   [ { ?builtin, elixir_imported_macros() } ].
 default_requires() ->
-  [ ?builtin, 'Elixir.Kernel.Typespec', 'Elixir.Record' ].
+  [ 'Elixir.Integer', 'Elixir.Kernel', 'Elixir.Kernel.Typespec', 'Elixir.Record' ].
 
 find_import(Meta, Name, Arity, S) ->
   Tuple = { Name, Arity },

lib/elixir/test/elixir/integer_test.exs

@@ -0,0 +1,23 @@
+Code.require_file "test_helper.exs", __DIR__
+
+defmodule IntegerTest do
+  use ExUnit.Case, async: true
+
+  test :odd? do
+    assert Integer.odd?(1) == true
+    assert Integer.odd?(2) == false
+    assert Integer.odd?(3) == true
+    assert Integer.odd?(-1) == true
+    assert Integer.odd?(-2) == false
+    assert Integer.odd?(-3) == true
+  end
+
+  test :even? do
+    assert Integer.even?(1) == false
+    assert Integer.even?(2) == true
+    assert Integer.even?(3) == false
+    assert Integer.even?(-1) == false
+    assert Integer.even?(-2) == true
+    assert Integer.even?(-3) == false
+  end
+end

lib/elixir/test/elixir/kernel/errors_test.exs

@@ -304,7 +304,7 @@ defmodule Kernel.ErrorsTest do
   test :unrequired_macro do
     assert_compile_fail CompileError,
       "nofile:2: tried to invoke macro Kernel.ErrorsTest.UnproperMacro.unproper/1 " <>
-      "but module was not required. Required: Kernel, Kernel.Typespec, Record",
+      "but module was not required. Required: Integer, Kernel, Kernel.Typespec, Record",
       '''
       defmodule ErrorsTest do
         Kernel.ErrorsTest.UnproperMacro.unproper([])

lib/elixir/test/elixir/kernel_test.exs

@@ -458,24 +458,6 @@ defmodule KernelTest do
       end
     end
 
-    test :is_odd do
-      assert is_odd(1) == true
-      assert is_odd(2) == false
-      assert is_odd(3) == true
-      assert is_odd(-1) == true
-      assert is_odd(-2) == false
-      assert is_odd(-3) == true
-    end
-
-    test :is_even do
-      assert is_even(1) == false
-      assert is_even(2) == true
-      assert is_even(3) == false
-      assert is_even(-1) == false
-      assert is_even(-2) == true
-      assert is_even(-3) == false
-    end
-
     defp a_list, do: [1, 2, 3]
     defp a_nil, do: nil
   end